You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/25 02:33:07 UTC
[GitHub] [airflow] leahecole opened a new pull request #17820: Allow omission of `initial_node_count` if `node_pools` is specified
leahecole opened a new pull request #17820:
URL: https://github.com/apache/airflow/pull/17820
According to the [API reference](https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/projects.locations.clusters#Cluster), the `initial_node_count` is not needed when you are configuring `node_pools`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] leahecole commented on pull request #17820: Allow omission of `initial_node_count` if `node_pools` is specified
Posted by GitBox <gi...@apache.org>.
leahecole commented on pull request #17820:
URL: https://github.com/apache/airflow/pull/17820#issuecomment-906938369
Okay! This is ready. I got myself really tangled in some boolean logic but have since recovered 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] leahecole merged pull request #17820: Allow omission of `initial_node_count` if `node_pools` is specified
Posted by GitBox <gi...@apache.org>.
leahecole merged pull request #17820:
URL: https://github.com/apache/airflow/pull/17820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] leahecole commented on pull request #17820: Allow omission of `initial_node_count` if `node_pools` is specified
Posted by GitBox <gi...@apache.org>.
leahecole commented on pull request #17820:
URL: https://github.com/apache/airflow/pull/17820#issuecomment-905603682
Apologies - I'll fix the static checks later today. I also have a second check I think i need to add to make sure you don't have both an initial node count AND nodepools
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17820: Allow omission of `initial_node_count` if `node_pools` is specified
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17820:
URL: https://github.com/apache/airflow/pull/17820#issuecomment-907296222
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org