You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/21 07:55:06 UTC
[GitHub] [incubator-nuttx-apps] jerpelea opened a new pull request, #1146: LICENSE: document remaining files
jerpelea opened a new pull request, #1146:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1146
## Summary
Document remaining licenses in the LICENSE file and add missing license
## Impact
LICENSE
## Testing
NONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1146: LICENSE: document remaining files
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1146:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1146#discussion_r855108637
##########
interpreters/ficl/src/nuttx.h:
##########
@@ -1,3 +1,27 @@
+/***************************************************************************
+ * apps/interpreters/ficl/src/nuttx.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ***************************************************************************/
+
Review Comment:
yes. wrote "done as a separate PR in mainline", so just pointing it here for tracking.
I was thinking to add it to mainline by myself, but I think that this PR should be cherry-picked to mainline in prior to other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on a diff in pull request #1146: LICENSE: document remaining files
Posted by GitBox <gi...@apache.org>.
jerpelea commented on code in PR #1146:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1146#discussion_r855060409
##########
interpreters/ficl/src/nuttx.h:
##########
@@ -1,3 +1,27 @@
+/***************************************************************************
+ * apps/interpreters/ficl/src/nuttx.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ***************************************************************************/
+
Review Comment:
I think that we are going outside the scope of this commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1146: LICENSE: document remaining files
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1146:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1146#discussion_r855057170
##########
interpreters/ficl/src/nuttx.h:
##########
@@ -1,3 +1,27 @@
+/***************************************************************************
+ * apps/interpreters/ficl/src/nuttx.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ***************************************************************************/
+
Review Comment:
Probably need to add
```
#ifndef __APPS_INTERPRETERS_FICL_SRC_NUTTX_H
#define __APPS_INTERPRETERS_FICL_SRC_NUTTX_H
```
as well. But may be done as a separate PR in mainline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #1146: LICENSE: document remaining files
Posted by GitBox <gi...@apache.org>.
jerpelea commented on PR #1146:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1146#issuecomment-1104876261
please ignore the remaining nxstyle errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on a diff in pull request #1146: LICENSE: document remaining files
Posted by GitBox <gi...@apache.org>.
jerpelea commented on code in PR #1146:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1146#discussion_r855123513
##########
interpreters/ficl/src/nuttx.h:
##########
@@ -1,3 +1,27 @@
+/***************************************************************************
+ * apps/interpreters/ficl/src/nuttx.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ***************************************************************************/
+
Review Comment:
I will push to master after this one is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1146: LICENSE: document remaining files
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1146:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org