You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Pavel Afremov (JIRA)" <ji...@apache.org> on 2007/11/01 16:34:50 UTC
[jira] Created: (HARMONY-5057) [drlvm][jit] JVMTI PopFrame on Linux
x86-64.
[drlvm][jit] JVMTI PopFrame on Linux x86-64.
--------------------------------------------
Key: HARMONY-5057
URL: https://issues.apache.org/jira/browse/HARMONY-5057
Project: Harmony
Issue Type: Improvement
Components: DRLVM
Reporter: Pavel Afremov
I've enabled JVMTI PopFrame on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5057) [drlvm][jit] JVMTI PopFrame on Linux
x86-64.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5057:
-----------------------------------
Attachment: pop_frame_enabling.patch
> [drlvm][jit] JVMTI PopFrame on Linux x86-64.
> --------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Attachments: pop_frame_enabling.patch
>
>
> I've enabled JVMTI PopFrame on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5057) [drlvm][jvmti] Make JVMTI PopFrame
platform independent and enable it on Linux x86-64.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5057:
-----------------------------------
Description: I've made JVMTI PopFrame platform independent and enabled it on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch (was: I've enabled JVMTI PopFrame on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch)
Summary: [drlvm][jvmti] Make JVMTI PopFrame platform independent and enable it on Linux x86-64. (was: [drlvm][jvmti] JVMTI PopFrame on Linux x86-64.)
> [drlvm][jvmti] Make JVMTI PopFrame platform independent and enable it on Linux x86-64.
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Attachments: pop_frame_enabling.patch, pop_frame_enabling.patch
>
>
> I've made JVMTI PopFrame platform independent and enabled it on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5057) [drlvm][jvmti] Make JVMTI PopFrame
platform independent and enable it on Linux x86-64.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5057:
-----------------------------------
Attachment: pop_frame_enabling.patch
Fixed patch which provide pop frame functionality in platform independent manner.
> [drlvm][jvmti] Make JVMTI PopFrame platform independent and enable it on Linux x86-64.
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Attachments: pop_frame_enabling.patch, pop_frame_enabling.patch, pop_frame_enabling.patch
>
>
> I've made JVMTI PopFrame platform independent and enabled it on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5057) [drlvm][jvmti] Make JVMTI PopFrame
platform independent and enable it on Linux x86-64.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov closed HARMONY-5057.
----------------------------------
> [drlvm][jvmti] Make JVMTI PopFrame platform independent and enable it on Linux x86-64.
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Alexey Varlamov
> Attachments: pop_frame_enabling.patch, pop_frame_enabling.patch, pop_frame_enabling.patch
>
>
> I've made JVMTI PopFrame platform independent and enabled it on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5057) [drlvm][jvmti] JVMTI PopFrame on
Linux x86-64.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5057:
-----------------------------------
Summary: [drlvm][jvmti] JVMTI PopFrame on Linux x86-64. (was: [drlvm][jit] JVMTI PopFrame on Linux x86-64.)
> [drlvm][jvmti] JVMTI PopFrame on Linux x86-64.
> ----------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Attachments: pop_frame_enabling.patch, pop_frame_enabling.patch
>
>
> I've enabled JVMTI PopFrame on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5057) [drlvm][jvmti] Make JVMTI PopFrame
platform independent and enable it on Linux x86-64.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546240 ]
Pavel Afremov commented on HARMONY-5057:
----------------------------------------
In attached patch size of m2n frame is increased on the size of 1 pointer. Taking in account that stack on x86-64 platform should by aligned on 16 (+8) bytes, additional alignment changed from 8 to 0.
// Stack size should be (% 8 == 0) but shouldn't be (% 16 == 0)
-const int ALIGNMENT = 8;
+const int ALIGNMENT = 0;
> [drlvm][jvmti] Make JVMTI PopFrame platform independent and enable it on Linux x86-64.
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Alexey Varlamov
> Attachments: pop_frame_enabling.patch, pop_frame_enabling.patch, pop_frame_enabling.patch
>
>
> I've made JVMTI PopFrame platform independent and enabled it on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5057) [drlvm][jit] JVMTI PopFrame on Linux
x86-64.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5057:
-----------------------------------
Attachment: pop_frame_enabling.patch
Corrected patch with fixed bugs.
> [drlvm][jit] JVMTI PopFrame on Linux x86-64.
> --------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Attachments: pop_frame_enabling.patch, pop_frame_enabling.patch
>
>
> I've enabled JVMTI PopFrame on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5057) [drlvm][jvmti] Make JVMTI PopFrame
platform independent and enable it on Linux x86-64.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545937 ]
Pavel Afremov commented on HARMONY-5057:
----------------------------------------
New patch include assertion in JIT, which prevent jit functions usage in incorrect context
> [drlvm][jvmti] Make JVMTI PopFrame platform independent and enable it on Linux x86-64.
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Attachments: pop_frame_enabling.patch, pop_frame_enabling.patch, pop_frame_enabling.patch
>
>
> I've made JVMTI PopFrame platform independent and enabled it on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5057) [drlvm][jvmti] Make JVMTI PopFrame
platform independent and enable it on Linux x86-64.
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov reassigned HARMONY-5057:
----------------------------------------
Assignee: Alexey Varlamov
> [drlvm][jvmti] Make JVMTI PopFrame platform independent and enable it on Linux x86-64.
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Alexey Varlamov
> Attachments: pop_frame_enabling.patch, pop_frame_enabling.patch, pop_frame_enabling.patch
>
>
> I've made JVMTI PopFrame platform independent and enabled it on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5057) [drlvm][jit] JVMTI PopFrame on Linux
x86-64.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5057:
-----------------------------------
Patch Info: (was: [Patch Available])
> [drlvm][jit] JVMTI PopFrame on Linux x86-64.
> --------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Attachments: pop_frame_enabling.patch
>
>
> I've enabled JVMTI PopFrame on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5057) [drlvm][jvmti] Make JVMTI PopFrame
platform independent and enable it on Linux x86-64.
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov resolved HARMONY-5057.
--------------------------------------
Resolution: Fixed
I applied the patch at revision: 599008.
Still, why do we hardcode these numbers, e.g.
port/src/lil/em64t/pim/m2n_em64t_internal.h:
#ifdef _WIN64
const unsigned m2n_sizeof_m2n_frame = 120;
#else
const unsigned m2n_sizeof_m2n_frame = 104;
#endif
vmcore/src/util/em64t/base/compile_em64t.cpp:
// Stack size should be (% 8 == 0) but shouldn't be (% 16 == 0)
const int ALIGNMENT = 0;
Doesn't it worth to let compiler calculate such values?
> [drlvm][jvmti] Make JVMTI PopFrame platform independent and enable it on Linux x86-64.
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Alexey Varlamov
> Attachments: pop_frame_enabling.patch, pop_frame_enabling.patch, pop_frame_enabling.patch
>
>
> I've made JVMTI PopFrame platform independent and enabled it on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5057) [drlvm][jvmti] Make JVMTI PopFrame
platform independent and enable it on Linux x86-64.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5057:
-----------------------------------
Patch Info: [Patch Available]
> [drlvm][jvmti] Make JVMTI PopFrame platform independent and enable it on Linux x86-64.
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-5057
> URL: https://issues.apache.org/jira/browse/HARMONY-5057
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Attachments: pop_frame_enabling.patch, pop_frame_enabling.patch, pop_frame_enabling.patch
>
>
> I've made JVMTI PopFrame platform independent and enabled it on Linux x86-64 using fix_handler_context method of JIT. You can find my changes in attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.