You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/25 14:11:35 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request, #6148: arch/xtensa: Refactor assembly macros
Ouss4 opened a new pull request, #6148:
URL: https://github.com/apache/incubator-nuttx/pull/6148
## Summary
1. Move the `ps_setup` macro to a common place to not call it each time.
2. Group different assembly macros in one file to avoid redefining them each time.
## Impact
N/A
## Testing
ESP32 defconfigs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei merged pull request #6148: arch/xtensa: Refactor assembly macros
Posted by GitBox <gi...@apache.org>.
gustavonihei merged PR #6148:
URL: https://github.com/apache/incubator-nuttx/pull/6148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a diff in pull request #6148: arch/xtensa: Refactor assembly macros
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on code in PR #6148:
URL: https://github.com/apache/incubator-nuttx/pull/6148#discussion_r859897841
##########
arch/xtensa/src/common/xtensa_panic.S:
##########
@@ -147,14 +129,7 @@ _xtensa_panic:
/* Set up PS for C, re-enable hi-pri interrupts, and clear EXCM. */
-#ifdef __XTENSA_CALL0_ABI__
- movi a0, PS_INTLEVEL(XCHAL_EXCM_LEVEL) | PS_UM
-#else
- movi a0, PS_INTLEVEL(XCHAL_EXCM_LEVEL) | PS_UM | PS_WOE
-#endif
-
- wsr a0, PS
- rsync
+ ps_setup XCHAL_EXCM_LEVEL a0
Review Comment:
Forgot to convert spaces to tabs in this file. I do it in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6148: arch/xtensa: Refactor assembly macros
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6148:
URL: https://github.com/apache/incubator-nuttx/pull/6148#discussion_r859854635
##########
arch/xtensa/src/common/xtensa_panic.S:
##########
@@ -147,14 +129,7 @@ _xtensa_panic:
/* Set up PS for C, re-enable hi-pri interrupts, and clear EXCM. */
-#ifdef __XTENSA_CALL0_ABI__
- movi a0, PS_INTLEVEL(XCHAL_EXCM_LEVEL) | PS_UM
-#else
- movi a0, PS_INTLEVEL(XCHAL_EXCM_LEVEL) | PS_UM | PS_WOE
-#endif
-
- wsr a0, PS
- rsync
+ ps_setup XCHAL_EXCM_LEVEL a0
Review Comment:
not alignment here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org