[GitHub] [arrow] pitrou commented on a change in pull request #10470: ARROW-12983: [C++][Python][R] Properly overflow to chunked array in Python-to-Arrow conversion

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #10470:
URL: https://github.com/apache/arrow/pull/10470#discussion_r653794223



##########
File path: cpp/src/arrow/python/python_to_arrow.cc
##########
@@ -585,6 +619,37 @@ class PyPrimitiveConverter<T, enable_if_string_like<T>>
     return Status::OK();
   }
 
+  Result<int64_t> ExtendAsMuchAsPossible(PyObject* values, int64_t size,

Review comment:
       Can you try to reconcile the `PyPrimitiveConverter` for binary and string types? They really look very similar.

##########
File path: cpp/src/arrow/python/iterators.h
##########
@@ -84,18 +84,29 @@ inline Status VisitSequenceGeneric(PyObject* obj, VisitorFunc&& func) {
   return Status::OK();
 }
 
-// Visit sequence with no null mask
+// Visit sequence with no null mask or offset
 template <class VisitorFunc>
 inline Status VisitSequence(PyObject* obj, VisitorFunc&& func) {

Review comment:
       How about always passing `offset`? That will simplify the overloads a bit (this should not be considered a public API).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org