[jira] [Commented] (AIRFLOW-3258) Add ability to set Environment Variables for pods brought up by Kubernetes Executor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756586#comment-16756586 ] 

ASF GitHub Bot commented on AIRFLOW-3258:
-----------------------------------------

davlum commented on pull request #4627: [AIRFLOW-3258] K8S executor, optional mount current env in worker pods
URL: https://github.com/apache/airflow/pull/4627
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3258
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   Add ability to add the environment variables of the scheduler pod to the worker pods brought up by the K8S executor. Also add a section to the airflow.cfg to define non-secret environment variables
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add ability to set Environment Variables for pods brought up by Kubernetes Executor
> -----------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3258
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3258
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: kubernetes
>    Affects Versions: 1.10.0
>            Reporter: David Lum
>            Assignee: David Lum
>            Priority: Minor
>              Labels: kubernetes
>             Fix For: 1.10.0
>
>
> Currently the only way to add arbitrary environment variables to pods brought up by the KubernetesExecutor is to add them using Kubernetes secrets, and then specifying those secrets in the in the kubernetes_secrets section of the the airflow.cfg. However, not all environment variables are secrets and need to be encoded. The suggestion would be to add another section to the airflow.cfg, kubernetes_environment_variables. On top of this, a short hand could be to add all the env vars in the current environment to the pods being brought up. This could be set with a boolean flag in the kubernetes section of the airflow.cfg which would to default to false, and have a name such as insert_current_environment. Any environment variables set in the kubernetes_environment_variables section, as well as those that are hard coded such as AIRFLOW_\_CORE\__EXECUTOR would overwrite those present in the current environment when applied to the worker pod.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)