You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "ImprovingRichard (via GitHub)" <gi...@apache.org> on 2023/02/20 14:34:28 UTC

[GitHub] [pinot] ImprovingRichard commented on a diff in pull request #10292: [feature] Add jdbc multistage support

ImprovingRichard commented on code in PR #10292:
URL: https://github.com/apache/pinot/pull/10292#discussion_r1112030426


##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotConnection.java:
##########
@@ -38,11 +40,16 @@
 public class PinotConnection extends AbstractBaseConnection {
 
   private static final Logger LOGGER = LoggerFactory.getLogger(Connection.class);
+  protected static final String[] POSSIBLE_QUERY_OPTIONS = {
+    QueryOptionKey.ENABLE_NULL_HANDLING,
+    QueryOptionKey.USE_MULTISTAGE_ENGINE
+  };
   private org.apache.pinot.client.Connection _session;
   private boolean _closed;
   private String _controllerURL;
   private PinotControllerTransport _controllerTransport;
-  private final boolean _enableNullHandling;
+  private final HashMap<String, Boolean> _queryOptions = new HashMap<String, Boolean>();

Review Comment:
   WIll do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org