You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/12/20 04:38:18 UTC
Review Request 29290: Created IP address abstraction for different
protocol families
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Dominic Hamon.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
The Address can be in NETWORK or BYTE order.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs
-----
src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/port_mapping_tests.cpp eb82993520f7e8de46cf6cf6b638a9286aa9b3df
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review65726
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On Dec. 20, 2014, 3:39 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2014, 3:39 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> The Address can be in NETWORK or BYTE order.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/port_mapping_tests.cpp eb82993520f7e8de46cf6cf6b638a9286aa9b3df
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review66339
-----------------------------------------------------------
Bad patch!
Reviews applied: [29288, 29289, 29290]
Failed command: ./support/apply-review.sh -n -r 29290
Error:
2014-12-30 05:28:02 URL:https://reviews.apache.org/r/29290/diff/raw/ [24147/24147] -> "29290.patch" [1]
error: patch failed: src/common/protobuf_utils.hpp:21
error: src/common/protobuf_utils.hpp: patch does not apply
error: patch failed: src/common/protobuf_utils.cpp:110
error: src/common/protobuf_utils.cpp: patch does not apply
error: patch failed: src/linux/routing/diagnosis/diagnosis.cpp:41
error: src/linux/routing/diagnosis/diagnosis.cpp: patch does not apply
error: patch failed: src/linux/routing/filter/icmp.cpp:105
error: src/linux/routing/filter/icmp.cpp: patch does not apply
error: patch failed: src/linux/routing/filter/ip.cpp:159
error: src/linux/routing/filter/ip.cpp: patch does not apply
error: patch failed: src/linux/routing/route.cpp:83
error: src/linux/routing/route.cpp: patch does not apply
error: patch failed: src/master/http.cpp:350
error: src/master/http.cpp: patch does not apply
error: patch failed: src/master/master.cpp:229
error: src/master/master.cpp: patch does not apply
error: patch failed: src/sched/sched.cpp:1135
error: src/sched/sched.cpp: patch does not apply
error: patch failed: src/scheduler/scheduler.cpp:127
error: src/scheduler/scheduler.cpp: patch does not apply
error: patch failed: src/slave/containerizer/isolators/network/port_mapping.cpp:958
error: src/slave/containerizer/isolators/network/port_mapping.cpp: patch does not apply
error: patch failed: src/slave/slave.cpp:169
error: src/slave/slave.cpp: patch does not apply
error: patch failed: src/tests/master_contender_detector_tests.cpp:130
error: src/tests/master_contender_detector_tests.cpp: patch does not apply
error: patch failed: src/tests/master_tests.cpp:966
error: src/tests/master_tests.cpp: patch does not apply
error: patch failed: src/tests/port_mapping_tests.cpp:189
error: src/tests/port_mapping_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Dec. 30, 2014, 5:21 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 5:21 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/port_mapping_tests.cpp eb82993520f7e8de46cf6cf6b638a9286aa9b3df
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Jan. 6, 2015, 5:41 p.m., Dominic Hamon wrote:
> > src/linux/routing/filter/icmp.cpp, line 106
> > <https://reviews.apache.org/r/29290/diff/4/?file=807779#file807779line106>
> >
> > indent
Try <struct in_addr> ipv4Address = net::IP::Address::hostToNetwork(classifier.destinationIP().get().address()).ipv4Address();
How should I split this line ?
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review66866
-----------------------------------------------------------
On Jan. 7, 2015, 7:33 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 7:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Jan. 6, 2015, 9:41 a.m., Dominic Hamon wrote:
> > src/linux/routing/filter/icmp.cpp, line 106
> > <https://reviews.apache.org/r/29290/diff/4/?file=807779#file807779line106>
> >
> > indent
>
> Evelina Dumitrescu wrote:
> Try <struct in_addr> ipv4Address = net::IP::Address::hostToNetwork(classifier.destinationIP().get().address()).ipv4Address();
> How should I split this line ?
Try<struct in_addr> ipv4Address = net::IP::Address::hostToNetwork(
classifier.destinationIP().get().address()).ipv4Address();
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review66866
-----------------------------------------------------------
On Jan. 7, 2015, 11:33 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 11:33 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Jan. 6, 2015, 5:41 p.m., Dominic Hamon wrote:
> > src/common/protobuf_utils.hpp, line 61
> > <https://reviews.apache.org/r/29290/diff/4/?file=807776#file807776line61>
> >
> > why wouldn't this just be:
> >
> > net::IP::Address getIPAddressFromMasterInfo(...)
> >
> > and worry about the IPv6 implementation later.
I am going to add getIPv6AddressFromMasterInfo in the next patch, when I am going to impelement IPv6 support for the protobuffers.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review66866
-----------------------------------------------------------
On Jan. 7, 2015, 6:16 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 6:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review66866
-----------------------------------------------------------
src/common/protobuf_utils.hpp
<https://reviews.apache.org/r/29290/#comment110547>
why wouldn't this just be:
net::IP::Address getIPAddressFromMasterInfo(...)
and worry about the IPv6 implementation later.
src/linux/routing/filter/icmp.cpp
<https://reviews.apache.org/r/29290/#comment110551>
no space after 'Try'
src/linux/routing/filter/icmp.cpp
<https://reviews.apache.org/r/29290/#comment110549>
indent
src/linux/routing/route.cpp
<https://reviews.apache.org/r/29290/#comment110548>
indent is off here.
src/master/http.cpp
<https://reviews.apache.org/r/29290/#comment110552>
indent
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/29290/#comment110553>
add a TODO for IPv6
- Dominic Hamon
On Jan. 6, 2015, 6:17 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 6:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review67126
-----------------------------------------------------------
src/linux/routing/diagnosis/diagnosis.cpp
<https://reviews.apache.org/r/29290/#comment110963>
much less indent here please
src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/29290/#comment110964>
two extra spaces here.
src/linux/routing/route.cpp
<https://reviews.apache.org/r/29290/#comment110960>
you have a few extra spaces in your indent. see how it was indented before? do it the same :)
src/linux/routing/route.cpp
<https://reviews.apache.org/r/29290/#comment110961>
too few spaces here :)
src/linux/routing/route.cpp
<https://reviews.apache.org/r/29290/#comment110962>
two extra spaces on this indent please
src/master/master.cpp
<https://reviews.apache.org/r/29290/#comment110965>
smaller indent here
src/sched/sched.cpp
<https://reviews.apache.org/r/29290/#comment110966>
you know what i'm going to write, right?
src/scheduler/scheduler.cpp
<https://reviews.apache.org/r/29290/#comment110967>
and again
src/slave/slave.cpp
<https://reviews.apache.org/r/29290/#comment110968>
yep. same.
- Dominic Hamon
On Jan. 7, 2015, 12:13 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 12:13 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review67331
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On Jan. 8, 2015, 10:53 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 10:53 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review69833
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On Jan. 27, 2015, 4:58 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 4:58 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f
> src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
> src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
> src/slave/containerizer/isolators/network/port_mapping.cpp b484bbf34060ccc9debd48a3e840c03c8f95de09
> src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
> src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review70104
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On Jan. 28, 2015, 10:04 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 10:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 3981b18cb82d3b8bd974b80d27f14c304898a43c
> src/master/master.cpp 54f26900ac8c63e79a1f89562a988c9a2567d209
> src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
> src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
> src/slave/containerizer/isolators/network/port_mapping.cpp b484bbf34060ccc9debd48a3e840c03c8f95de09
> src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
> src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review70228
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Jan. 28, 2015, 2:04 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 2:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 3981b18cb82d3b8bd974b80d27f14c304898a43c
> src/master/master.cpp 54f26900ac8c63e79a1f89562a988c9a2567d209
> src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
> src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
> src/slave/containerizer/isolators/network/port_mapping.cpp b484bbf34060ccc9debd48a3e840c03c8f95de09
> src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
> src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Feb. 11, 2015, 6:04 p.m., Dominic Hamon wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1057
> > <https://reviews.apache.org/r/29290/diff/15/?file=860876#file860876line1057>
> >
> > what's the difference between net::IP and net::ip?
> >
> > that's a confusing API.
it retrieves the ip from a specific interface.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review71981
-----------------------------------------------------------
On Feb. 11, 2015, 3:39 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 3:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
> src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
> src/master/master.cpp 9e75b6c68854e6994e54a113f015831c4fb52a58
> src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
> src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
> src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
> src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635
> src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
> src/tests/master_tests.cpp c678527942506ef23fa4f1aebf9664e4cc21b561
> src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Feb. 11, 2015, 6:04 p.m., Dominic Hamon wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, line 128
> > <https://reviews.apache.org/r/29290/diff/15/?file=860876#file860876line128>
> >
> > while you're here, we should remove this static non-POD [MESOS-1023].
> >
> > static const net::IP& loopbackIP() {
> > static const net::IP ip = net::IP::fromDecimal("127.0.0.1/8").get();
> > return ip;
> > }
added the method inside the IP class
> On Feb. 11, 2015, 6:04 p.m., Dominic Hamon wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1057
> > <https://reviews.apache.org/r/29290/diff/15/?file=860876#file860876line1057>
> >
> > what's the difference between net::IP and net::ip?
> >
> > that's a confusing API.
>
> Evelina Dumitrescu wrote:
> it retrieves the ip from a specific interface.
renamed to fromLinkDevice and move to the IP class
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review71981
-----------------------------------------------------------
On Feb. 12, 2015, 5:47 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 5:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
> src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
> src/master/master.cpp 9e75b6c68854e6994e54a113f015831c4fb52a58
> src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
> src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
> src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
> src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635
> src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
> src/tests/master_tests.cpp c678527942506ef23fa4f1aebf9664e4cc21b561
> src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review71981
-----------------------------------------------------------
src/linux/routing/diagnosis/diagnosis.cpp
<https://reviews.apache.org/r/29290/#comment117896>
s/IPSrc/ipSrc/
s/IPDst/ipDst/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/29290/#comment117897>
while you're here, we should remove this static non-POD [MESOS-1023].
static const net::IP& loopbackIP() {
static const net::IP ip = net::IP::fromDecimal("127.0.0.1/8").get();
return ip;
}
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/29290/#comment117898>
this is awkward. should there be a 'as_ipv4' that returns a Try<IP>?
then this would be:
loopbackIP().as_ipv4().get()
and you'd avoid the extra net::IP constructor.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/29290/#comment117900>
what's the difference between net::IP and net::ip?
that's a confusing API.
- Dominic Hamon
On Feb. 11, 2015, 7:39 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 7:39 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
> src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
> src/master/master.cpp 9e75b6c68854e6994e54a113f015831c4fb52a58
> src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
> src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
> src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
> src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635
> src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
> src/tests/master_tests.cpp c678527942506ef23fa4f1aebf9664e4cc21b561
> src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review71971
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On Feb. 11, 2015, 3:39 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 3:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
> src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
> src/master/master.cpp 9e75b6c68854e6994e54a113f015831c4fb52a58
> src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
> src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
> src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
> src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635
> src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
> src/tests/master_tests.cpp c678527942506ef23fa4f1aebf9664e4cc21b561
> src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review72202
-----------------------------------------------------------
Bad patch!
Reviews applied: [29288, 29289, 29290]
Failed command: make -j3 distcheck
Error:
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d "mesos-0.22.0"; then find "mesos-0.22.0" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "mesos-0.22.0" || { sleep 5 && rm -rf "mesos-0.22.0"; }; else :; fi
test -d "mesos-0.22.0" || mkdir "mesos-0.22.0"
(cd 3rdparty && make top_distdir=../mesos-0.22.0 distdir=../mesos-0.22.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd libprocess && make top_distdir=../../mesos-0.22.0 distdir=../../mesos-0.22.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d "../../mesos-0.22.0/3rdparty/libprocess" || mkdir "../../mesos-0.22.0/3rdparty/libprocess"
(cd 3rdparty && make top_distdir=../../../mesos-0.22.0 distdir=../../../mesos-0.22.0/3rdparty/libprocess/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd stout && make top_distdir=../../../../mesos-0.22.0 distdir=../../../../mesos-0.22.0/3rdparty/libprocess/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[5]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d "../../../../mesos-0.22.0/3rdparty/libprocess/3rdparty/stout" || mkdir "../../../../mesos-0.22.0/3rdparty/libprocess/3rdparty/stout"
(cd include && make top_distdir=../../../../../mesos-0.22.0 distdir=../../../../../mesos-0.22.0/3rdparty/libprocess/3rdparty/stout/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[6]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
make[6]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
test -n ":" \
|| find "../../../../mesos-0.22.0/3rdparty/libprocess/3rdparty/stout" -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh -c -m a+r {} {} \; \
|| chmod -R a+r "../../../../mesos-0.22.0/3rdparty/libprocess/3rdparty/stout"
make[5]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd include && make top_distdir=../../../mesos-0.22.0 distdir=../../../mesos-0.22.0/3rdparty/libprocess/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
test -n ":" \
|| find "../../mesos-0.22.0/3rdparty/libprocess" -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh -c -m a+r {} {} \; \
|| chmod -R a+r "../../mesos-0.22.0/3rdparty/libprocess"
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd src && make top_distdir=../mesos-0.22.0 distdir=../mesos-0.22.0/src \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
test ".." = ".." || \
(/bin/mkdir -p python/src/mesos && cp -pf ./python/src/mesos/__init__.py python/src/mesos/__init__.py)
test ".." = ".." || \
(/bin/mkdir -p python/interface/src/mesos && cp -pf ./python/interface/src/mesos/__init__.py python/interface/src/mesos/__init__.py)
test ".." = ".." || \
(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf ./python/interface/src/mesos/interface/__init__.py python/interface/src/mesos/interface/__init__.py)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos && cp -pf ./python/native/src/mesos/__init__.py python/native/src/mesos/__init__.py)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/__init__.py python/native/src/mesos/native/__init__.py)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/mesos_executor_driver_impl.cpp python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/mesos_executor_driver_impl.hpp python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/module.cpp python/native/src/mesos/native/module.cpp)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/module.hpp python/native/src/mesos/native/module.hpp)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/proxy_executor.cpp python/native/src/mesos/native/proxy_executor.cpp)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/proxy_executor.hpp python/native/src/mesos/native/proxy_executor.hpp)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/proxy_scheduler.cpp python/native/src/mesos/native/proxy_scheduler.cpp)
test ".." = ".." || \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/proxy_scheduler.hpp python/native/src/mesos/native/proxy_scheduler.hpp)
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
(cd ec2 && make top_distdir=../mesos-0.22.0 distdir=../mesos-0.22.0/ec2 \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/ec2'
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/ec2'
test -n "" \
|| find "mesos-0.22.0" -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/install-sh -c -m a+r {} {} \; \
|| chmod -R a+r "mesos-0.22.0"
tardir=mesos-0.22.0 && ${TAR-tar} chof - "$tardir" | GZIP=--best gzip -c >mesos-0.22.0.tar.gz
make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d "mesos-0.22.0"; then find "mesos-0.22.0" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "mesos-0.22.0" || { sleep 5 && rm -rf "mesos-0.22.0"; }; else :; fi
case 'mesos-0.22.0.tar.gz' in \
*.tar.gz*) \
GZIP=--best gzip -dc mesos-0.22.0.tar.gz | ${TAR-tar} xf - ;;\
*.tar.bz2*) \
bzip2 -dc mesos-0.22.0.tar.bz2 | ${TAR-tar} xf - ;;\
*.tar.lz*) \
lzip -dc mesos-0.22.0.tar.lz | ${TAR-tar} xf - ;;\
*.tar.xz*) \
xz -dc mesos-0.22.0.tar.xz | ${TAR-tar} xf - ;;\
*.tar.Z*) \
uncompress -c mesos-0.22.0.tar.Z | ${TAR-tar} xf - ;;\
*.shar.gz*) \
GZIP=--best gzip -dc mesos-0.22.0.shar.gz | unshar ;;\
*.zip*) \
unzip mesos-0.22.0.zip ;;\
esac
chmod -R a-w mesos-0.22.0
chmod u+w mesos-0.22.0
mkdir mesos-0.22.0/_build mesos-0.22.0/_inst
chmod a-w mesos-0.22.0
test -d mesos-0.22.0/_build || exit 0; \
dc_install_base=`CDPATH="${ZSH_VERSION+.}:" && cd mesos-0.22.0/_inst && pwd | sed -e 's,^[^:\\/]:[\\/],/,'` \
&& dc_destdir="${TMPDIR-/tmp}/am-dc-$$/" \
&& am__cwd=`pwd` \
&& CDPATH="${ZSH_VERSION+.}:" && cd mesos-0.22.0/_build \
&& ../configure \
--disable-python-dependency-install \
\
--srcdir=.. --prefix="$dc_install_base" \
&& make \
&& make dvi \
&& make check \
&& make install \
&& make installcheck \
&& make uninstall \
&& make distuninstallcheck_dir="$dc_install_base" \
distuninstallcheck \
&& chmod -R a-w "$dc_install_base" \
&& ({ \
(cd ../.. && umask 077 && mkdir "$dc_destdir") \
&& make DESTDIR="$dc_destdir" install \
&& make DESTDIR="$dc_destdir" uninstall \
&& make DESTDIR="$dc_destdir" \
distuninstallcheck_dir="$dc_destdir" distuninstallcheck; \
} || { rm -rf "$dc_destdir"; exit 1; }) \
&& rm -rf "$dc_destdir" \
&& make dist \
&& rm -rf mesos-0.22.0.tar.gz \
&& make distcleancheck \
&& cd "$am__cwd" \
|| exit 1
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking for ar... ar
checking the archiver (ar) interface... ar
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 3458764513820540925
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
configure: creating ./config.lt
config.lt: creating libtool
configure: Setting up build environment for x86_64 linux-gnu
checking whether we are using the GNU C++ compiler... (cached) yes
checking whether g++ accepts -g... (cached) yes
checking dependency style of g++... (cached) gcc3
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking if compiling with clang... no
configure: GCC version: 4.8
configure: Setting up CXXFLAGS for g++ version >= 4.8
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=c++11... yes
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking whether to check for GCC pthread/shared inconsistencies... yes
checking whether -pthread is sufficient with -shared... yes
checking for backtrace in -lunwind... no
checking for gzread in -lz... yes
checking for curl_global_init in -lcurl... yes
checking apr_pools.h usability... yes
checking apr_pools.h presence... yes
checking for apr_pools.h... yes
checking for apr_initialize in -lapr-1... yes
checking svn_version.h usability... yes
checking svn_version.h presence... yes
checking for svn_version.h... yes
checking for svn_stringbuf_create_ensure in -lsvn_subr-1... yes
checking svn_delta.h usability... yes
checking svn_delta.h presence... yes
checking for svn_delta.h... yes
checking for svn_txdelta in -lsvn_delta-1... yes
checking for sasl_done in -lsasl2... yes
checking whether or not we can build with JNI... yes
checking for mvn... /home/jenkins/tools/maven/latest/bin/mvn
checking for a Python interpreter with version >= 2.6... python
checking for python... /usr/bin/python
checking for python version... 2.7
checking for python platform... linux2
checking for python script directory... ${prefix}/lib/python2.7/site-packages
checking for python extension module directory... ${exec_prefix}/lib/python2.7/site-packages
checking for python2.7... (cached) /usr/bin/python
checking for a version of Python >= '2.1.0'... yes
checking for a version of Python >= '2.6'... yes
checking for the distutils Python package... yes
checking for Python include path... -I/usr/include/python2.7
checking for Python library path... -L/usr/lib -lpython2.7
checking for Python site-packages path... /usr/lib/python2.7/dist-packages
checking python extra libraries... -lpthread -ldl -lutil
checking python extra linking flags... -Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions
checking consistency of all components of python development environment... yes
checking whether we can build usable Python eggs... cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++ [enabled by default]
yes
checking for an old installation of the Mesos egg (before 0.20.0)... no
checking python2 module: boto... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating mesos.pc
config.status: creating ec2/Makefile
config.status: creating src/Makefile
config.status: creating 3rdparty/Makefile
config.status: creating bin/mesos.sh
config.status: creating bin/mesos-local.sh
config.status: creating bin/mesos-master.sh
config.status: creating bin/mesos-slave.sh
config.status: creating bin/mesos-tests.sh
config.status: creating bin/mesos-local-flags.sh
config.status: creating bin/mesos-master-flags.sh
config.status: creating bin/mesos-slave-flags.sh
config.status: creating bin/mesos-tests-flags.sh
config.status: creating bin/gdb-mesos-local.sh
config.status: creating bin/gdb-mesos-master.sh
config.status: creating bin/gdb-mesos-slave.sh
config.status: creating bin/gdb-mesos-tests.sh
config.status: creating bin/lldb-mesos-local.sh
config.status: creating bin/lldb-mesos-master.sh
config.status: creating bin/lldb-mesos-slave.sh
config.status: creating bin/lldb-mesos-tests.sh
config.status: creating bin/valgrind-mesos-local.sh
config.status: creating bin/valgrind-mesos-slave.sh
config.status: creating bin/valgrind-mesos-master.sh
config.status: creating bin/valgrind-mesos-tests.sh
config.status: creating src/deploy/mesos-daemon.sh
config.status: creating src/deploy/mesos-start-cluster.sh
config.status: creating src/deploy/mesos-start-masters.sh
config.status: creating src/deploy/mesos-start-slaves.sh
config.status: creating src/deploy/mesos-stop-cluster.sh
config.status: creating src/deploy/mesos-stop-masters.sh
config.status: creating src/deploy/mesos-stop-slaves.sh
config.status: creating include/mesos/version.hpp
config.status: creating src/java/generated/org/apache/mesos/MesosNativeLibrary.java
config.status: creating mpi/mpiexec-mesos
config.status: creating src/examples/java/test-exception-framework
config.status: creating src/examples/java/test-executor
config.status: creating src/examples/java/test-framework
config.status: creating src/examples/java/test-multiple-executors-framework
config.status: creating src/examples/java/test-log
config.status: creating src/java/mesos.pom
config.status: creating src/examples/python/test-executor
config.status: creating src/examples/python/test-framework
config.status: creating src/examples/python/test-containerizer
config.status: creating src/python/setup.py
config.status: creating src/python/interface/setup.py
config.status: creating src/python/native/ext_modules.py
config.status: creating src/python/native/setup.py
config.status: executing depfiles commands
config.status: executing libtool commands
=== configuring in 3rdparty/libprocess (/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess)
configure: running /bin/bash ../../../3rdparty/libprocess/configure --disable-option-checking '--prefix=/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_inst' '--disable-python-dependency-install' 'JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64' '--enable-shared=no' '--with-pic' --cache-file=/dev/null --srcdir=../../../3rdparty/libprocess
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking for ar... ar
checking the archiver (ar) interface... ar
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 3458764513820540925
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... no
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
configure: creating ./config.lt
config.lt: creating libtool
checking apr_pools.h usability... yes
checking apr_pools.h presence... yes
checking for apr_pools.h... yes
checking for apr_initialize in -lapr-1... yes
checking svn_version.h usability... yes
checking svn_version.h presence... yes
checking for svn_version.h... yes
checking for svn_stringbuf_create_ensure in -lsvn_subr-1... yes
checking svn_delta.h usability... yes
checking svn_delta.h presence... yes
checking for svn_delta.h... yes
checking for svn_txdelta in -lsvn_delta-1... yes
checking for curl_global_init in -lcurl... yes
checking whether we are using the GNU C++ compiler... (cached) yes
checking whether g++ accepts -g... (cached) yes
checking dependency style of g++... (cached) gcc3
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking if compiling with clang... no
configure: GCC version: 4.8
configure: Setting up CXXFLAGS for g++-4.8
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking whether to check for GCC pthread/shared inconsistencies... yes
checking whether -pthread is sufficient with -shared... yes
checking for deflate, gzread, gzwrite, inflate in -lz... yes
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=c++11... yes
checking for dlopen in -ldl... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating include/Makefile
config.status: creating 3rdparty/Makefile
config.status: creating 3rdparty/gmock_sources.cc
config.status: executing depfiles commands
config.status: executing libtool commands
=== configuring in 3rdparty/stout (/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/stout)
configure: running /bin/bash ../../../../../3rdparty/libprocess/3rdparty/stout/configure --disable-option-checking '--prefix=/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_inst' '--disable-python-dependency-install' 'JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64' '--enable-shared=no' '--with-pic' --cache-file=/dev/null --srcdir=../../../../../3rdparty/libprocess/3rdparty/stout
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating include/Makefile
make[1]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build'
Making all in .
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build'
make[2]: Nothing to be done for `all-am'.
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build'
Making all in 3rdparty
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty'
make all-recursive
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty'
Making all in libprocess
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess'
Making all in 3rdparty
make[5]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty'
gzip -d -c ../../../../3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz | tar xf -
gzip -d -c ../../../../3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz | tar xf -
test ! -e ../../../../3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch || patch -d ry-http-parser-1c3624a -p1 <../../../../3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch
touch ry-http-parser-1c3624a-stamp
test ! -e ../../../../3rdparty/libprocess/3rdparty/gmock-1.6.0.patch || patch -d gmock-1.6.0 -p1 <../../../../3rdparty/libprocess/3rdparty/gmock-1.6.0.patch
touch gmock-1.6.0-stamp
cd .. && /bin/bash ./config.status 3rdparty/gmock_sources.cc
config.status: creating 3rdparty/gmock_sources.cc
make all-recursive
make[6]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty'
Making all in stout
make[7]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/stout'
Making all in .
make[8]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/stout'
make[8]: Nothing to be done for `all-am'.
make[8]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/stout'
Making all in include
make[8]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/stout/include'
make[8]: Nothing to be done for `all'.
make[8]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/stout/include'
make[7]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/stout'
make[7]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty'
/bin/bash ../libtool --tag=CC --mode=compile gcc -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libprocess\ 0.0.1\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBDL=1 -I. -I../../../../3rdparty/libprocess/3rdparty -Iry-http-parser-1c3624a -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -g1 -O0 -Wno-unused-local-typedefs -MT libry_http_parser_la-http_parser.lo -MD -MP -MF .deps/libry_http_parser_la-http_parser.Tpo -c -o libry_http_parser_la-htt
p_parser.lo `test -f 'ry-http-parser-1c3624a/http_parser.c' || echo '../../../../3rdparty/libprocess/3rdparty/'`ry-http-parser-1c3624a/http_parser.c
gzip -d -c ../../../../3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz | tar xf -
gzip -d -c ../../../../3rdparty/libprocess/3rdparty/libev-4.15.tar.gz | tar xf -
test ! -e ../../../../3rdparty/libprocess/3rdparty/libev-4.15.patch || patch -d libev-4.15 -p1 <../../../../3rdparty/libprocess/3rdparty/libev-4.15.patch
patching file ev.h
touch libev-4.15-stamp
gzip -d -c ../../../../3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz | tar xf -
libtool: compile: gcc -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" "-DPACKAGE_STRING=\"libprocess 0.0.1\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBDL=1 -I. -I../../../../3rdparty/libprocess/3rdparty -Iry-http-parser-1c3624a -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -g1 -O0 -Wno-unused-local-typedefs -MT libry_http_parser_la-http_parser.lo -MD -MP -MF .deps/libry_http_parser_la-http_parser.Tpo -c ry-http-parser-1c3624a/http_parser.c -fPIC -DPIC -o libry
_http_parser_la-http_parser.o
test ! -e ../../../../3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch || patch -d protobuf-2.5.0 -p1 <../../../../3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch
touch protobuf-2.5.0-stamp
gzip -d -c ../../../../3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz | tar xf -
test ! -e ../../../../3rdparty/libprocess/3rdparty/picojson-4f93734.patch || patch -d picojson-4f93734 -p1 <../../../../3rdparty/libprocess/3rdparty/picojson-4f93734.patch
touch picojson-4f93734-stamp
gzip -d -c ../../../../3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz | tar xf -
test ! -e ../../../../3rdparty/libprocess/3rdparty/boost-1.53.0.patch || patch -d boost-1.53.0 -p1 <../../../../3rdparty/libprocess/3rdparty/boost-1.53.0.patch
touch boost-1.53.0-stamp
cd protobuf-2.5.0 && ./configure '--disable-option-checking' '--prefix=/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_inst' '--disable-python-dependency-install' 'JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64' '--enable-shared=no' '--with-pic' '--cache-file=/dev/null' '--srcdir=../../../3rdparty/libprocess' CXXFLAGS='-g1 -O0 -Wno-unused-local-typedefs -std=c++11' --enable-shared=no --with-pic --srcdir=. && \
make
test ! -e ../../../../3rdparty/libprocess/3rdparty/glog-0.3.3.patch || patch -d glog-0.3.3 -p1 <../../../../3rdparty/libprocess/3rdparty/glog-0.3.3.patch
patching file src/symbolize.cc
patching file src/glog/stl_logging.h.in
patching file src/stl_logging_unittest.cc
patching file src/demangle.cc
touch glog-0.3.3-stamp
cd libev-4.15 && ./configure '--disable-option-checking' '--prefix=/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_inst' '--disable-python-dependency-install' 'JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64' '--enable-shared=no' '--with-pic' '--cache-file=/dev/null' '--srcdir=../../../3rdparty/libprocess' CXXFLAGS='-g1 -O0 -Wno-unused-local-typedefs -std=c++11' --enable-shared=no --with-pic --srcdir=. && \
make
mv -f .deps/libry_http_parser_la-http_parser.Tpo .deps/libry_http_parser_la-http_parser.Plo
cd glog-0.3.3 && ./configure GTEST_CONFIG=no '--disable-option-checking' '--prefix=/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_inst' '--disable-python-dependency-install' 'JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64' '--enable-shared=no' '--with-pic' '--cache-file=/dev/null' '--srcdir=../../../3rdparty/libprocess' CXXFLAGS='-g1 -O0 -Wno-unused-local-typedefs -std=c++11' --enable-shared=no --with-pic --srcdir=. && \
make
checking whether to enable maintainer-specific portions of Makefiles... yes
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... checking build system type... checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... checking whether to enable maintainer-specific portions of Makefiles... no
checking for gcc... gcc
yes
checking for gcc... gcc
yes
checking whether the C compiler works... checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether the C compiler works... checking for gcc... gcc
yes
checking for C compiler default output file name... a.out
checking for suffix of executables... checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
yes
checking for C compiler default output file name... a.out
checking whether we are cross compiling... checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... o
checking whether we are using the GNU C compiler... yes
checking for gcc option to accept ISO C89... yes
checking whether gcc accepts -g... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... yes
checking for gcc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking build system type... gcc3
checking how to run the C preprocessor... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... gcc3
checking for g++... g++
printf
checking for a sed that does not truncate output... /bin/sed
gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... checking whether we are using the GNU C++ compiler... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... checking for g++... g++
yes
checking whether g++ accepts -g... checking whether we are using the GNU C++ compiler... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 3458764513820540925
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... yes
checking dependency style of g++... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... gcc3
checking how to run the C++ preprocessor... gcc3
g++ -E
checking build system type... checking for grep that handles long lines and -e... ok
/bin/grep
checking for egrep... checking for sysroot... no
/bin/grep -E
checking for ANSI C header files... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... checking for mt... /bin/grep -F
mt
checking if mt is a manifest tool... checking for ld used by gcc... no
/usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... checking how to run the C preprocessor... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... gcc -E
BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 3458764513820540925
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... checking for ANSI C header files... @
checking for strip... yes
strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... checking for sys/types.h... yes
checking for sys/stat.h... ok
checking for sysroot... no
yes
checking for sys/types.h... yes
checking for stdlib.h... checking for mt... mt
checking if mt is a manifest tool... no
checking for ANSI C header files... yes
checking for sys/stat.h... yes
checking for string.h... no
checking for sys/types.h... yes
checking for stdlib.h... yes
yes
checking for sys/stat.h... checking for memory.h... yes
checking for string.h... yes
checking for stdlib.h... yes
checking for strings.h... yes
checking for memory.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for strings.h... yes
checking for memory.h... yes
checking for stdint.h... yes
checking for inttypes.h... yes
checking for strings.h... yes
checking for unistd.h... yes
checking for stdint.h... yes
checking for inttypes.h... yes
checking minix/config.h usability... yes
checking for unistd.h... yes
checking for stdint.h... yes
checking for dlfcn.h... yes
checking for unistd.h... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
yes
checking for objdir... checking for dlfcn.h... .libs
yes
checking C++ compiler flags...... use user-supplied: -g1 -O0 -Wno-unused-local-typedefs -std=c++11
checking whether __SUNPRO_CC is declared... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
no
checking for gcc option to produce PIC... checking if the linker (/usr/bin/ld) is GNU ld... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... checking if gcc supports -fno-rtti -fno-exceptions... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... yes
checking if gcc static flag -static works... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 3458764513820540925
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking if gcc supports -c -o file.o... yes
checking dynamic linker characteristics... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... ok
checking for sysroot... no
GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... no
checking whether to build static libraries... yes
checking sys/inotify.h usability... checking for mt... mt
checking if mt is a manifest tool... no
checking for dlfcn.h... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... no
checking whether to build static libraries... yes
yes
checking sys/inotify.h presence... checking how to run the C++ preprocessor... yes
checking for sys/inotify.h... yes
yes
checking for objdir... .libs
checking sys/epoll.h usability... g++ -E
yes
checking sys/epoll.h presence... yes
checking for sys/epoll.h... yes
checking sys/event.h usability... checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
yes
checking if gcc static flag -static works... checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
yes
checking if gcc supports -c -o file.o... no
checking sys/event.h presence... no
checking for sys/event.h... no
checking port.h usability... checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... yes
checking if g++ static flag -static works... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... no
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking for ANSI C header files... (cached) no
checking for stdint.h... (cached) yes
checking for sys/types.h... (cached) yes
checking for inttypes.h... (cached) yes
checking for unistd.h... (cached) yes
no
checking port.h presence... checking syscall.h usability... no
checking for port.h... no
checking poll.h usability... checking for ld used by g++... /usr/bin/ld -m elf_x86_64
yes
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... checking syscall.h presence... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
yes
checking for syscall.h... yes
checking sys/syscall.h usability... yes
checking poll.h presence... yes
checking for poll.h... yes
checking sys/select.h usability... yes
checking sys/syscall.h presence... yes
checking for sys/syscall.h... yes
checking execinfo.h usability... checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking sys/select.h presence... yes
checking for sys/select.h... yes
checking sys/eventfd.h usability... yes
checking execinfo.h presence... yes
checking for execinfo.h... yes
checking libunwind.h usability... yes
checking if g++ static flag -static works... yes
checking sys/eventfd.h presence... yes
checking for sys/eventfd.h... yes
checking sys/signalfd.h usability... yes
checking if g++ supports -c -o file.o... no
checking libunwind.h presence... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking for ANSI C header files... (cached) yes
checking fcntl.h usability... yes
checking sys/signalfd.h presence... no
checking for libunwind.h... no
checking ucontext.h usability... yes
checking for sys/signalfd.h... yes
checking for inotify_init... yes
checking fcntl.h presence... yes
checking ucontext.h presence... yes
yes
checking for fcntl.h... yes
checking for epoll_ctl... yes
checking for ucontext.h... yes
checking for inttypes.h... (cached) yes
checking sys/utsname.h usability... checking limits.h usability... yes
checking for kqueue... yes
checking sys/utsname.h presence... yes
checking limits.h presence... yes
checking for sys/utsname.h... yes
yes
checking pwd.h usability... checking for limits.h... yes
checking for stdlib.h... (cached) yes
checking for unistd.h... (cached) yes
checking for working memcmp... no
checking for port_create... yes
checking pwd.h presence... yes
checking for pwd.h... yes
checking syslog.h usability... yes
checking for working strtod... yes
checking syslog.h presence... no
yes
checking for syslog.h... yes
checking sys/time.h usability... checking for poll... yes
yes
checking for ftruncate... checking for select... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking glob.h usability... yes
yes
checking for eventfd... checking for memset... yes
checking glob.h presence... yes
checking for glob.h... yes
checking unwind.h usability... yes
checking for signalfd... yes
checking for mkdir... yes
checking unwind.h presence... yes
checking for unwind.h... yes
checking size of void *... yes
checking for clock_gettime... yes
checking for strchr... yes
checking for nanosleep... 8
checking for uint16_t... yes
checking for strerror... yes
checking for library containing floor... yes
checking for strtol... yes
checking for u_int16_t... yes
checking zlib version... -lm
ok (1.2.0.4 or later)
checking for library containing zlibVersion... configure: creating ./config.status
yes
checking for __uint16... no
checking for sigaltstack... -lz
checking for the pthreads library -lpthreads... yes
checking for dladdr... no
checking whether pthreads work without any flags... no
checking for fcntl... no
checking whether pthreads work with -Kthread... yes
checking for __attribute__... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... yes
checking for __builtin_expect... yes
checking for __sync_val_compare_and_swap... no
checking whether pthreads work with -pthread... yes
checking for the pthreads library -lpthreads... yes
checking for joinable pthread attribute... config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands
no
checking whether pthreads work without any flags... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking whether to check for GCC pthread/shared inconsistencies... config.status: executing libtool commands
yes
checking whether -pthread is sufficient with -shared... no
checking whether pthreads work with -Kthread... yes
checking whether what we have so far is sufficient with -nostdlib... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether -lpthread saves the day... no
checking whether pthreads work with -pthread... make[8]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/libev-4.15'
make all-am
make[9]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/libev-4.15'
/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -g -O3 -MT ev.lo -MD -MP -MF .deps/ev.Tpo -c -o ev.lo ev.c
yes
yes
checking the location of hash_map... checking for joinable pthread attribute... libtool: compile: gcc -DHAVE_CONFIG_H -I. -g -O3 -MT ev.lo -MD -MP -MF .deps/ev.Tpo -c ev.c -fPIC -DPIC -o ev.o
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern' [enabled by default]
EV_API_DECL struct ev_loop *ev_default_loop_ptr = 0; /* needs to be initialised to make it a definition despite extern */
^
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
write (evpipe [1], &counter, sizeof (uint64_t));
^
ev.c:2172:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
write (evpipe [1], &(evpipe [1]), 1);
^
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
read (evpipe [1], &counter, sizeof (uint64_t));
^
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
read (evpipe [0], &dummy, sizeof (dummy));
^
PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking whether to check for GCC pthread/shared inconsistencies... yes
checking whether -pthread is sufficient with -shared... <unordered_map>
configure: creating ./config.status
yes
checking for pthread_self in -lpthread... yes
checking for main in -lgflags... no
checking for gtest-config... no
checking support for pthread_rwlock_* functions... yes
checking whether the compiler implements namespaces... yes
checking what namespace STL code is in... std
checking whether compiler supports using ::operator<<... config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating protobuf.pc
config.status: creating protobuf-lite.pc
config.status: creating config.h
config.status: executing depfiles commands
1
checking for ucontext.h... (cached) yes
checking sys/ucontext.h usability... yes
checking sys/ucontext.h presence... yes
checking for sys/ucontext.h... yes
checking how to access the program counter from a struct ucontext... uc_mcontext.gregs[REG_RIP]
mv -f .deps/ev.Tpo .deps/ev.Plo
/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -g -O3 -MT event.lo -MD -MP -MF .deps/event.Tpo -c -o event.lo event.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -g -O3 -MT event.lo -MD -MP -MF .deps/event.Tpo -c event.c -fPIC -DPIC -o event.o
config.status: executing libtool commands
configure: creating ./config.status
mv -f .deps/event.Tpo .deps/event.Plo
/bin/bash ./libtool --tag=CC --mode=link gcc -g -O3 -version-info 4:0:0 -o libev.la -rpath /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_inst/lib ev.lo event.lo -lm
=== configuring in gtest (/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0/gtest)
configure: running /bin/bash ./configure --disable-option-checking '--prefix=/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_inst' '--disable-python-dependency-install' 'JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64' 'CXXFLAGS=-g1 -O0 -Wno-unused-local-typedefs -std=c++11' '--enable-shared=no' '--with-pic' --cache-file=/dev/null --srcdir=.
libtool: link: ar cru .libs/libev.a ev.o event.o
libtool: link: ranlib .libs/libev.a
libtool: link: ( cd ".libs" && rm -f "libev.la" && ln -s "../libev.la" "libev.la" )
make[9]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/libev-4.15'
make[8]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/libev-4.15'
/bin/bash ../libtool --tag=CC --mode=link gcc -g1 -O0 -Wno-unused-local-typedefs -o libry_http_parser.la libry_http_parser_la-http_parser.lo -ldl -lz -lcurl -lsvn_delta-1 -lsvn_subr-1 -lapr-1 -lrt
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... libtool: link: ar cru .libs/libry_http_parser.a libry_http_parser_la-http_parser.o
libtool: link: ranlib .libs/libry_http_parser.a
libtool: link: ( cd ".libs" && rm -f "libry_http_parser.la" && ln -s "../libry_http_parser.la" "libry_http_parser.la" )
config.status: creating Makefile
config.status: creating src/glog/logging.h
config.status: creating src/glog/raw_logging.h
config.status: creating src/glog/vlog_is_on.h
config.status: creating src/glog/stl_logging.h
config.status: creating libglog.pc
config.status: creating src/config.h
config.status: executing depfiles commands
config.status: executing libtool commands
make[8]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/glog-0.3.3'
/bin/bash ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-logging.lo -MD -MP -MF .deps/libglog_la-logging.Tpo -c -o libglog_la-logging.lo `test -f 'src/logging.cc' || echo './'`src/logging.cc
/bin/bash ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-raw_logging.lo -MD -MP -MF .deps/libglog_la-raw_logging.Tpo -c -o libglog_la-raw_logging.lo `test -f 'src/raw_logging.cc' || echo './'`src/raw_logging.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-raw_logging.lo -MD -MP -MF .deps/libglog_la-raw_logging.Tpo -c src/raw_logging.cc -fPIC -DPIC -o libglog_la-raw_logging.o
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-logging.lo -MD -MP -MF .deps/libglog_la-logging.Tpo -c src/logging.cc -fPIC -DPIC -o libglog_la-logging.o
yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... mv -f .deps/libglog_la-raw_logging.Tpo .deps/libglog_la-raw_logging.Plo
/bin/bash ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-vlog_is_on.lo -MD -MP -MF .deps/libglog_la-vlog_is_on.Tpo -c -o libglog_la-vlog_is_on.lo `test -f 'src/vlog_is_on.cc' || echo './'`src/vlog_is_on.cc
gcc3
checking for g++... g++
checking whether we are using the GNU C++ compiler... libtool: compile: g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-vlog_is_on.lo -MD -MP -MF .deps/libglog_la-vlog_is_on.Tpo -c src/vlog_is_on.cc -fPIC -DPIC -o libglog_la-vlog_is_on.o
yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 3458764513820540925
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... mv -f .deps/libglog_la-vlog_is_on.Tpo .deps/libglog_la-vlog_is_on.Plo
/bin/bash ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-utilities.lo -MD -MP -MF .deps/libglog_la-utilities.Tpo -c -o libglog_la-utilities.lo `test -f 'src/utilities.cc' || echo './'`src/utilities.cc
ok
checking for sysroot... no
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-utilities.lo -MD -MP -MF .deps/libglog_la-utilities.Tpo -c src/utilities.cc -fPIC -DPIC -o libglog_la-utilities.o
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
mv -f .deps/libglog_la-logging.Tpo .deps/libglog_la-logging.Plo
/bin/bash ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-demangle.lo -MD -MP -MF .deps/libglog_la-demangle.Tpo -c -o libglog_la-demangle.lo `test -f 'src/demangle.cc' || echo './'`src/demangle.cc
checking for ANSI C header files... libtool: compile: g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-demangle.lo -MD -MP -MF .deps/libglog_la-demangle.Tpo -c src/demangle.cc -fPIC -DPIC -o libglog_la-demangle.o
yes
checking for sys/types.h... mv -f .deps/libglog_la-demangle.Tpo .deps/libglog_la-demangle.Plo
/bin/bash ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-symbolize.lo -MD -MP -MF .deps/libglog_la-symbolize.Tpo -c -o libglog_la-symbolize.lo `test -f 'src/symbolize.cc' || echo './'`src/symbolize.cc
yes
checking for sys/stat.h... libtool: compile: g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-symbolize.lo -MD -MP -MF .deps/libglog_la-symbolize.Tpo -c src/symbolize.cc -fPIC -DPIC -o libglog_la-symbolize.o
yes
checking for stdlib.h... yes
checking for string.h... mv -f .deps/libglog_la-utilities.Tpo .deps/libglog_la-utilities.Plo
/bin/bash ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-signalhandler.lo -MD -MP -MF .deps/libglog_la-signalhandler.Tpo -c -o libglog_la-signalhandler.lo `test -f 'src/signalhandler.cc' || echo './'`src/signalhandler.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libglog_la-signalhandler.lo -MD -MP -MF .deps/libglog_la-signalhandler.Tpo -c src/signalhandler.cc -fPIC -DPIC -o libglog_la-signalhandler.o
yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
mv -f .deps/libglog_la-symbolize.Tpo .deps/libglog_la-symbolize.Plo
g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT logging_unittest-logging_unittest.o -MD -MP -MF .deps/logging_unittest-logging_unittest.Tpo -c -o logging_unittest-logging_unittest.o `test -f 'src/logging_unittest.cc' || echo './'`src/logging_unittest.cc
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... no
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
mv -f .deps/libglog_la-signalhandler.Tpo .deps/libglog_la-signalhandler.Plo
g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT demangle_unittest-demangle_unittest.o -MD -MP -MF .deps/demangle_unittest-demangle_unittest.Tpo -c -o demangle_unittest-demangle_unittest.o `test -f 'src/demangle_unittest.cc' || echo './'`src/demangle_unittest.cc
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking for python... /usr/bin/python
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... mv -f .deps/demangle_unittest-demangle_unittest.Tpo .deps/demangle_unittest-demangle_unittest.Po
g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT stacktrace_unittest-stacktrace_unittest.o -MD -MP -MF .deps/stacktrace_unittest-stacktrace_unittest.Tpo -c -o stacktrace_unittest-stacktrace_unittest.o `test -f 'src/stacktrace_unittest.cc' || echo './'`src/stacktrace_unittest.cc
no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... mv -f .deps/logging_unittest-logging_unittest.Tpo .deps/logging_unittest-logging_unittest.Po
g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT symbolize_unittest-symbolize_unittest.o -MD -MP -MF .deps/symbolize_unittest-symbolize_unittest.Tpo -c -o symbolize_unittest-symbolize_unittest.o `test -f 'src/symbolize_unittest.cc' || echo './'`src/symbolize_unittest.cc
no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... mv -f .deps/stacktrace_unittest-stacktrace_unittest.Tpo .deps/stacktrace_unittest-stacktrace_unittest.Po
g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT stl_logging_unittest-stl_logging_unittest.o -MD -MP -MF .deps/stl_logging_unittest-stl_logging_unittest.Tpo -c -o stl_logging_unittest-stl_logging_unittest.o `test -f 'src/stl_logging_unittest.cc' || echo './'`src/stl_logging_unittest.cc
yes
checking for joinable pthread attribute... In file included from /usr/include/c++/4.8/ext/hash_set:60:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.8/backward/backward_warning.h:32:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp]
#warning \
^
PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking whether to check for GCC pthread/shared inconsistencies... In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
# define _XOPEN_SOURCE 500 // may be needed to get the rwlock calls
^
In file included from /usr/include/x86_64-linux-gnu/c++/4.8/bits/os_defines.h:39:0,
from /usr/include/x86_64-linux-gnu/c++/4.8/bits/c++config.h:426,
from /usr/include/c++/4.8/bits/stl_algobase.h:59,
from /usr/include/c++/4.8/deque:60,
from src/glog/stl_logging.h:45,
from src/stl_logging_unittest.cc:34:
/usr/include/features.h:162:0: note: this is the location of the previous definition
# define _XOPEN_SOURCE 700
^
yes
checking whether -pthread is sufficient with -shared... yes
configure: creating ./config.status
mv -f .deps/symbolize_unittest-symbolize_unittest.Tpo .deps/symbolize_unittest-symbolize_unittest.Po
g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT utilities_unittest-utilities_unittest.o -MD -MP -MF .deps/utilities_unittest-utilities_unittest.Tpo -c -o utilities_unittest-utilities_unittest.o `test -f 'src/utilities_unittest.cc' || echo './'`src/utilities_unittest.cc
config.status: creating Makefile
config.status: creating scripts/gtest-config
config.status: creating build-aux/config.h
config.status: executing depfiles commands
config.status: executing libtool commands
mv -f .deps/utilities_unittest-utilities_unittest.Tpo .deps/utilities_unittest-utilities_unittest.Po
g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT logging_striptest0-logging_striptest_main.o -MD -MP -MF .deps/logging_striptest0-logging_striptest_main.Tpo -c -o logging_striptest0-logging_striptest_main.o `test -f 'src/logging_striptest_main.cc' || echo './'`src/logging_striptest_main.cc
make[8]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0'
make all-recursive
make[9]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0'
Making all in .
make[10]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0'
make[10]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0'
Making all in src
make[10]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0/src'
g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT main.o -MD -MP -MF .deps/main.Tpo -c -o main.o `test -f 'google/protobuf/compiler/main.cc' || echo './'`google/protobuf/compiler/main.cc
src/logging_striptest_main.cc: In function 'int CheckNoReturn(bool)':
src/logging_striptest_main.cc:54:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
mv -f .deps/logging_striptest0-logging_striptest_main.Tpo .deps/logging_striptest0-logging_striptest_main.Po
g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT logging_striptest2-logging_striptest2.o -MD -MP -MF .deps/logging_striptest2-logging_striptest2.Tpo -c -o logging_striptest2-logging_striptest2.o `test -f 'src/logging_striptest2.cc' || echo './'`src/logging_striptest2.cc
mv -f .deps/main.Tpo .deps/main.Po
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT atomicops_internals_x86_gcc.lo -MD -MP -MF .deps/atomicops_internals_x86_gcc.Tpo -c -o atomicops_internals_x86_gcc.lo `test -f 'google/protobuf/stubs/atomicops_internals_x86_gcc.cc' || echo './'`google/protobuf/stubs/atomicops_internals_x86_gcc.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT atomicops_internals_x86_gcc.lo -MD -MP -MF .deps/atomicops_internals_x86_gcc.Tpo -c google/protobuf/stubs/atomicops_internals_x86_gcc.cc -fPIC -DPIC -o atomicops_internals_x86_gcc.o
mv -f .deps/stl_logging_unittest-stl_logging_unittest.Tpo .deps/stl_logging_unittest-stl_logging_unittest.Po
g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT logging_striptest10-logging_striptest10.o -MD -MP -MF .deps/logging_striptest10-logging_striptest10.Tpo -c -o logging_striptest10-logging_striptest10.o `test -f 'src/logging_striptest10.cc' || echo './'`src/logging_striptest10.cc
In file included from src/logging_striptest2.cc:35:0:
src/logging_striptest_main.cc: In function 'int CheckNoReturn(bool)':
src/logging_striptest_main.cc:54:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
mv -f .deps/logging_striptest2-logging_striptest2.Tpo .deps/logging_striptest2-logging_striptest2.Po
g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT signalhandler_unittest-signalhandler_unittest.o -MD -MP -MF .deps/signalhandler_unittest-signalhandler_unittest.Tpo -c -o signalhandler_unittest-signalhandler_unittest.o `test -f 'src/signalhandler_unittest.cc' || echo './'`src/signalhandler_unittest.cc
mv -f .deps/atomicops_internals_x86_gcc.Tpo .deps/atomicops_internals_x86_gcc.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT atomicops_internals_x86_msvc.lo -MD -MP -MF .deps/atomicops_internals_x86_msvc.Tpo -c -o atomicops_internals_x86_msvc.lo `test -f 'google/protobuf/stubs/atomicops_internals_x86_msvc.cc' || echo './'`google/protobuf/stubs/atomicops_internals_x86_msvc.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT atomicops_internals_x86_msvc.lo -MD -MP -MF .deps/atomicops_internals_x86_msvc.Tpo -c google/protobuf/stubs/atomicops_internals_x86_msvc.cc -fPIC -DPIC -o atomicops_internals_x86_msvc.o
In file included from src/logging_striptest10.cc:35:0:
src/logging_striptest_main.cc: In function 'int CheckNoReturn(bool)':
src/logging_striptest_main.cc:54:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
mv -f .deps/logging_striptest10-logging_striptest10.Tpo .deps/logging_striptest10-logging_striptest10.Po
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT common.lo -MD -MP -MF .deps/common.Tpo -c -o common.lo `test -f 'google/protobuf/stubs/common.cc' || echo './'`google/protobuf/stubs/common.cc
mv -f .deps/atomicops_internals_x86_msvc.Tpo .deps/atomicops_internals_x86_msvc.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT once.lo -MD -MP -MF .deps/once.Tpo -c -o once.lo `test -f 'google/protobuf/stubs/once.cc' || echo './'`google/protobuf/stubs/once.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT common.lo -MD -MP -MF .deps/common.Tpo -c google/protobuf/stubs/common.cc -fPIC -DPIC -o common.o
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT once.lo -MD -MP -MF .deps/once.Tpo -c google/protobuf/stubs/once.cc -fPIC -DPIC -o once.o
mv -f .deps/signalhandler_unittest-signalhandler_unittest.Tpo .deps/signalhandler_unittest-signalhandler_unittest.Po
/bin/bash ./libtool --tag=CXX --mode=link g++ -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -o libglog.la -rpath /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_inst/lib libglog_la-logging.lo libglog_la-raw_logging.lo libglog_la-vlog_is_on.lo libglog_la-utilities.lo libglog_la-demangle.lo libglog_la-symbolize.lo libglog_la-signalhandler.lo -lpthread
libtool: link: ar cru .libs/libglog.a libglog_la-logging.o libglog_la-raw_logging.o libglog_la-vlog_is_on.o libglog_la-utilities.o libglog_la-demangle.o libglog_la-symbolize.o libglog_la-signalhandler.o
libtool: link: ranlib .libs/libglog.a
libtool: link: ( cd ".libs" && rm -f "libglog.la" && ln -s "../libglog.la" "libglog.la" )
/bin/bash ./libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o logging_unittest logging_unittest-logging_unittest.o libglog.la -lpthread
mv -f .deps/once.Tpo .deps/once.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT stringprintf.lo -MD -MP -MF .deps/stringprintf.Tpo -c -o stringprintf.lo `test -f 'google/protobuf/stubs/stringprintf.cc' || echo './'`google/protobuf/stubs/stringprintf.cc
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o logging_unittest logging_unittest-logging_unittest.o ./.libs/libglog.a -lpthread -pthread
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT stringprintf.lo -MD -MP -MF .deps/stringprintf.Tpo -c google/protobuf/stubs/stringprintf.cc -fPIC -DPIC -o stringprintf.o
/bin/bash ./libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o demangle_unittest demangle_unittest-demangle_unittest.o libglog.la -lpthread
mv -f .deps/common.Tpo .deps/common.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT extension_set.lo -MD -MP -MF .deps/extension_set.Tpo -c -o extension_set.lo `test -f 'google/protobuf/extension_set.cc' || echo './'`google/protobuf/extension_set.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT extension_set.lo -MD -MP -MF .deps/extension_set.Tpo -c google/protobuf/extension_set.cc -fPIC -DPIC -o extension_set.o
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o demangle_unittest demangle_unittest-demangle_unittest.o ./.libs/libglog.a -lpthread -pthread
/bin/bash ./libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o stacktrace_unittest stacktrace_unittest-stacktrace_unittest.o libglog.la -lpthread
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o stacktrace_unittest stacktrace_unittest-stacktrace_unittest.o ./.libs/libglog.a -lpthread -pthread
mv -f .deps/stringprintf.Tpo .deps/stringprintf.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT generated_message_util.lo -MD -MP -MF .deps/generated_message_util.Tpo -c -o generated_message_util.lo `test -f 'google/protobuf/generated_message_util.cc' || echo './'`google/protobuf/generated_message_util.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT generated_message_util.lo -MD -MP -MF .deps/generated_message_util.Tpo -c google/protobuf/generated_message_util.cc -fPIC -DPIC -o generated_message_util.o
/bin/bash ./libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o symbolize_unittest symbolize_unittest-symbolize_unittest.o libglog.la -lpthread
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o symbolize_unittest symbolize_unittest-symbolize_unittest.o ./.libs/libglog.a -lpthread -pthread
/bin/bash ./libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o stl_logging_unittest stl_logging_unittest-stl_logging_unittest.o libglog.la -lpthread
mv -f .deps/generated_message_util.Tpo .deps/generated_message_util.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT message_lite.lo -MD -MP -MF .deps/message_lite.Tpo -c -o message_lite.lo `test -f 'google/protobuf/message_lite.cc' || echo './'`google/protobuf/message_lite.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT message_lite.lo -MD -MP -MF .deps/message_lite.Tpo -c google/protobuf/message_lite.cc -fPIC -DPIC -o message_lite.o
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o stl_logging_unittest stl_logging_unittest-stl_logging_unittest.o ./.libs/libglog.a -lpthread -pthread
/bin/bash ./libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o utilities_unittest utilities_unittest-utilities_unittest.o libglog.la -lpthread
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o utilities_unittest utilities_unittest-utilities_unittest.o ./.libs/libglog.a -lpthread -pthread
/bin/bash ./libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o logging_striptest0 logging_striptest0-logging_striptest_main.o libglog.la -lpthread
mv -f .deps/message_lite.Tpo .deps/message_lite.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT repeated_field.lo -MD -MP -MF .deps/repeated_field.Tpo -c -o repeated_field.lo `test -f 'google/protobuf/repeated_field.cc' || echo './'`google/protobuf/repeated_field.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT repeated_field.lo -MD -MP -MF .deps/repeated_field.Tpo -c google/protobuf/repeated_field.cc -fPIC -DPIC -o repeated_field.o
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o logging_striptest0 logging_striptest0-logging_striptest_main.o ./.libs/libglog.a -lpthread -pthread
/bin/bash ./libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o logging_striptest2 logging_striptest2-logging_striptest2.o libglog.la -lpthread
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o logging_striptest2 logging_striptest2-logging_striptest2.o ./.libs/libglog.a -lpthread -pthread
/bin/bash ./libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o logging_striptest10 logging_striptest10-logging_striptest10.o libglog.la -lpthread
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o logging_striptest10 logging_striptest10-logging_striptest10.o ./.libs/libglog.a -lpthread -pthread
/bin/bash ./libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o signalhandler_unittest signalhandler_unittest-signalhandler_unittest.o libglog.la -lpthread
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o signalhandler_unittest signalhandler_unittest-signalhandler_unittest.o ./.libs/libglog.a -lpthread -pthread
make[8]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/glog-0.3.3'
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT wire_format_lite.lo -MD -MP -MF .deps/wire_format_lite.Tpo -c -o wire_format_lite.lo `test -f 'google/protobuf/wire_format_lite.cc' || echo './'`google/protobuf/wire_format_lite.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT wire_format_lite.lo -MD -MP -MF .deps/wire_format_lite.Tpo -c google/protobuf/wire_format_lite.cc -fPIC -DPIC -o wire_format_lite.o
mv -f .deps/repeated_field.Tpo .deps/repeated_field.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT coded_stream.lo -MD -MP -MF .deps/coded_stream.Tpo -c -o coded_stream.lo `test -f 'google/protobuf/io/coded_stream.cc' || echo './'`google/protobuf/io/coded_stream.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT coded_stream.lo -MD -MP -MF .deps/coded_stream.Tpo -c google/protobuf/io/coded_stream.cc -fPIC -DPIC -o coded_stream.o
mv -f .deps/extension_set.Tpo .deps/extension_set.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT zero_copy_stream.lo -MD -MP -MF .deps/zero_copy_stream.Tpo -c -o zero_copy_stream.lo `test -f 'google/protobuf/io/zero_copy_stream.cc' || echo './'`google/protobuf/io/zero_copy_stream.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT zero_copy_stream.lo -MD -MP -MF .deps/zero_copy_stream.Tpo -c google/protobuf/io/zero_copy_stream.cc -fPIC -DPIC -o zero_copy_stream.o
mv -f .deps/zero_copy_stream.Tpo .deps/zero_copy_stream.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT zero_copy_stream_impl_lite.lo -MD -MP -MF .deps/zero_copy_stream_impl_lite.Tpo -c -o zero_copy_stream_impl_lite.lo `test -f 'google/protobuf/io/zero_copy_stream_impl_lite.cc' || echo './'`google/protobuf/io/zero_copy_stream_impl_lite.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT zero_copy_stream_impl_lite.lo -MD -MP -MF .deps/zero_copy_stream_impl_lite.Tpo -c google/protobuf/io/zero_copy_stream_impl_lite.cc -fPIC -DPIC -o zero_copy_stream_impl_lite.o
mv -f .deps/wire_format_lite.Tpo .deps/wire_format_lite.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT strutil.lo -MD -MP -MF .deps/strutil.Tpo -c -o strutil.lo `test -f 'google/protobuf/stubs/strutil.cc' || echo './'`google/protobuf/stubs/strutil.cc
mv -f .deps/coded_stream.Tpo .deps/coded_stream.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT substitute.lo -MD -MP -MF .deps/substitute.Tpo -c -o substitute.lo `test -f 'google/protobuf/stubs/substitute.cc' || echo './'`google/protobuf/stubs/substitute.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT strutil.lo -MD -MP -MF .deps/strutil.Tpo -c google/protobuf/stubs/strutil.cc -fPIC -DPIC -o strutil.o
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT substitute.lo -MD -MP -MF .deps/substitute.Tpo -c google/protobuf/stubs/substitute.cc -fPIC -DPIC -o substitute.o
mv -f .deps/zero_copy_stream_impl_lite.Tpo .deps/zero_copy_stream_impl_lite.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT structurally_valid.lo -MD -MP -MF .deps/structurally_valid.Tpo -c -o structurally_valid.lo `test -f 'google/protobuf/stubs/structurally_valid.cc' || echo './'`google/protobuf/stubs/structurally_valid.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT structurally_valid.lo -MD -MP -MF .deps/structurally_valid.Tpo -c google/protobuf/stubs/structurally_valid.cc -fPIC -DPIC -o structurally_valid.o
mv -f .deps/substitute.Tpo .deps/substitute.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT descriptor.lo -MD -MP -MF .deps/descriptor.Tpo -c -o descriptor.lo `test -f 'google/protobuf/descriptor.cc' || echo './'`google/protobuf/descriptor.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT descriptor.lo -MD -MP -MF .deps/descriptor.Tpo -c google/protobuf/descriptor.cc -fPIC -DPIC -o descriptor.o
mv -f .deps/structurally_valid.Tpo .deps/structurally_valid.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT descriptor.pb.lo -MD -MP -MF .deps/descriptor.pb.Tpo -c -o descriptor.pb.lo `test -f 'google/protobuf/descriptor.pb.cc' || echo './'`google/protobuf/descriptor.pb.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT descriptor.pb.lo -MD -MP -MF .deps/descriptor.pb.Tpo -c google/protobuf/descriptor.pb.cc -fPIC -DPIC -o descriptor.pb.o
mv -f .deps/strutil.Tpo .deps/strutil.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT descriptor_database.lo -MD -MP -MF .deps/descriptor_database.Tpo -c -o descriptor_database.lo `test -f 'google/protobuf/descriptor_database.cc' || echo './'`google/protobuf/descriptor_database.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT descriptor_database.lo -MD -MP -MF .deps/descriptor_database.Tpo -c google/protobuf/descriptor_database.cc -fPIC -DPIC -o descriptor_database.o
mv -f .deps/descriptor_database.Tpo .deps/descriptor_database.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT dynamic_message.lo -MD -MP -MF .deps/dynamic_message.Tpo -c -o dynamic_message.lo `test -f 'google/protobuf/dynamic_message.cc' || echo './'`google/protobuf/dynamic_message.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT dynamic_message.lo -MD -MP -MF .deps/dynamic_message.Tpo -c google/protobuf/dynamic_message.cc -fPIC -DPIC -o dynamic_message.o
mv -f .deps/descriptor.pb.Tpo .deps/descriptor.pb.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT extension_set_heavy.lo -MD -MP -MF .deps/extension_set_heavy.Tpo -c -o extension_set_heavy.lo `test -f 'google/protobuf/extension_set_heavy.cc' || echo './'`google/protobuf/extension_set_heavy.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT extension_set_heavy.lo -MD -MP -MF .deps/extension_set_heavy.Tpo -c google/protobuf/extension_set_heavy.cc -fPIC -DPIC -o extension_set_heavy.o
mv -f .deps/dynamic_message.Tpo .deps/dynamic_message.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT generated_message_reflection.lo -MD -MP -MF .deps/generated_message_reflection.Tpo -c -o generated_message_reflection.lo `test -f 'google/protobuf/generated_message_reflection.cc' || echo './'`google/protobuf/generated_message_reflection.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT generated_message_reflection.lo -MD -MP -MF .deps/generated_message_reflection.Tpo -c google/protobuf/generated_message_reflection.cc -fPIC -DPIC -o generated_message_reflection.o
mv -f .deps/extension_set_heavy.Tpo .deps/extension_set_heavy.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT message.lo -MD -MP -MF .deps/message.Tpo -c -o message.lo `test -f 'google/protobuf/message.cc' || echo './'`google/protobuf/message.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT message.lo -MD -MP -MF .deps/message.Tpo -c google/protobuf/message.cc -fPIC -DPIC -o message.o
mv -f .deps/descriptor.Tpo .deps/descriptor.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT reflection_ops.lo -MD -MP -MF .deps/reflection_ops.Tpo -c -o reflection_ops.lo `test -f 'google/protobuf/reflection_ops.cc' || echo './'`google/protobuf/reflection_ops.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT reflection_ops.lo -MD -MP -MF .deps/reflection_ops.Tpo -c google/protobuf/reflection_ops.cc -fPIC -DPIC -o reflection_ops.o
mv -f .deps/generated_message_reflection.Tpo .deps/generated_message_reflection.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT service.lo -MD -MP -MF .deps/service.Tpo -c -o service.lo `test -f 'google/protobuf/service.cc' || echo './'`google/protobuf/service.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT service.lo -MD -MP -MF .deps/service.Tpo -c google/protobuf/service.cc -fPIC -DPIC -o service.o
mv -f .deps/service.Tpo .deps/service.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT text_format.lo -MD -MP -MF .deps/text_format.Tpo -c -o text_format.lo `test -f 'google/protobuf/text_format.cc' || echo './'`google/protobuf/text_format.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT text_format.lo -MD -MP -MF .deps/text_format.Tpo -c google/protobuf/text_format.cc -fPIC -DPIC -o text_format.o
mv -f .deps/reflection_ops.Tpo .deps/reflection_ops.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT unknown_field_set.lo -MD -MP -MF .deps/unknown_field_set.Tpo -c -o unknown_field_set.lo `test -f 'google/protobuf/unknown_field_set.cc' || echo './'`google/protobuf/unknown_field_set.cc
mv -f .deps/message.Tpo .deps/message.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT wire_format.lo -MD -MP -MF .deps/wire_format.Tpo -c -o wire_format.lo `test -f 'google/protobuf/wire_format.cc' || echo './'`google/protobuf/wire_format.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT unknown_field_set.lo -MD -MP -MF .deps/unknown_field_set.Tpo -c google/protobuf/unknown_field_set.cc -fPIC -DPIC -o unknown_field_set.o
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT wire_format.lo -MD -MP -MF .deps/wire_format.Tpo -c google/protobuf/wire_format.cc -fPIC -DPIC -o wire_format.o
mv -f .deps/unknown_field_set.Tpo .deps/unknown_field_set.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT gzip_stream.lo -MD -MP -MF .deps/gzip_stream.Tpo -c -o gzip_stream.lo `test -f 'google/protobuf/io/gzip_stream.cc' || echo './'`google/protobuf/io/gzip_stream.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT gzip_stream.lo -MD -MP -MF .deps/gzip_stream.Tpo -c google/protobuf/io/gzip_stream.cc -fPIC -DPIC -o gzip_stream.o
mv -f .deps/wire_format.Tpo .deps/wire_format.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT printer.lo -MD -MP -MF .deps/printer.Tpo -c -o printer.lo `test -f 'google/protobuf/io/printer.cc' || echo './'`google/protobuf/io/printer.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT printer.lo -MD -MP -MF .deps/printer.Tpo -c google/protobuf/io/printer.cc -fPIC -DPIC -o printer.o
mv -f .deps/text_format.Tpo .deps/text_format.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT tokenizer.lo -MD -MP -MF .deps/tokenizer.Tpo -c -o tokenizer.lo `test -f 'google/protobuf/io/tokenizer.cc' || echo './'`google/protobuf/io/tokenizer.cc
mv -f .deps/gzip_stream.Tpo .deps/gzip_stream.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT zero_copy_stream_impl.lo -MD -MP -MF .deps/zero_copy_stream_impl.Tpo -c -o zero_copy_stream_impl.lo `test -f 'google/protobuf/io/zero_copy_stream_impl.cc' || echo './'`google/protobuf/io/zero_copy_stream_impl.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT tokenizer.lo -MD -MP -MF .deps/tokenizer.Tpo -c google/protobuf/io/tokenizer.cc -fPIC -DPIC -o tokenizer.o
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT zero_copy_stream_impl.lo -MD -MP -MF .deps/zero_copy_stream_impl.Tpo -c google/protobuf/io/zero_copy_stream_impl.cc -fPIC -DPIC -o zero_copy_stream_impl.o
mv -f .deps/printer.Tpo .deps/printer.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT importer.lo -MD -MP -MF .deps/importer.Tpo -c -o importer.lo `test -f 'google/protobuf/compiler/importer.cc' || echo './'`google/protobuf/compiler/importer.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT importer.lo -MD -MP -MF .deps/importer.Tpo -c google/protobuf/compiler/importer.cc -fPIC -DPIC -o importer.o
mv -f .deps/tokenizer.Tpo .deps/tokenizer.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT parser.lo -MD -MP -MF .deps/parser.Tpo -c -o parser.lo `test -f 'google/protobuf/compiler/parser.cc' || echo './'`google/protobuf/compiler/parser.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT parser.lo -MD -MP -MF .deps/parser.Tpo -c google/protobuf/compiler/parser.cc -fPIC -DPIC -o parser.o
mv -f .deps/zero_copy_stream_impl.Tpo .deps/zero_copy_stream_impl.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT code_generator.lo -MD -MP -MF .deps/code_generator.Tpo -c -o code_generator.lo `test -f 'google/protobuf/compiler/code_generator.cc' || echo './'`google/protobuf/compiler/code_generator.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT code_generator.lo -MD -MP -MF .deps/code_generator.Tpo -c google/protobuf/compiler/code_generator.cc -fPIC -DPIC -o code_generator.o
mv -f .deps/code_generator.Tpo .deps/code_generator.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT command_line_interface.lo -MD -MP -MF .deps/command_line_interface.Tpo -c -o command_line_interface.lo `test -f 'google/protobuf/compiler/command_line_interface.cc' || echo './'`google/protobuf/compiler/command_line_interface.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT command_line_interface.lo -MD -MP -MF .deps/command_line_interface.Tpo -c google/protobuf/compiler/command_line_interface.cc -fPIC -DPIC -o command_line_interface.o
mv -f .deps/importer.Tpo .deps/importer.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT plugin.lo -MD -MP -MF .deps/plugin.Tpo -c -o plugin.lo `test -f 'google/protobuf/compiler/plugin.cc' || echo './'`google/protobuf/compiler/plugin.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT plugin.lo -MD -MP -MF .deps/plugin.Tpo -c google/protobuf/compiler/plugin.cc -fPIC -DPIC -o plugin.o
mv -f .deps/parser.Tpo .deps/parser.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT plugin.pb.lo -MD -MP -MF .deps/plugin.pb.Tpo -c -o plugin.pb.lo `test -f 'google/protobuf/compiler/plugin.pb.cc' || echo './'`google/protobuf/compiler/plugin.pb.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT plugin.pb.lo -MD -MP -MF .deps/plugin.pb.Tpo -c google/protobuf/compiler/plugin.pb.cc -fPIC -DPIC -o plugin.pb.o
mv -f .deps/plugin.Tpo .deps/plugin.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT subprocess.lo -MD -MP -MF .deps/subprocess.Tpo -c -o subprocess.lo `test -f 'google/protobuf/compiler/subprocess.cc' || echo './'`google/protobuf/compiler/subprocess.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT subprocess.lo -MD -MP -MF .deps/subprocess.Tpo -c google/protobuf/compiler/subprocess.cc -fPIC -DPIC -o subprocess.o
mv -f .deps/subprocess.Tpo .deps/subprocess.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT zip_writer.lo -MD -MP -MF .deps/zip_writer.Tpo -c -o zip_writer.lo `test -f 'google/protobuf/compiler/zip_writer.cc' || echo './'`google/protobuf/compiler/zip_writer.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT zip_writer.lo -MD -MP -MF .deps/zip_writer.Tpo -c google/protobuf/compiler/zip_writer.cc -fPIC -DPIC -o zip_writer.o
mv -f .deps/command_line_interface.Tpo .deps/command_line_interface.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_enum.lo -MD -MP -MF .deps/cpp_enum.Tpo -c -o cpp_enum.lo `test -f 'google/protobuf/compiler/cpp/cpp_enum.cc' || echo './'`google/protobuf/compiler/cpp/cpp_enum.cc
mv -f .deps/plugin.pb.Tpo .deps/plugin.pb.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_enum_field.lo -MD -MP -MF .deps/cpp_enum_field.Tpo -c -o cpp_enum_field.lo `test -f 'google/protobuf/compiler/cpp/cpp_enum_field.cc' || echo './'`google/protobuf/compiler/cpp/cpp_enum_field.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_enum.lo -MD -MP -MF .deps/cpp_enum.Tpo -c google/protobuf/compiler/cpp/cpp_enum.cc -fPIC -DPIC -o cpp_enum.o
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_enum_field.lo -MD -MP -MF .deps/cpp_enum_field.Tpo -c google/protobuf/compiler/cpp/cpp_enum_field.cc -fPIC -DPIC -o cpp_enum_field.o
mv -f .deps/zip_writer.Tpo .deps/zip_writer.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_extension.lo -MD -MP -MF .deps/cpp_extension.Tpo -c -o cpp_extension.lo `test -f 'google/protobuf/compiler/cpp/cpp_extension.cc' || echo './'`google/protobuf/compiler/cpp/cpp_extension.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_extension.lo -MD -MP -MF .deps/cpp_extension.Tpo -c google/protobuf/compiler/cpp/cpp_extension.cc -fPIC -DPIC -o cpp_extension.o
mv -f .deps/cpp_enum_field.Tpo .deps/cpp_enum_field.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_field.lo -MD -MP -MF .deps/cpp_field.Tpo -c -o cpp_field.lo `test -f 'google/protobuf/compiler/cpp/cpp_field.cc' || echo './'`google/protobuf/compiler/cpp/cpp_field.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_field.lo -MD -MP -MF .deps/cpp_field.Tpo -c google/protobuf/compiler/cpp/cpp_field.cc -fPIC -DPIC -o cpp_field.o
mv -f .deps/cpp_enum.Tpo .deps/cpp_enum.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_file.lo -MD -MP -MF .deps/cpp_file.Tpo -c -o cpp_file.lo `test -f 'google/protobuf/compiler/cpp/cpp_file.cc' || echo './'`google/protobuf/compiler/cpp/cpp_file.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_file.lo -MD -MP -MF .deps/cpp_file.Tpo -c google/protobuf/compiler/cpp/cpp_file.cc -fPIC -DPIC -o cpp_file.o
mv -f .deps/cpp_extension.Tpo .deps/cpp_extension.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_generator.lo -MD -MP -MF .deps/cpp_generator.Tpo -c -o cpp_generator.lo `test -f 'google/protobuf/compiler/cpp/cpp_generator.cc' || echo './'`google/protobuf/compiler/cpp/cpp_generator.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_generator.lo -MD -MP -MF .deps/cpp_generator.Tpo -c google/protobuf/compiler/cpp/cpp_generator.cc -fPIC -DPIC -o cpp_generator.o
mv -f .deps/cpp_field.Tpo .deps/cpp_field.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_helpers.lo -MD -MP -MF .deps/cpp_helpers.Tpo -c -o cpp_helpers.lo `test -f 'google/protobuf/compiler/cpp/cpp_helpers.cc' || echo './'`google/protobuf/compiler/cpp/cpp_helpers.cc
mv -f .deps/cpp_file.Tpo .deps/cpp_file.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_message.lo -MD -MP -MF .deps/cpp_message.Tpo -c -o cpp_message.lo `test -f 'google/protobuf/compiler/cpp/cpp_message.cc' || echo './'`google/protobuf/compiler/cpp/cpp_message.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_helpers.lo -MD -MP -MF .deps/cpp_helpers.Tpo -c google/protobuf/compiler/cpp/cpp_helpers.cc -fPIC -DPIC -o cpp_helpers.o
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_message.lo -MD -MP -MF .deps/cpp_message.Tpo -c google/protobuf/compiler/cpp/cpp_message.cc -fPIC -DPIC -o cpp_message.o
mv -f .deps/cpp_generator.Tpo .deps/cpp_generator.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_message_field.lo -MD -MP -MF .deps/cpp_message_field.Tpo -c -o cpp_message_field.lo `test -f 'google/protobuf/compiler/cpp/cpp_message_field.cc' || echo './'`google/protobuf/compiler/cpp/cpp_message_field.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_message_field.lo -MD -MP -MF .deps/cpp_message_field.Tpo -c google/protobuf/compiler/cpp/cpp_message_field.cc -fPIC -DPIC -o cpp_message_field.o
mv -f .deps/cpp_helpers.Tpo .deps/cpp_helpers.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_primitive_field.lo -MD -MP -MF .deps/cpp_primitive_field.Tpo -c -o cpp_primitive_field.lo `test -f 'google/protobuf/compiler/cpp/cpp_primitive_field.cc' || echo './'`google/protobuf/compiler/cpp/cpp_primitive_field.cc
mv -f .deps/cpp_message_field.Tpo .deps/cpp_message_field.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_service.lo -MD -MP -MF .deps/cpp_service.Tpo -c -o cpp_service.lo `test -f 'google/protobuf/compiler/cpp/cpp_service.cc' || echo './'`google/protobuf/compiler/cpp/cpp_service.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_primitive_field.lo -MD -MP -MF .deps/cpp_primitive_field.Tpo -c google/protobuf/compiler/cpp/cpp_primitive_field.cc -fPIC -DPIC -o cpp_primitive_field.o
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_service.lo -MD -MP -MF .deps/cpp_service.Tpo -c google/protobuf/compiler/cpp/cpp_service.cc -fPIC -DPIC -o cpp_service.o
mv -f .deps/cpp_message.Tpo .deps/cpp_message.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_string_field.lo -MD -MP -MF .deps/cpp_string_field.Tpo -c -o cpp_string_field.lo `test -f 'google/protobuf/compiler/cpp/cpp_string_field.cc' || echo './'`google/protobuf/compiler/cpp/cpp_string_field.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT cpp_string_field.lo -MD -MP -MF .deps/cpp_string_field.Tpo -c google/protobuf/compiler/cpp/cpp_string_field.cc -fPIC -DPIC -o cpp_string_field.o
mv -f .deps/cpp_service.Tpo .deps/cpp_service.Plo
mv -f .deps/cpp_primitive_field.Tpo .deps/cpp_primitive_field.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_enum.lo -MD -MP -MF .deps/java_enum.Tpo -c -o java_enum.lo `test -f 'google/protobuf/compiler/java/java_enum.cc' || echo './'`google/protobuf/compiler/java/java_enum.cc
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_enum_field.lo -MD -MP -MF .deps/java_enum_field.Tpo -c -o java_enum_field.lo `test -f 'google/protobuf/compiler/java/java_enum_field.cc' || echo './'`google/protobuf/compiler/java/java_enum_field.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_enum_field.lo -MD -MP -MF .deps/java_enum_field.Tpo -c google/protobuf/compiler/java/java_enum_field.cc -fPIC -DPIC -o java_enum_field.o
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_enum.lo -MD -MP -MF .deps/java_enum.Tpo -c google/protobuf/compiler/java/java_enum.cc -fPIC -DPIC -o java_enum.o
mv -f .deps/cpp_string_field.Tpo .deps/cpp_string_field.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_extension.lo -MD -MP -MF .deps/java_extension.Tpo -c -o java_extension.lo `test -f 'google/protobuf/compiler/java/java_extension.cc' || echo './'`google/protobuf/compiler/java/java_extension.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_extension.lo -MD -MP -MF .deps/java_extension.Tpo -c google/protobuf/compiler/java/java_extension.cc -fPIC -DPIC -o java_extension.o
mv -f .deps/java_enum.Tpo .deps/java_enum.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_field.lo -MD -MP -MF .deps/java_field.Tpo -c -o java_field.lo `test -f 'google/protobuf/compiler/java/java_field.cc' || echo './'`google/protobuf/compiler/java/java_field.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_field.lo -MD -MP -MF .deps/java_field.Tpo -c google/protobuf/compiler/java/java_field.cc -fPIC -DPIC -o java_field.o
mv -f .deps/java_enum_field.Tpo .deps/java_enum_field.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_file.lo -MD -MP -MF .deps/java_file.Tpo -c -o java_file.lo `test -f 'google/protobuf/compiler/java/java_file.cc' || echo './'`google/protobuf/compiler/java/java_file.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_file.lo -MD -MP -MF .deps/java_file.Tpo -c google/protobuf/compiler/java/java_file.cc -fPIC -DPIC -o java_file.o
mv -f .deps/java_extension.Tpo .deps/java_extension.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_generator.lo -MD -MP -MF .deps/java_generator.Tpo -c -o java_generator.lo `test -f 'google/protobuf/compiler/java/java_generator.cc' || echo './'`google/protobuf/compiler/java/java_generator.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_generator.lo -MD -MP -MF .deps/java_generator.Tpo -c google/protobuf/compiler/java/java_generator.cc -fPIC -DPIC -o java_generator.o
mv -f .deps/java_field.Tpo .deps/java_field.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_helpers.lo -MD -MP -MF .deps/java_helpers.Tpo -c -o java_helpers.lo `test -f 'google/protobuf/compiler/java/java_helpers.cc' || echo './'`google/protobuf/compiler/java/java_helpers.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_helpers.lo -MD -MP -MF .deps/java_helpers.Tpo -c google/protobuf/compiler/java/java_helpers.cc -fPIC -DPIC -o java_helpers.o
mv -f .deps/java_file.Tpo .deps/java_file.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_message.lo -MD -MP -MF .deps/java_message.Tpo -c -o java_message.lo `test -f 'google/protobuf/compiler/java/java_message.cc' || echo './'`google/protobuf/compiler/java/java_message.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_message.lo -MD -MP -MF .deps/java_message.Tpo -c google/protobuf/compiler/java/java_message.cc -fPIC -DPIC -o java_message.o
mv -f .deps/java_generator.Tpo .deps/java_generator.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_message_field.lo -MD -MP -MF .deps/java_message_field.Tpo -c -o java_message_field.lo `test -f 'google/protobuf/compiler/java/java_message_field.cc' || echo './'`google/protobuf/compiler/java/java_message_field.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_message_field.lo -MD -MP -MF .deps/java_message_field.Tpo -c google/protobuf/compiler/java/java_message_field.cc -fPIC -DPIC -o java_message_field.o
mv -f .deps/java_helpers.Tpo .deps/java_helpers.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_primitive_field.lo -MD -MP -MF .deps/java_primitive_field.Tpo -c -o java_primitive_field.lo `test -f 'google/protobuf/compiler/java/java_primitive_field.cc' || echo './'`google/protobuf/compiler/java/java_primitive_field.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_primitive_field.lo -MD -MP -MF .deps/java_primitive_field.Tpo -c google/protobuf/compiler/java/java_primitive_field.cc -fPIC -DPIC -o java_primitive_field.o
mv -f .deps/java_message.Tpo .deps/java_message.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_service.lo -MD -MP -MF .deps/java_service.Tpo -c -o java_service.lo `test -f 'google/protobuf/compiler/java/java_service.cc' || echo './'`google/protobuf/compiler/java/java_service.cc
mv -f .deps/java_message_field.Tpo .deps/java_message_field.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_string_field.lo -MD -MP -MF .deps/java_string_field.Tpo -c -o java_string_field.lo `test -f 'google/protobuf/compiler/java/java_string_field.cc' || echo './'`google/protobuf/compiler/java/java_string_field.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_service.lo -MD -MP -MF .deps/java_service.Tpo -c google/protobuf/compiler/java/java_service.cc -fPIC -DPIC -o java_service.o
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_string_field.lo -MD -MP -MF .deps/java_string_field.Tpo -c google/protobuf/compiler/java/java_string_field.cc -fPIC -DPIC -o java_string_field.o
mv -f .deps/java_primitive_field.Tpo .deps/java_primitive_field.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_doc_comment.lo -MD -MP -MF .deps/java_doc_comment.Tpo -c -o java_doc_comment.lo `test -f 'google/protobuf/compiler/java/java_doc_comment.cc' || echo './'`google/protobuf/compiler/java/java_doc_comment.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT java_doc_comment.lo -MD -MP -MF .deps/java_doc_comment.Tpo -c google/protobuf/compiler/java/java_doc_comment.cc -fPIC -DPIC -o java_doc_comment.o
mv -f .deps/java_doc_comment.Tpo .deps/java_doc_comment.Plo
/bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT python_generator.lo -MD -MP -MF .deps/python_generator.Tpo -c -o python_generator.lo `test -f 'google/protobuf/compiler/python/python_generator.cc' || echo './'`google/protobuf/compiler/python/python_generator.cc
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT python_generator.lo -MD -MP -MF .deps/python_generator.Tpo -c google/protobuf/compiler/python/python_generator.cc -fPIC -DPIC -o python_generator.o
mv -f .deps/java_service.Tpo .deps/java_service.Plo
/bin/bash ../libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -version-info 8:0:0 -export-dynamic -no-undefined -o libprotobuf.la -rpath /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_inst/lib atomicops_internals_x86_gcc.lo atomicops_internals_x86_msvc.lo common.lo once.lo stringprintf.lo extension_set.lo generated_message_util.lo message_lite.lo repeated_field.lo wire_format_lite.lo coded_stream.lo zero_copy_stream.lo zero_copy_stream_impl_lite.lo strutil.lo substitute.lo structurally_valid.lo descriptor.lo descriptor.pb.lo descriptor_database.lo dynamic_message.lo extension_set_heavy.lo generated_message_reflection.lo message.lo reflection_ops.lo service.lo text_format.lo unknown_field_set.lo wire_format.lo gzip_stream.lo printer.lo tokenizer.lo zero_copy_stream_impl.lo importer.lo parser.lo -lpthread -lz
mv -f .deps/java_string_field.Tpo .deps/java_string_field.Plo
libtool: link: ar cru .libs/libprotobuf.a atomicops_internals_x86_gcc.o atomicops_internals_x86_msvc.o common.o once.o stringprintf.o extension_set.o generated_message_util.o message_lite.o repeated_field.o wire_format_lite.o coded_stream.o zero_copy_stream.o zero_copy_stream_impl_lite.o strutil.o substitute.o structurally_valid.o descriptor.o descriptor.pb.o descriptor_database.o dynamic_message.o extension_set_heavy.o generated_message_reflection.o message.o reflection_ops.o service.o text_format.o unknown_field_set.o wire_format.o gzip_stream.o printer.o tokenizer.o zero_copy_stream_impl.o importer.o parser.o
libtool: link: ranlib .libs/libprotobuf.a
libtool: link: ( cd ".libs" && rm -f "libprotobuf.la" && ln -s "../libprotobuf.la" "libprotobuf.la" )
mv -f .deps/python_generator.Tpo .deps/python_generator.Plo
/bin/bash ../libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -version-info 8:0:0 -export-dynamic -no-undefined -o libprotoc.la -rpath /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_inst/lib code_generator.lo command_line_interface.lo plugin.lo plugin.pb.lo subprocess.lo zip_writer.lo cpp_enum.lo cpp_enum_field.lo cpp_extension.lo cpp_field.lo cpp_file.lo cpp_generator.lo cpp_helpers.lo cpp_message.lo cpp_message_field.lo cpp_primitive_field.lo cpp_service.lo cpp_string_field.lo java_enum.lo java_enum_field.lo java_extension.lo java_field.lo java_file.lo java_generator.lo java_helpers.lo java_message.lo java_message_field.lo java_primitive_field.lo java_service.lo java_string_field.lo java_doc_comment.lo python_generator.lo -lpthread libprotobuf.la -lz
libtool: link: ar cru .libs/libprotoc.a code_generator.o command_line_interface.o plugin.o plugin.pb.o subprocess.o zip_writer.o cpp_enum.o cpp_enum_field.o cpp_extension.o cpp_field.o cpp_file.o cpp_generator.o cpp_helpers.o cpp_message.o cpp_message_field.o cpp_primitive_field.o cpp_service.o cpp_string_field.o java_enum.o java_enum_field.o java_extension.o java_field.o java_file.o java_generator.o java_helpers.o java_message.o java_message_field.o java_primitive_field.o java_service.o java_string_field.o java_doc_comment.o python_generator.o
libtool: link: ranlib .libs/libprotoc.a
libtool: link: ( cd ".libs" && rm -f "libprotoc.la" && ln -s "../libprotoc.la" "libprotoc.la" )
/bin/bash ../libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o protoc main.o -lpthread libprotobuf.la libprotoc.la -lz
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -pthread -o protoc main.o ./.libs/libprotobuf.a ./.libs/libprotoc.a /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/.libs/libprotobuf.a -lpthread -lz -pthread
oldpwd=`pwd` && ( cd . && $oldpwd/protoc -I. --cpp_out=$oldpwd google/protobuf/unittest.proto google/protobuf/unittest_empty.proto google/protobuf/unittest_import.proto google/protobuf/unittest_import_public.proto google/protobuf/unittest_mset.proto google/protobuf/unittest_optimize_for.proto google/protobuf/unittest_embed_optimize_for.proto google/protobuf/unittest_custom_options.proto google/protobuf/unittest_lite.proto google/protobuf/unittest_import_lite.proto google/protobuf/unittest_import_public_lite.proto google/protobuf/unittest_lite_imports_nonlite.proto google/protobuf/unittest_no_generic_services.proto google/protobuf/compiler/cpp/cpp_test_bad_identifiers.proto )
touch unittest_proto_middleman
make all-am
make[11]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0/src'
/bin/bash ../libtool --tag=CXX --mode=link g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -version-info 8:0:0 -export-dynamic -no-undefined -o libprotobuf-lite.la -rpath /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_inst/lib atomicops_internals_x86_gcc.lo atomicops_internals_x86_msvc.lo common.lo once.lo stringprintf.lo extension_set.lo generated_message_util.lo message_lite.lo repeated_field.lo wire_format_lite.lo coded_stream.lo zero_copy_stream.lo zero_copy_stream_impl_lite.lo -lpthread -lz
libtool: link: ar cru .libs/libprotobuf-lite.a atomicops_internals_x86_gcc.o atomicops_internals_x86_msvc.o common.o once.o stringprintf.o extension_set.o generated_message_util.o message_lite.o repeated_field.o wire_format_lite.o coded_stream.o zero_copy_stream.o zero_copy_stream_impl_lite.o
libtool: link: ranlib .libs/libprotobuf-lite.a
libtool: link: ( cd ".libs" && rm -f "libprotobuf-lite.la" && ln -s "../libprotobuf-lite.la" "libprotobuf-lite.la" )
make[11]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0/src'
make[10]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0/src'
make[9]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0'
make[8]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty/protobuf-2.5.0'
touch protobuf-2.5.0-build-stamp
make[7]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty'
make[6]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty'
make[5]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess/3rdparty'
Making all in .
make[5]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess'
/bin/bash ./libtool --tag=CXX --mode=compile g++ -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libprocess\ 0.0.1\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBDL=1 -I. -I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/3rdparty/stout/include -I3rdparty/boost-1.53.0 -I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734 -I3rdparty/glog-0.3.3/src -I3rdparty/ry-http-parser-1c3624a -I/usr/include/subversion-1 -I/usr/include
/apr-1 -I/usr/include/apr-1.0 -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libprocess_la-clock.lo -MD -MP -MF .deps/libprocess_la-clock.Tpo -c -o libprocess_la-clock.lo `test -f 'src/clock.cpp' || echo '../../../3rdparty/libprocess/'`src/clock.cpp
/bin/bash ./libtool --tag=CXX --mode=compile g++ -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libprocess\ 0.0.1\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBDL=1 -I. -I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/3rdparty/stout/include -I3rdparty/boost-1.53.0 -I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734 -I3rdparty/glog-0.3.3/src -I3rdparty/ry-http-parser-1c3624a -I/usr/include/subversion-1 -I/usr/include
/apr-1 -I/usr/include/apr-1.0 -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libprocess_la-help.lo -MD -MP -MF .deps/libprocess_la-help.Tpo -c -o libprocess_la-help.lo `test -f 'src/help.cpp' || echo '../../../3rdparty/libprocess/'`src/help.cpp
/bin/bash ./libtool --tag=CXX --mode=compile g++ -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libprocess\ 0.0.1\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBDL=1 -I. -I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/3rdparty/stout/include -I3rdparty/boost-1.53.0 -I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734 -I3rdparty/glog-0.3.3/src -I3rdparty/ry-http-parser-1c3624a -I/usr/include/subversion-1 -I/usr/include
/apr-1 -I/usr/include/apr-1.0 -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libprocess_la-http.lo -MD -MP -MF .deps/libprocess_la-http.Tpo -c -o libprocess_la-http.lo `test -f 'src/http.cpp' || echo '../../../3rdparty/libprocess/'`src/http.cpp
libtool: compile: g++ -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" "-DPACKAGE_STRING=\"libprocess 0.0.1\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBDL=1 -I. -I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/3rdparty/stout/include -I3rdparty/boost-1.53.0 -I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734 -I3rdparty/glog-0.3.3/src -I3rdparty/ry-http-parser-1c3624a -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -
g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libprocess_la-clock.lo -MD -MP -MF .deps/libprocess_la-clock.Tpo -c ../../../3rdparty/libprocess/src/clock.cpp -fPIC -DPIC -o libprocess_la-clock.o
libtool: compile: g++ -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" "-DPACKAGE_STRING=\"libprocess 0.0.1\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBDL=1 -I. -I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/3rdparty/stout/include -I3rdparty/boost-1.53.0 -I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734 -I3rdparty/glog-0.3.3/src -I3rdparty/ry-http-parser-1c3624a -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -
g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libprocess_la-help.lo -MD -MP -MF .deps/libprocess_la-help.Tpo -c ../../../3rdparty/libprocess/src/help.cpp -fPIC -DPIC -o libprocess_la-help.o
libtool: compile: g++ -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" "-DPACKAGE_STRING=\"libprocess 0.0.1\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBDL=1 -I. -I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/3rdparty/stout/include -I3rdparty/boost-1.53.0 -I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734 -I3rdparty/glog-0.3.3/src -I3rdparty/ry-http-parser-1c3624a -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -
g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT libprocess_la-http.lo -MD -MP -MF .deps/libprocess_la-http.Tpo -c ../../../3rdparty/libprocess/src/http.cpp -fPIC -DPIC -o libprocess_la-http.o
In file included from ../../../3rdparty/libprocess/include/process/address.hpp:15:0,
from ../../../3rdparty/libprocess/include/process/pid.hpp:10,
from ../../../3rdparty/libprocess/src/clock.cpp:7:
../../../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp: In member function 'bool net::IP::operator<(const net::IP&) const':
../../../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:473:20: error: no match for 'operator<' (operand types are 'const net::IP::InternetAddressStorage' and 'const net::IP::InternetAddressStorage')
if (address_ < that.address_) {
^
../../../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:475:27: error: no match for 'operator==' (operand types are 'const net::IP::InternetAddressStorage' and 'const net::IP::InternetAddressStorage')
} else if (address_ == that.address_) {
^
In file included from ../../../3rdparty/libprocess/include/process/address.hpp:15:0,
from ../../../3rdparty/libprocess/include/process/pid.hpp:10,
from ../../../3rdparty/libprocess/include/process/latch.hpp:4,
from ../../../3rdparty/libprocess/include/process/future.hpp:23,
from ../../../3rdparty/libprocess/include/process/help.hpp:6,
from ../../../3rdparty/libprocess/src/help.cpp:19:
../../../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp: In member function 'bool net::IP::operator<(const net::IP&) const':
../../../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:473:20: error: no match for 'operator<' (operand types are 'const net::IP::InternetAddressStorage' and 'const net::IP::InternetAddressStorage')
if (address_ < that.address_) {
^
../../../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:475:27: error: no match for 'operator==' (operand types are 'const net::IP::InternetAddressStorage' and 'const net::IP::InternetAddressStorage')
} else if (address_ == that.address_) {
^
In file included from ../../../3rdparty/libprocess/include/process/address.hpp:15:0,
from ../../../3rdparty/libprocess/include/process/pid.hpp:10,
from ../../../3rdparty/libprocess/include/process/latch.hpp:4,
from ../../../3rdparty/libprocess/include/process/future.hpp:23,
from ../../../3rdparty/libprocess/src/http.cpp:11:
../../../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp: In member function 'bool net::IP::operator<(const net::IP&) const':
../../../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:473:20: error: no match for 'operator<' (operand types are 'const net::IP::InternetAddressStorage' and 'const net::IP::InternetAddressStorage')
if (address_ < that.address_) {
^
../../../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:475:27: error: no match for 'operator==' (operand types are 'const net::IP::InternetAddressStorage' and 'const net::IP::InternetAddressStorage')
} else if (address_ == that.address_) {
^
make[5]: *** [libprocess_la-clock.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
make[5]: *** [libprocess_la-help.lo] Error 1
make[5]: *** [libprocess_la-http.lo] Error 1
make[5]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty/libprocess'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build/3rdparty'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.22.0/_build'
make: *** [distcheck] Error 1
- Mesos ReviewBot
On Feb. 12, 2015, 5:47 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 5:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
> src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
> src/master/master.cpp 9e75b6c68854e6994e54a113f015831c4fb52a58
> src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
> src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
> src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
> src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635
> src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
> src/tests/master_tests.cpp c678527942506ef23fa4f1aebf9664e4cc21b561
> src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review72259
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On Feb. 12, 2015, 8:01 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 8:01 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
> src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
> src/master/master.cpp 9e75b6c68854e6994e54a113f015831c4fb52a58
> src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
> src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
> src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
> src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7
> src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
> src/tests/master_tests.cpp c678527942506ef23fa4f1aebf9664e4cc21b561
> src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: mesos: Create IP and IPNetwork AF_INET
abstraction.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review75530
-----------------------------------------------------------
Looking great! The code is much more cleaner now!
src/common/protobuf_utils.hpp
<https://reviews.apache.org/r/29290/#comment122692>
No need to introduce this helper for now since the implementation is just one line right now. Let's re-consider adding some helpers if Mesos starts to support ipv6 (i.e., store ipv6 in master info).
src/common/protobuf_utils.cpp
<https://reviews.apache.org/r/29290/#comment122693>
Kill this one.
src/common/protobuf_utils.cpp
<https://reviews.apache.org/r/29290/#comment122695>
Let add this TODO later once we start to add ipv6 impl.
src/common/protobuf_utils.cpp
<https://reviews.apache.org/r/29290/#comment122694>
Please add a NOTE about the fact that we store ip in network order (which is not standard and point to the ticket MESOS-1201).
src/linux/routing/diagnosis/diagnosis.cpp
<https://reviews.apache.org/r/29290/#comment122697>
Why returns a Try here?
src/linux/routing/filter/icmp.cpp
<https://reviews.apache.org/r/29290/#comment122698>
`struct in_addr` please
src/linux/routing/filter/icmp.cpp
<https://reviews.apache.org/r/29290/#comment122703>
Please add a NOTE here saying that filters only support IPv4 currently.
src/linux/routing/filter/icmp.cpp
<https://reviews.apache.org/r/29290/#comment122705>
```
return Error("Destination IP is not an IPv4 address");
```
src/linux/routing/filter/icmp.cpp
<https://reviews.apache.org/r/29290/#comment122706>
Opps. You've already done `value = ntohl(value)` above, why do you need to do it again here?
src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/29290/#comment122707>
Ditto. Please add a NOTE here.
src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/29290/#comment122709>
I don't think you need ntohl here.
src/linux/routing/route.cpp
<https://reviews.apache.org/r/29290/#comment122696>
Adjust the comments. Get destination IP network
src/master/master.cpp
<https://reviews.apache.org/r/29290/#comment122711>
Ditto. Remove this TODO and add a NOTE about the use of network order for ip.
src/slave/containerizer/isolators/network/port_mapping.hpp
<https://reviews.apache.org/r/29290/#comment122712>
s/hostIP/hostIPNetwork
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/29290/#comment122713>
Kill this TODO and add a NOTE somewhere saying that this isolator is for IPv4 only.
src/tests/master_contender_detector_tests.cpp
<https://reviews.apache.org/r/29290/#comment122716>
I guess they just need a random IP.
Please just do:
```
master.address.ip = net::IP::parse("1.2.3.4").get();
```
Here and every other cases below.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29290/#comment122668>
Let's do this:
```
EXPECT_EQ(
master.get().address.ip,
net::IP(ntohl(masterInfo.get().ip())));
```
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29290/#comment122669>
Ditto here.
src/tests/routing_tests.cpp
<https://reviews.apache.org/r/29290/#comment122715>
Just do
```
net::IP ip = net::IP::parse("1.2.3.4").get();
```
Here and other cases below!
- Jie Yu
On March 6, 2015, 8:02 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 8:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.hpp 7b478c4e23a2fb0895021ce5fb30bdf78131b871
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.hpp 932ed4bbf57e60261ff3b48ae242a7dd5e1f4260
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
> src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
> src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
> src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
> src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
> src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
> src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c
> src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
> src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
> src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
> src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: mesos: Create IP and IPNetwork AF_INET
abstraction.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review75623
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 6, 2015, 11:02 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 11:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.hpp 7b478c4e23a2fb0895021ce5fb30bdf78131b871
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.hpp 932ed4bbf57e60261ff3b48ae242a7dd5e1f4260
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
> src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
> src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
> src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
> src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
> src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
> src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c
> src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
> src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
> src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
> src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: mesos: Create IP and IPNetwork AF_INET
abstraction.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review75595
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31470, 31471, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On March 6, 2015, 11:02 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 11:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.hpp 7b478c4e23a2fb0895021ce5fb30bdf78131b871
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.hpp 932ed4bbf57e60261ff3b48ae242a7dd5e1f4260
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
> src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
> src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
> src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
> src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
> src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
> src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c
> src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
> src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
> src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
> src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: mesos: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated March 6, 2015, 11:02 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary
Diffs
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.hpp 7b478c4e23a2fb0895021ce5fb30bdf78131b871
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.hpp 932ed4bbf57e60261ff3b48ae242a7dd5e1f4260
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c
src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: mesos: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated March 6, 2015, 10:56 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.hpp 7b478c4e23a2fb0895021ce5fb30bdf78131b871
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.hpp 932ed4bbf57e60261ff3b48ae242a7dd5e1f4260
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c
src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: mesos: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated March 6, 2015, 8:02 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.hpp 7b478c4e23a2fb0895021ce5fb30bdf78131b871
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.hpp 932ed4bbf57e60261ff3b48ae242a7dd5e1f4260
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c
src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: mesos: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated March 5, 2015, 3:48 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.hpp 7b478c4e23a2fb0895021ce5fb30bdf78131b871
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.hpp 932ed4bbf57e60261ff3b48ae242a7dd5e1f4260
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c
src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: mesos: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated March 3, 2015, 11:29 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Summary (updated)
-----------------
mesos: Create IP and IPNetwork AF_INET abstraction.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description (updated)
-------
see summary
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.hpp 7b478c4e23a2fb0895021ce5fb30bdf78131b871
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.hpp 932ed4bbf57e60261ff3b48ae242a7dd5e1f4260
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 117c0ee720a60a1d8a25359028bad803f1fc2b07
src/master/master.cpp dae0955d4ab29ea74ea5ab9dd6e19b028c58c6fd
src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2
src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
src/tests/master_tests.cpp 3af20e9492ca38edd7a49b4e1f82c30880f53fa5
src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: mesos: Extend the IP and IPNetwork classes
to support IPv6.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review74532
-----------------------------------------------------------
src/common/protobuf_utils.cpp
<https://reviews.apache.org/r/29290/#comment121125>
why not just
return net::IP(info.ip());
?
- Dominic Hamon
On Feb. 27, 2015, 10:27 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 10:27 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 117c0ee720a60a1d8a25359028bad803f1fc2b07
> src/master/master.cpp 76e217d16c03e587ea4c0afca94c58b2212f0f93
> src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
> src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
> src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
> src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
> src/slave/slave.cpp 9f31fa46304398e8f87b41b55d8f4cfd4aba10b9
> src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
> src/tests/master_tests.cpp 5692f072a7bfa0b795c5996a6b809f2246bb6a66
> src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: mesos: Extend the IP and IPNetwork classes
to support IPv6.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 6:27 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 117c0ee720a60a1d8a25359028bad803f1fc2b07
src/master/master.cpp 76e217d16c03e587ea4c0afca94c58b2212f0f93
src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
src/slave/slave.cpp 9f31fa46304398e8f87b41b55d8f4cfd4aba10b9
src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
src/tests/master_tests.cpp 5692f072a7bfa0b795c5996a6b809f2246bb6a66
src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: mesos: Extend the IP and IPNetwork classes
to support IPv6.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 6:54 a.m.)
Review request for .
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 117c0ee720a60a1d8a25359028bad803f1fc2b07
src/master/master.cpp 76e217d16c03e587ea4c0afca94c58b2212f0f93
src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
src/slave/slave.cpp 9f31fa46304398e8f87b41b55d8f4cfd4aba10b9
src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
src/tests/master_tests.cpp 5692f072a7bfa0b795c5996a6b809f2246bb6a66
src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: mesos: Extend the IP and IPNetwork classes
to support IPv6.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 6:42 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Summary (updated)
-----------------
mesos: Extend the IP and IPNetwork classes to support IPv6.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 117c0ee720a60a1d8a25359028bad803f1fc2b07
src/master/master.cpp 76e217d16c03e587ea4c0afca94c58b2212f0f93
src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b
src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46
src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93
src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d
src/slave/slave.cpp 9f31fa46304398e8f87b41b55d8f4cfd4aba10b9
src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6
src/tests/master_tests.cpp 5692f072a7bfa0b795c5996a6b809f2246bb6a66
src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review73583
-----------------------------------------------------------
Bad patch!
Reviews applied: [29288, 29289, 29290]
Failed command: ./support/apply-review.sh -n -r 29290
Error:
2015-02-23 17:02:48 URL:https://reviews.apache.org/r/29290/diff/raw/ [37711/37711] -> "29290.patch" [1]
error: patch failed: src/tests/master_contender_detector_tests.cpp:198
error: src/tests/master_contender_detector_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Feb. 21, 2015, 3:37 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2015, 3:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
> src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
> src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937
> src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
> src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
> src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
> src/slave/slave.cpp 0374ca061cb53dc7e3338366aa41b1c15fb3231c
> src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
> src/tests/master_tests.cpp 3a9da68364fda25ac25565a1d2799f2dfaf736da
> src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Feb. 21, 2015, 3:37 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937
src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
src/slave/slave.cpp 0374ca061cb53dc7e3338366aa41b1c15fb3231c
src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
src/tests/master_tests.cpp 3a9da68364fda25ac25565a1d2799f2dfaf736da
src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Feb. 21, 2015, 3:21 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937
src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
src/slave/slave.cpp 0374ca061cb53dc7e3338366aa41b1c15fb3231c
src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
src/tests/master_tests.cpp 3a9da68364fda25ac25565a1d2799f2dfaf736da
src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 8:01 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
src/master/master.cpp 9e75b6c68854e6994e54a113f015831c4fb52a58
src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7
src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
src/tests/master_tests.cpp c678527942506ef23fa4f1aebf9664e4cc21b561
src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 5:47 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
src/master/master.cpp 9e75b6c68854e6994e54a113f015831c4fb52a58
src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635
src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
src/tests/master_tests.cpp c678527942506ef23fa4f1aebf9664e4cc21b561
src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Feb. 11, 2015, 3:39 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Changes
-------
merged InternetAddress with IP
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5
src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba
src/master/master.cpp 9e75b6c68854e6994e54a113f015831c4fb52a58
src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905
src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182
src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44
src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635
src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db
src/tests/master_tests.cpp c678527942506ef23fa4f1aebf9664e4cc21b561
src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 28, 2015, 10:04 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 3981b18cb82d3b8bd974b80d27f14c304898a43c
src/master/master.cpp 54f26900ac8c63e79a1f89562a988c9a2567d209
src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
src/slave/containerizer/isolators/network/port_mapping.cpp b484bbf34060ccc9debd48a3e840c03c8f95de09
src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 27, 2015, 4:58 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f
src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
src/slave/containerizer/isolators/network/port_mapping.cpp b484bbf34060ccc9debd48a3e840c03c8f95de09
src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review69661
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On Jan. 26, 2015, 6:55 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 6:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp bda8fda9bc2e52ccc1d75e2541e4604989515e13
> src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
> src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
> src/slave/containerizer/isolators/network/port_mapping.cpp b484bbf34060ccc9debd48a3e840c03c8f95de09
> src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
> src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 26, 2015, 6:55 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Changes
-------
renamed the Address class into InAddrStorage
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description (updated)
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp bda8fda9bc2e52ccc1d75e2541e4604989515e13
src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
src/slave/containerizer/isolators/network/port_mapping.cpp b484bbf34060ccc9debd48a3e840c03c8f95de09
src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 15, 2015, 7:17 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review67320
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Jan. 8, 2015, 2:53 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 2:53 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 8, 2015, 10:53 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review67313
-----------------------------------------------------------
src/linux/routing/route.cpp
<https://reviews.apache.org/r/29290/#comment111309>
as in the code before your change, better to break after the ( when you're passing multiple parameters:
Try<net::IP> ip = net::IP::fromAddressPrefix(
networkToHostAddress.get(),
nl_addr_get_prefixlen(dst));
- Dominic Hamon
On Jan. 8, 2015, 8:49 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 8:49 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review67213
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On Jan. 8, 2015, 4:49 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 4:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
> src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 8, 2015, 4:49 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 8, 2015, 3:44 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review67203
-----------------------------------------------------------
Bad patch!
Reviews applied: [29288, 29289]
Failed command: ./support/apply-review.sh -n -r 29289
Error:
2015-01-08 15:44:09 URL:https://reviews.apache.org/r/29289/diff/raw/ [14860/14860] -> "29289.patch" [1]
Successfully applied: libprocess: Created IP address abstraction for different protocol families
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Review: https://reviews.apache.org/r/29289
Checking 8 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.
Please use separate commits for mesos, libprocess and stout.
Paths grouped by project:
libprocess:
3rdparty/libprocess/include/process/node.hpp
3rdparty/libprocess/include/process/pid.hpp
3rdparty/libprocess/include/process/socket.hpp
3rdparty/libprocess/src/http.cpp
3rdparty/libprocess/src/pid.cpp
3rdparty/libprocess/src/process.cpp
3rdparty/libprocess/src/socket.cpp
stout:
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
Failed to commit patch
- Mesos ReviewBot
On Jan. 8, 2015, 3:28 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 3:28 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 8, 2015, 3:28 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review67080
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On Jan. 7, 2015, 8:13 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 8:13 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 7, 2015, 8:13 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Changes
-------
fixed indentation
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 7, 2015, 7:33 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review67057
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On Jan. 7, 2015, 6:16 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 6:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 7, 2015, 6:16 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 2:17 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs
-----
src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review66824
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All tests passed.
- Mesos ReviewBot
On Jan. 6, 2015, 1:09 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 1:09 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
> src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
> src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
> src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
> src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
>
> Diff: https://reviews.apache.org/r/29290/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 1:09 p.m.)
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 5:51 a.m.)
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/port_mapping_tests.cpp eb82993520f7e8de46cf6cf6b638a9286aa9b3df
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 5:21 a.m.)
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description (updated)
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/port_mapping_tests.cpp eb82993520f7e8de46cf6cf6b638a9286aa9b3df
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29290: Created IP address abstraction for different
protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Dec. 20, 2014, 3:39 a.m.)
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
The Address can be in NETWORK or BYTE order.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs
-----
src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/port_mapping_tests.cpp eb82993520f7e8de46cf6cf6b638a9286aa9b3df
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu