You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:32:23 UTC
[GitHub] [incubator-apisix] membphis opened a new issue #1615: bugfix(prometheus):
membphis opened a new issue #1615:
URL: https://github.com/apache/incubator-apisix/issues/1615
The statistics should use millisecond units, so it needs to be multiplied by 1000.
https://github.com/apache/incubator-apisix/blob/master/apisix/plugins/prometheus/exporter.lua#L113
```lua
overhead = overhead - tonumber(ctx.var.upstream_response_time)
overhead = overhead * 1000
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] dabue commented on issue #1615: bugfix(prometheus): the `overhead` should use millisecond units, so it needs to be multiplied by 1000
Posted by GitBox <gi...@apache.org>.
dabue commented on issue #1615:
URL: https://github.com/apache/incubator-apisix/issues/1615#issuecomment-634029233
I wanna fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] JanLi-air commented on issue #1615: bugfix(prometheus): the `overhead` should use millisecond units, so it needs to be multiplied by 1000
Posted by GitBox <gi...@apache.org>.
JanLi-air commented on issue #1615:
URL: https://github.com/apache/incubator-apisix/issues/1615#issuecomment-634030245
overhead already has 1000 multiplied, this should be
`overhead = overhead - tonumber(ctx.var.upstream_response_time) * 1000`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on issue #1615: bugfix(prometheus): the `overhead` should use millisecond units, so it needs to be multiplied by 1000
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1615:
URL: https://github.com/apache/incubator-apisix/issues/1615#issuecomment-634031184
@JanLi-air many thx, your way is right. I was wrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis closed issue #1615: bugfix(prometheus): the `overhead` should use millisecond units, so it needs to be multiplied by 1000
Posted by GitBox <gi...@apache.org>.
membphis closed issue #1615:
URL: https://github.com/apache/incubator-apisix/issues/1615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org