You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/03/19 22:14:26 UTC
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/72
NotUpDiagnostics: don’t collect if starting && !up
Previously we'd collect the not-up-diagnostics when starting, even though we didn't expect the Entity to be up yet. Now we only call it when there is a genuine problem that would result in the entity being "on-fire".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix/NotUpDiagnostics
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 13fe1c0dc828e342f6482442cdc3aef55d8df8e3
Author: Aled Sage <al...@gmail.com>
Date: 2016-03-18T23:09:04Z
NotUpDiagnostics: don’t collect if starting && !up
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by aledsage <gi...@git.apache.org>.
GitHub user aledsage reopened a pull request:
https://github.com/apache/brooklyn-server/pull/72
NotUpDiagnostics: don’t collect if starting && !up
Previously we'd collect the not-up-diagnostics when starting, even though we didn't expect the Entity to be up yet. Now we only call it when there is a genuine problem that would result in the entity being "on-fire".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix/NotUpDiagnostics
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 13fe1c0dc828e342f6482442cdc3aef55d8df8e3
Author: Aled Sage <al...@gmail.com>
Date: 2016-03-18T23:09:04Z
NotUpDiagnostics: don’t collect if starting && !up
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage closed the pull request at:
https://github.com/apache/brooklyn-server/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage closed the pull request at:
https://github.com/apache/brooklyn-server/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/72#issuecomment-199797981
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by aledsage <gi...@git.apache.org>.
GitHub user aledsage reopened a pull request:
https://github.com/apache/brooklyn-server/pull/72
NotUpDiagnostics: don’t collect if starting && !up
Previously we'd collect the not-up-diagnostics when starting, even though we didn't expect the Entity to be up yet. Now we only call it when there is a genuine problem that would result in the entity being "on-fire".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix/NotUpDiagnostics
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 13fe1c0dc828e342f6482442cdc3aef55d8df8e3
Author: Aled Sage <al...@gmail.com>
Date: 2016-03-18T23:09:04Z
NotUpDiagnostics: don’t collect if starting && !up
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage closed the pull request at:
https://github.com/apache/brooklyn-server/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-server/pull/72#issuecomment-198787548
Strange (unrelated) jenkins build error - one for the Apache infrastructure team? Or just see if it happens again? Closing + reopening to kick off the build again.
```
Checking out Revision 34b40cb3217c2d03e3220826ba7d1ed2ee1e6761 (master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 34b40cb3217c2d03e3220826ba7d1ed2ee1e6761
> git rev-parse origin/master^{commit} # timeout=10
> git rev-list 3767000c6a1f122e35e29040ad1e6138bcebe2dc # timeout=10
ERROR: Maven Home null doesn?t exist
Putting comment on the pull request
Finished: FAILURE
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by aledsage <gi...@git.apache.org>.
GitHub user aledsage reopened a pull request:
https://github.com/apache/brooklyn-server/pull/72
NotUpDiagnostics: don’t collect if starting && !up
Previously we'd collect the not-up-diagnostics when starting, even though we didn't expect the Entity to be up yet. Now we only call it when there is a genuine problem that would result in the entity being "on-fire".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix/NotUpDiagnostics
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 13fe1c0dc828e342f6482442cdc3aef55d8df8e3
Author: Aled Sage <al...@gmail.com>
Date: 2016-03-18T23:09:04Z
NotUpDiagnostics: don’t collect if starting && !up
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage closed the pull request at:
https://github.com/apache/brooklyn-server/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-server/pull/72#issuecomment-199213277
Kicking off jenkins again, by closing and reopening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by aledsage <gi...@git.apache.org>.
GitHub user aledsage reopened a pull request:
https://github.com/apache/brooklyn-server/pull/72
NotUpDiagnostics: don’t collect if starting && !up
Previously we'd collect the not-up-diagnostics when starting, even though we didn't expect the Entity to be up yet. Now we only call it when there is a genuine problem that would result in the entity being "on-fire".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix/NotUpDiagnostics
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 13fe1c0dc828e342f6482442cdc3aef55d8df8e3
Author: Aled Sage <al...@gmail.com>
Date: 2016-03-18T23:09:04Z
NotUpDiagnostics: don’t collect if starting && !up
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/72#issuecomment-199336094
@aledsage The job was executed with the ubuntu provided jre. This could be related https://mail-archives.apache.org/mod_mbox/www-builds/201603.mbox/browser.
Selected another JDK 1.7 (from the multitude of alternatives) for the build. Can you try again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-server/pull/72#issuecomment-199296303
@neykov @rdowner @ahgittin this jenkins build failed with:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project brooklyn-utils-test-support: Compilation failure
[ERROR] No compiler is provided in this environment. Perhaps you are running on a JRE rather than a JDK?
```
Any ideas?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: NotUpDiagnostics: don’t collect if...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---