You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by js...@apache.org on 2002/05/17 20:04:00 UTC

cvs commit: jakarta-commons-sandbox/jelly TODO.txt

jstrachan    02/05/17 11:04:00

  Modified:    jelly/src/java/org/apache/commons/jelly/tags/xml
                        XMLTagLibrary.java
               jelly    TODO.txt
  Log:
  Patched bug in XML tags that <x:forEach> wasn't properly setting the XPath context.
  We now have some early JUnit tests written in Jelly itself.
  
  Could do with some JUnit tags of the form...
  
  <junit:assert test="${foo == 22}">some description</junit:assert>
  <junit:assertEquals value="${foo}" expected="${22}"some description</junit:assert>
  
  Revision  Changes    Path
  1.6       +8 -6      jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/xml/XMLTagLibrary.java
  
  Index: XMLTagLibrary.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/xml/XMLTagLibrary.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- XMLTagLibrary.java	17 May 2002 15:18:13 -0000	1.5
  +++ XMLTagLibrary.java	17 May 2002 18:04:00 -0000	1.6
  @@ -1,7 +1,7 @@
   /*
  - * $Header: /home/cvs/jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/xml/XMLTagLibrary.java,v 1.5 2002/05/17 15:18:13 jstrachan Exp $
  - * $Revision: 1.5 $
  - * $Date: 2002/05/17 15:18:13 $
  + * $Header: /home/cvs/jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/xml/XMLTagLibrary.java,v 1.6 2002/05/17 18:04:00 jstrachan Exp $
  + * $Revision: 1.6 $
  + * $Date: 2002/05/17 18:04:00 $
    *
    * ====================================================================
    *
  @@ -57,7 +57,7 @@
    * information on the Apache Software Foundation, please see
    * <http://www.apache.org/>.
    * 
  - * $Id: XMLTagLibrary.java,v 1.5 2002/05/17 15:18:13 jstrachan Exp $
  + * $Id: XMLTagLibrary.java,v 1.6 2002/05/17 18:04:00 jstrachan Exp $
    */
   package org.apache.commons.jelly.tags.xml;
   
  @@ -83,7 +83,7 @@
   /** Describes the Taglib. This class could be generated by XDoclet
     *
     * @author <a href="mailto:jstrachan@apache.org">James Strachan</a>
  -  * @version $Revision: 1.5 $
  +  * @version $Revision: 1.6 $
     */
   public class XMLTagLibrary extends TagLibrary {
   
  @@ -110,7 +110,9 @@
           // #### may need to include some namespace URI information in the XPath instance?
           
           if (attributeName.equals("select")) {            
  -            log.info( "Parsing XPath expression: " + attributeValue );
  +            if ( log.isDebugEnabled() ) {
  +                log.debug( "Parsing XPath expression: " + attributeValue );
  +            }
               
               try {
                   XPath xpath = new Dom4jXPath(attributeValue);
  
  
  
  1.9       +2 -2      jakarta-commons-sandbox/jelly/TODO.txt
  
  Index: TODO.txt
  ===================================================================
  RCS file: /home/cvs/jakarta-commons-sandbox/jelly/TODO.txt,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- TODO.txt	17 May 2002 15:18:14 -0000	1.8
  +++ TODO.txt	17 May 2002 18:04:00 -0000	1.9
  @@ -1,8 +1,8 @@
   TO DO LIST
   ==========
   
  -* remove the Context parameter from the run() method. Maybe use the same doTag() method a-la the
  -  current JSP 1.3 spec.	
  +* rename the DynaTag interface to be DynamicAttributes along with JSP1.3, also add a namespace URI parameter
  +
   
   * warn if typeo is used for tag attribute; maybe even generate an error?
   
  
  
  

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>