You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Brian Foster (Created) (JIRA)" <ji...@apache.org> on 2012/03/14 06:09:49 UTC

[jira] [Created] (OODT-409) Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
--------------------------------------------------------------------------------

                 Key: OODT-409
                 URL: https://issues.apache.org/jira/browse/OODT-409
             Project: OODT
          Issue Type: Improvement
          Components: pge wrapper framework
    Affects Versions: 0.3
         Environment: none
            Reporter: Brian Foster
            Assignee: Brian Foster
            Priority: Minor
             Fix For: 0.4


The enum for met keys will allow for backwards compatibility to be toggled on/off easily

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-409) Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228978#comment-13228978 ] 

jiraposter@reviews.apache.org commented on OODT-409:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/
-----------------------------------------------------------

Review request for oodt, Chris Mattmann and Paul Ramirez.


Summary
-------

The enum for met keys will allow for backwards compatibility to be toggled on/off easily


This addresses bug OODT-409.
    https://issues.apache.org/jira/browse/OODT-409


Diffs
-----

  trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300432 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300432 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java PRE-CREATION 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java 1300432 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java PRE-CREATION 
  trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
  trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java PRE-CREATION 

Diff: https://reviews.apache.org/r/4326/diff


Testing
-------

Added/Updated Unit-Tests


Thanks,

brian


                
> Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
> --------------------------------------------------------------------------------
>
>                 Key: OODT-409
>                 URL: https://issues.apache.org/jira/browse/OODT-409
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-409.2012-03-13.patch.txt
>
>
> The enum for met keys will allow for backwards compatibility to be toggled on/off easily

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-409) Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229287#comment-13229287 ] 

jiraposter@reviews.apache.org commented on OODT-409:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/#review5943
-----------------------------------------------------------

Ship it!


That was the only change I saw. Otherwise looks good.


trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java
<https://reviews.apache.org/r/4326/#comment12904>

    shouldn't this be:
    
    return Boolean.getBoolean(System.getProperty(USE_LEGACY_PROPERTY)) ? legacyName : name;
    
    


- Paul


On 2012-03-14 05:18:33, brian Foster wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4326/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-14 05:18:33)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann and Paul Ramirez.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The enum for met keys will allow for backwards compatibility to be toggled on/off easily
bq.  
bq.  
bq.  This addresses bug OODT-409.
bq.      https://issues.apache.org/jira/browse/OODT-409
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java PRE-CREATION 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4326/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added/Updated Unit-Tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  brian
bq.  
bq.


                
> Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
> --------------------------------------------------------------------------------
>
>                 Key: OODT-409
>                 URL: https://issues.apache.org/jira/browse/OODT-409
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-409.2012-03-13.patch.txt
>
>
> The enum for met keys will allow for backwards compatibility to be toggled on/off easily

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (OODT-409) Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

Posted by "Brian Foster (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OODT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Foster resolved OODT-409.
-------------------------------

    Resolution: Fixed

- fixed in r1300799
                
> Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
> --------------------------------------------------------------------------------
>
>                 Key: OODT-409
>                 URL: https://issues.apache.org/jira/browse/OODT-409
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-409.2012-03-13.patch.txt
>
>
> The enum for met keys will allow for backwards compatibility to be toggled on/off easily

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OODT-409) Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

Posted by "Brian Foster (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OODT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Foster updated OODT-409:
------------------------------

    Attachment: OODT-409.2012-03-13.patch.txt

- attached patch
                
> Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
> --------------------------------------------------------------------------------
>
>                 Key: OODT-409
>                 URL: https://issues.apache.org/jira/browse/OODT-409
>             Project: OODT
>          Issue Type: Improvement
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-409.2012-03-13.patch.txt
>
>
> The enum for met keys will allow for backwards compatibility to be toggled on/off easily

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-409) Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229582#comment-13229582 ] 

jiraposter@reviews.apache.org commented on OODT-409:
----------------------------------------------------



bq.  On 2012-03-14 16:05:06, Paul Ramirez wrote:
bq.  > trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java, line 47
bq.  > <https://reviews.apache.org/r/4326/diff/1/?file=92060#file92060line47>
bq.  >
bq.  >     shouldn't this be:
bq.  >     
bq.  >     return Boolean.getBoolean(System.getProperty(USE_LEGACY_PROPERTY)) ? legacyName : name;
bq.  >     
bq.  >

hey paul... i think you are think of Boolean.parseBoolean(String)... here is the javadoc on: Boolean.getBoolean(String):

Returns true if and only if the system property named by the argument exists and is equal to the string "true". (Beginning with version 1.0.2 of the JavaTM platform, the test of this string is case insensitive.) A system property is accessible through getProperty, a method defined by the System class.
If there is no property with the specified name, or if the specified name is empty or null, then false is returned.


- brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/#review5943
-----------------------------------------------------------


On 2012-03-14 05:18:33, brian Foster wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4326/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-14 05:18:33)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann and Paul Ramirez.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The enum for met keys will allow for backwards compatibility to be toggled on/off easily
bq.  
bq.  
bq.  This addresses bug OODT-409.
bq.      https://issues.apache.org/jira/browse/OODT-409
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java PRE-CREATION 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4326/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added/Updated Unit-Tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  brian
bq.  
bq.


                
> Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
> --------------------------------------------------------------------------------
>
>                 Key: OODT-409
>                 URL: https://issues.apache.org/jira/browse/OODT-409
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-409.2012-03-13.patch.txt
>
>
> The enum for met keys will allow for backwards compatibility to be toggled on/off easily

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OODT-409) Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

Posted by "Brian Foster (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OODT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Foster updated OODT-409:
------------------------------

    Issue Type: Sub-task  (was: Improvement)
        Parent: OODT-215
    
> Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
> --------------------------------------------------------------------------------
>
>                 Key: OODT-409
>                 URL: https://issues.apache.org/jira/browse/OODT-409
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-409.2012-03-13.patch.txt
>
>
> The enum for met keys will allow for backwards compatibility to be toggled on/off easily

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-409) Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229535#comment-13229535 ] 

jiraposter@reviews.apache.org commented on OODT-409:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/#review5959
-----------------------------------------------------------



trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java
<https://reviews.apache.org/r/4326/#comment12928>

    What a fantastic way of supporting this!


- Chris


On 2012-03-14 05:18:33, brian Foster wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4326/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-14 05:18:33)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann and Paul Ramirez.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The enum for met keys will allow for backwards compatibility to be toggled on/off easily
bq.  
bq.  
bq.  This addresses bug OODT-409.
bq.      https://issues.apache.org/jira/browse/OODT-409
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java PRE-CREATION 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4326/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added/Updated Unit-Tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  brian
bq.  
bq.


                
> Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
> --------------------------------------------------------------------------------
>
>                 Key: OODT-409
>                 URL: https://issues.apache.org/jira/browse/OODT-409
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-409.2012-03-13.patch.txt
>
>
> The enum for met keys will allow for backwards compatibility to be toggled on/off easily

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-409) Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229536#comment-13229536 ] 

jiraposter@reviews.apache.org commented on OODT-409:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/#review5960
-----------------------------------------------------------

Ship it!


LGTM!

- Chris


On 2012-03-14 05:18:33, brian Foster wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4326/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-14 05:18:33)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann and Paul Ramirez.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The enum for met keys will allow for backwards compatibility to be toggled on/off easily
bq.  
bq.  
bq.  This addresses bug OODT-409.
bq.      https://issues.apache.org/jira/browse/OODT-409
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java 1300432 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java PRE-CREATION 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4326/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added/Updated Unit-Tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  brian
bq.  
bq.


                
> Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
> --------------------------------------------------------------------------------
>
>                 Key: OODT-409
>                 URL: https://issues.apache.org/jira/browse/OODT-409
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-409.2012-03-13.patch.txt
>
>
> The enum for met keys will allow for backwards compatibility to be toggled on/off easily

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira