You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by so...@apache.org on 2023/04/26 15:47:49 UTC
[openmeetings] branch master updated: [OPENMEETINGS-2767] WebRTCPeer was updated with latest changes from OpenVidu; instructions to enable service were added
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new fe74b9773 [OPENMEETINGS-2767] WebRTCPeer was updated with latest changes from OpenVidu; instructions to enable service were added
fe74b9773 is described below
commit fe74b9773806dc96a265a4b66518677fa77ae468
Author: Maxim Solodovnik <so...@gmail.com>
AuthorDate: Wed Apr 26 22:47:39 2023 +0700
[OPENMEETINGS-2767] WebRTCPeer was updated with latest changes from OpenVidu; instructions to enable service were added
---
.../src/main/assembly/scripts/openmeetings.service | 1 +
.../src/main/front/settings/src/WebRtcPeer.js | 18 +++++++++++-------
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/openmeetings-server/src/main/assembly/scripts/openmeetings.service b/openmeetings-server/src/main/assembly/scripts/openmeetings.service
index 6dc77bf5e..ceee2cd79 100644
--- a/openmeetings-server/src/main/assembly/scripts/openmeetings.service
+++ b/openmeetings-server/src/main/assembly/scripts/openmeetings.service
@@ -14,6 +14,7 @@
# /etc/systemd/system/openmeetings.service
# sudo systemctl daemon-reload
+# sudo systemctl enable openmeetings
# sudo systemctl restart openmeetings
[Unit]
diff --git a/openmeetings-web/src/main/front/settings/src/WebRtcPeer.js b/openmeetings-web/src/main/front/settings/src/WebRtcPeer.js
index 5d1b84751..bdabed460 100644
--- a/openmeetings-web/src/main/front/settings/src/WebRtcPeer.js
+++ b/openmeetings-web/src/main/front/settings/src/WebRtcPeer.js
@@ -90,12 +90,16 @@ class WebRtcPeer {
};
this.pc.addEventListener('icecandidate', this._iceCandidateListener);
- this._signalingStateChangeListener = () => {
+ this._signalingStateChangeListener = async () => {
if (this.pc.signalingState === 'stable') {
// SDP Offer/Answer finished. Add stored remote candidates.
while (this.iceCandidateList.length > 0) {
let candidate = this.iceCandidateList.shift();
- this.pc.addIceCandidate(candidate);
+ try {
+ await this.pc.addIceCandidate(candidate);
+ } catch (error) {
+ console.error('Error when calling RTCPeerConnection#addIceCandidate for RTCPeerConnection ' + this.getId(), error);
+ }
}
}
};
@@ -488,12 +492,12 @@ class WebRtcPeer {
' (' +
otherId +
') change to "disconnected". Possible network disconnection';
- logger.warn(msg1);
+ console.warn(msg1);
this.configuration.onIceConnectionStateException(ExceptionEventName.ICE_CONNECTION_DISCONNECTED, msg1);
break;
case 'failed':
const msg2 = 'IceConnectionState of RTCPeerConnection ' + this.configuration.id + ' (' + otherId + ') to "failed"';
- logger.error(msg2);
+ console.error(msg2);
this.configuration.onIceConnectionStateException(ExceptionEventName.ICE_CONNECTION_FAILED, msg2);
break;
case 'closed':
@@ -505,17 +509,17 @@ class WebRtcPeer {
OmUtil.log('IceConnectionState of RTCPeerConnection ' + this.configuration.id + ' (' + otherId + ') change to "new"');
break;
case 'checking':
- logger.log(
+ OmUtil.log(
'IceConnectionState of RTCPeerConnection ' + this.configuration.id + ' (' + otherId + ') change to "checking"'
);
break;
case 'connected':
- logger.log(
+ OmUtil.log(
'IceConnectionState of RTCPeerConnection ' + this.configuration.id + ' (' + otherId + ') change to "connected"'
);
break;
case 'completed':
- logger.log(
+ OmUtil.log(
'IceConnectionState of RTCPeerConnection ' + this.configuration.id + ' (' + otherId + ') change to "completed"'
);
break;