You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "KatalKavya96 (via GitHub)" <gi...@apache.org> on 2025/09/19 08:32:24 UTC
[PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
KatalKavya96 opened a new pull request, #55876:
URL: https://github.com/apache/airflow/pull/55876
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
---
### Description
This PR updates the **UI Guide documentation** to reflect the refreshed Airflow 3.1.x UI.
- Re-captured all screenshots in both **dark** and **light** themes (1080p+, consistent zoom level).
- Updated `:alt:` text for accessibility and clarity.
- Verified that all image paths resolve correctly in `docs/ui.rst`.
These changes ensure that the UI Guide remains accurate and visually consistent for Airflow 3.1.x.
### Related Issues
closes: #55521
### Notes
- This PR covers **UI Guide** updates.
- A follow-up PR will handle **DAG Runs** screenshots (also part of #55521).
- No code or provider changes are introduced in this PR.
- Newsfragment not required, as this is a documentation-only update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3323067507
@KatalKavya96 Please can you go and review the side-by-side diff and see that they roughly match the old content before asking a review again. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3324414667
@kaxil Thanks for the merge but all the files in ui.rst were not updated rightly in the docs after i tried to rebase. I was trying to fix this issue by adding all other left images, Since this PR has been merged let me raise another PR for the files which still remains not updated, Is it fine with you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "cmarteepants (via GitHub)" <gi...@apache.org>.
cmarteepants commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364345684
##########
airflow-core/docs/img/ui-dark/dag_overview_dashboard.png:
##########
Review Comment:
You're right. @KatalKavya96 better if we are more similar. Like I mentioned in the other comment, if you use the dag code I gave you in the issue and run it a few times, some tasks will sporadically fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364760994
##########
airflow-core/docs/img/ui-dark/dag_overview_grid.png:
##########
Review Comment:
@KatalKavya96 The before image looked better, could you create similar if possible, especially the last column looks weird in this one and shows gantt / duration too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364310945
##########
airflow-core/docs/img/ui-dark/dag_overview_grid.png:
##########
Review Comment:
Same here -- the old had various state, the replacement only has green/succeded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2365339398
##########
airflow-core/docs/img/ui-dark/dag_run_graph.png:
##########
Review Comment:
> @KatalKavya96 This isn't dagrun yet! the image you added doesn't have state
<img width="1349" height="655" alt="Screenshot 2025-09-20 at 11 20 24 AM" src="https://github.com/user-attachments/assets/3582f400-2bdc-4128-ada5-5d36ab581f1f" />
Is this image fine for dag_run_graph?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364450401
##########
airflow-core/docs/img/ui-dark/dag_run_graph.png:
##########
Review Comment:
same for this one, try to match original screenshot please
##########
airflow-core/docs/img/ui-dark/dag_run_task_instances.png:
##########
Review Comment:
same for this one, try to match original screenshot please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "cmarteepants (via GitHub)" <gi...@apache.org>.
cmarteepants commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3312574121
Great job! There's just one screenshot that should be updated (however is easiest).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2371650886
##########
airflow-core/docs/img/ui-dark/branch_without_trigger.png:
##########
Review Comment:
Here too - old view had a code line highlighted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3323064159
@KatalKavya96 No, I'm afraid not. There are still unresolved comments (even before I just reviewed it and added some more)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3323099160
@ashb Ok , I will once go for a side by side comparison for all changed images and make sure that they are the nearest to the original image, Thanks for the Review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "cmarteepants (via GitHub)" <gi...@apache.org>.
cmarteepants commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364333944
##########
airflow-core/docs/img/ui-dark/dag_overview_dashboard.png:
##########
Review Comment:
Yes, I'm ok with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3313807581
@kaxil I have replaced above listed 4 images (both light and dark). Please review it further
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "cmarteepants (via GitHub)" <gi...@apache.org>.
cmarteepants commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2363216834
##########
airflow-core/docs/img/ui-light/dag_list.png:
##########
Review Comment:
Don't need to necessarily redo the screenshots, but we should crop out the bottom since it accidentally includes the thumbnail of a different screenshot
##########
airflow-core/docs/ui.rst:
##########
@@ -211,18 +211,6 @@ The **Tasks** tab shows metadata for each task in the Dag, including operator ty
|
-Events Tab
-''''''''''
-
-The **Events** tab surfaces structured events related to the Dag, such as Dag triggers and version patches. This tab is especially useful for Dag versioning and troubleshooting changes.
-
-.. image:: img/ui-dark/dag_overview_events.png
- :alt: Dag Events Tab (Dark Mode)
-
-|
-
-.. image:: img/ui-light/dag_overview_events.png
- :alt: Dag Events Tab (Light Mode)
Review Comment:
Good catch, I didn't realize that the screenshot was missing and not rendering in the current version. Made a note to re-add something later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3322242252
Yeah lgtm. Although looks like there are merge conflicts. Could you resolve that @KatalKavya96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2365339398
##########
airflow-core/docs/img/ui-dark/dag_run_graph.png:
##########
Review Comment:
> @KatalKavya96 This isn't dagrun yet! the image you added doesn't have state
<img width="1349" height="655" alt="Screenshot 2025-09-20 at 11 20 24 AM" src="https://github.com/user-attachments/assets/3582f400-2bdc-4128-ada5-5d36ab581f1f" />
@kaxil Is this image fine for dag_run_graph?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364308824
##########
airflow-core/docs/img/ui-dark/dag_overview_dashboard.png:
##########
Review Comment:
@cmarteepants The old screenshot here had tons of tasks, runs and different states.
The replacement has only 1 task -- are you ok with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3313683277
@kaxil @cmarteepants I have made the suggested changes.Kindly look into them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2372205505
##########
providers/edge3/src/airflow/providers/edge3/plugins/www/openapi-gen/requests/types.gen.ts:
##########
@@ -786,7 +786,7 @@ export type $OpenApiTs = {
/**
* Successful Response
*/
- 200: null;
Review Comment:
These are unrelated changes, could you rebase on main. The failure on main is fixed by https://github.com/apache/airflow/pull/55986
Very close, thanks for persisting @KatalKavya96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3314855341
@Kaxil I replaced dag_run_graph and dag_overview_grid with better screenshots.Please review once again.Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364299199
##########
airflow-core/docs/ui.rst:
##########
@@ -389,7 +375,6 @@ The Backfill window allows you to trigger a Dag run for past dates.
.. image:: img/ui-dark/backfill.png
:alt: Dag Trigger Window - Backfill (Dark Mode)
Review Comment:
```suggestion
:alt: Dag Trigger Window - Backfill (Dark Mode)
```
##########
airflow-core/docs/ui.rst:
##########
@@ -429,7 +414,6 @@ Shows any values pushed via ``XCom.push()`` or returned from Python functions wh
.. image:: img/ui-light/dag_run_task_instance_xcom.png
:alt: Task Instance - XCom tab (light mode)
Review Comment:
```suggestion
:alt: Task Instance - XCom tab (light mode)
```
##########
airflow-core/docs/ui.rst:
##########
@@ -376,7 +363,6 @@ The Single Run window allows you to trigger a Dag run.
.. image:: img/ui-dark/dag_trigger_window_single_run.png
:alt: Dag Trigger Window - Single Run (Dark Mode)
Review Comment:
```suggestion
:alt: Dag Trigger Window - Single Run (Dark Mode)
```
##########
airflow-core/docs/ui.rst:
##########
@@ -343,7 +331,6 @@ Provides extended metadata for the Dag Run, including:
.. image:: img/ui-light/dag_run_details.png
:alt: Dag Run - Details tab (light mode)
Review Comment:
```suggestion
:alt: Dag Run - Details tab (light mode)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "cmarteepants (via GitHub)" <gi...@apache.org>.
cmarteepants commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364333944
##########
airflow-core/docs/img/ui-dark/dag_overview_dashboard.png:
##########
Review Comment:
Yes, I'm ok with it.
##########
airflow-core/docs/img/ui-dark/dag_overview_grid.png:
##########
Review Comment:
@KatalKavya96 the example dag I gave will sporadically fail some tasks if you execute it a few tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #55876:
URL: https://github.com/apache/airflow/pull/55876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3312646733
@cmarteepants Fixed that last dag_list screenshot. I think its read to go now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364315457
##########
airflow-core/docs/img/ui-dark/dag_overview_grid.png:
##########
Review Comment:
@KatalKavya96 Could you take care of that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364447832
##########
airflow-core/docs/img/ui-dark/asset_view.png:
##########
Review Comment:
@KatalKavya96 Should do the same here. Our example dag for asset might produce lot more data than the current screenshot you have here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364449144
##########
airflow-core/docs/img/ui-dark/dag_overview_dashboard.png:
##########
Review Comment:
@KatalKavya96 This one is pending
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2371650146
##########
airflow-core/docs/img/ui-dark/branch_with_trigger.png:
##########
Review Comment:
This is showing different to before -- in the old we have highlighted a particular line of code in the dag code view (showing trigger rule being set)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3323062999
@ashb Ok , I will make the required changes and recommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364448672
##########
airflow-core/docs/img/ui-dark/dag_list.png:
##########
Review Comment:
Let's add and run more dags for this screenshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2365341689
##########
airflow-core/docs/img/ui-dark/dag_overview_grid.png:
##########
Review Comment:
@kaxil Is this one better?
<img width="456" height="655" alt="dag_overview_grid_l" src="https://github.com/user-attachments/assets/c7b62082-da48-4ec7-b5c4-7a36c02dbeba" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2371642917
##########
airflow-core/docs/img/ui-dark/dag_overview_runs.png:
##########
Review Comment:
Same with the others -- we want the same "rough" mix of states.
##########
airflow-core/docs/img/ui-dark/dag_overview_tasks.png:
##########
Review Comment:
Same with the others -- we want the same "rough" mix of states.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3324721945
@kaxil Please check the follow up PR #56000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55876:
URL: https://github.com/apache/airflow/pull/55876#discussion_r2364762219
##########
airflow-core/docs/img/ui-dark/dag_run_graph.png:
##########
Review Comment:
@KatalKavya96 This isn't dagrun yet! the image you added doesn't have state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3322712200
@kaxil I have resolved the Conflicts, I think its good to merge now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3324425617
Yes, please do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3322246983
@kaxil Sure,I will recommit in a few minutes after fixing these merge conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Docs: refresh UI Guide screenshots for Airflow 3.1.x (dark/light) [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #55876:
URL: https://github.com/apache/airflow/pull/55876#issuecomment-3313587932
@kaxil I will handle all the above listed suggestions and recommit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org