You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by Christopher Schultz <ch...@christopherschultz.net> on 2011/04/07 21:32:28 UTC

JSP Compiler swallows exceptions when removing files

All,

While reading the code for jasper.compiler.Compiler on an unrelated
errand, I noticed that the removeGeneratedFiles and
removeGeneratedClassFiles methods contain this code:

        } catch (Exception e) {
            // Remove as much as possible, ignore possible exceptions
        }

This code appears in both TC 6.0.x trunk and TC 7.0.x trunk.

This situation seems worthy of a log statement, no?

-chris

Re: JSP Compiler swallows exceptions when removing files

Posted by Filip Hanik - Dev Lists <de...@hanik.com>.

yes

On 4/7/2011 1:32 PM, Christopher Schultz wrote:
> All,
>
> While reading the code for jasper.compiler.Compiler on an unrelated
> errand, I noticed that the removeGeneratedFiles and
> removeGeneratedClassFiles methods contain this code:
>
>          } catch (Exception e) {
>              // Remove as much as possible, ignore possible exceptions
>          }
>
> This code appears in both TC 6.0.x trunk and TC 7.0.x trunk.
>
> This situation seems worthy of a log statement, no?
>
> -chris
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org