You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/03/09 16:05:47 UTC
[Bug 6369] New: win32: spamd childs do not receive SIGINT
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6369
Summary: win32: spamd childs do not receive SIGINT
Product: Spamassassin
Version: 3.3.0
Platform: All
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P5
Component: spamc/spamd
AssignedTo: dev@spamassassin.apache.org
ReportedBy: lemke@jam-software.com
Created an attachment (id=4701)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4701)
SpamdForkScaling win32 SIGINT patch
There is an issue in SpamdForkScaling due which spamd and its childs do not
receive their proper int signal.
When spamd tries to kill a child, he recently spawned for heavier load it gets
flagged as probably dead ("K") but doesn’t react any further. The attached
patch was already used in SAWin32. I tested it with a mail server which
processes several hundred mails a day and it’s working stable so far.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6369] [review] win32: spamd childs do not receive SIGINT
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6369
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 3 votes |needs 1 vote
--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2010-03-11 18:38:28 UTC ---
> Would suggest the following minor change for readability purposes.
Sure.
+1
I'm ok with the change: it doesn't affect Unix platforms, and as for
windows: it can't be more broken than it already was, so if Daniel
claims it works (better), I'll take him by the word.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6369] [review] win32: spamd childs do not receive SIGINT
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6369
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
--- Comment #1 from Kevin A. McGrail <km...@pccc.com> 2010-03-11 17:46:33 UTC ---
I don't like the way the sleep 2 is written inside the if loop
Would suggest the following minor change for readability purposes.
if (Mail::SpamAssassin::Util::am_running_on_windows()) {
sleep 2; # Need this on win32 so that a child can get a signal
}
Otherwise, I'm +1 though I'm not testing the code on a win32 system.
KAM
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6369] [review] win32: spamd childs do not receive SIGINT
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6369
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|win32: spamd childs do not |[review] win32: spamd
|receive SIGINT |childs do not receive
| |SIGINT
Status Whiteboard| |needs 3 votes
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6369] win32: spamd childs do not receive SIGINT
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6369
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P2
Target Milestone|Undefined |3.3.1
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6369] [review] win32: spamd childs do not receive SIGINT
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6369
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2010-03-11 20:23:03 UTC ---
trunk:
Bug 6369: win32: spamd childs do not receive SIGINT
Sending lib/Mail/SpamAssassin/SpamdForkScaling.pm
Committed revision 922004.
3.3:
Bug 6369: win32: spamd childs do not receive SIGINT
Sending lib/Mail/SpamAssassin/SpamdForkScaling.pm
Committed revision 922008.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6369] [review] win32: spamd childs do not receive SIGINT
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6369
Warren Togami <wa...@togami.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |ready for commit
--- Comment #3 from Warren Togami <wa...@togami.com> 2010-03-11 19:50:59 UTC ---
+1 to the improved readability patch
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.