You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/29 13:42:22 UTC
[GitHub] [iceberg] gaborkaszab commented on pull request #5159: Drop table's root folder if the table owns it
gaborkaszab commented on PR #5159:
URL: https://github.com/apache/iceberg/pull/5159#issuecomment-1169997303
@pvary I uploaded a new patch where I got rid of the FileIO changes. In turn I had to check the type for 'fileIO' member of HiveCatalog so that I can call deleteRecusrive()
If you are not a fan of this approach we can simply call deleteFile() for data/, metadata/ and the table's location but this seems error-prone for me as we can't really guarantee that those 2 folders will be the only content of a table's directory. A recursive delete seems simpler and error-proof.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org