[jira] [Commented] (RYA-392) Temporal Difference Function

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RYA-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191856#comment-16191856 ] 

ASF GitHub Bot commented on RYA-392:
------------------------------------

GitHub user meiercaleb opened a pull request:

    https://github.com/apache/incubator-rya/pull/237

    RYA-392-Datetime-Within

    <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
    
      http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
    ## Description
    Added a Function DateTimeWithinPeriod to determine whether two datetimes were within a
    specified period of time of one another.
    
    ### Tests
    Added unit tests to test the Function and added integration tests to verify that the Function
    is correctly utilized during query evaluation.
    
    ### Links
    [Jira](https://issues.apache.org/jira/browse/RYA-392)
    
    ### Checklist
    - [ ] Code Review
    - [x] Squash Commits
    
    #### People To Reivew
    @jdasch @kchilton2 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/meiercaleb/incubator-rya RYA-392

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #237
    
----
commit e82688730e94140c9a5c2e83959c1e0f97af7a24
Author: Caleb Meier <ca...@parsons.com>
Date:   2017-10-04T19:06:55Z

    RYA-392-Datetime-Within

----


> Temporal Difference Function
> ----------------------------
>
>                 Key: RYA-392
>                 URL: https://issues.apache.org/jira/browse/RYA-392
>             Project: Rya
>          Issue Type: New Feature
>    Affects Versions: 3.2.11
>            Reporter: Caleb Meier
>            Assignee: Caleb Meier
>
> Currently Rya does not provide a Function that determines whether two temporal literals are within a given period of time of one another.  This is extremely useful for filtering on query results that occurred within a fixed period of time of a given instant.  Currently, if one attempts to form the following filter Filter(?time1 - ?time2 < "24"^^xsd:hour), an exception will be thrown if ?time1 and ?time2 are date time literals.  I propose implementing a Function that takes in two temporal literals, an integer and a time unit and determines whether the date times are within the prescribed period of one another.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)