[GitHub] srdo commented on a change in pull request #2936: STORM-3312: Upgrade Guava to latest version where possible

[GitBox <gi...@apache.org>]

srdo commented on a change in pull request #2936: STORM-3312: Upgrade Guava to latest version where possible
URL: https://github.com/apache/storm/pull/2936#discussion_r254886038
 
 

 ##########
 File path: examples/storm-hbase-examples/pom.xml
 ##########
 @@ -26,6 +26,11 @@
     </parent>
 
     <artifactId>storm-hbase-examples</artifactId>
+    
+    <properties>
+        <!-- Required downgrade by hbase-client 1.4.4 -->
 
 Review comment:
   It's been a while, so I might be misremembering, but I believe I used `mvn dependency:tree` and checked whether each module had any dependencies that used Guava less than version 21.0. According to the Guava README, that was the last version to remove a non-beta API (https://github.com/google/guava#important-warnings point 2). My understanding is that Guava versions are backwards compatible starting at 21.0.
   
   The downgrade may not actually be required, but I don't want to do the testing required to figure that out. At some point someone will upgrade the direct dependency, and then we can remove the downgrade.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services