You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/12/20 06:29:35 UTC
Review Request: Refactored protobuf read() to return the protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8696/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This is a cleaner way to expose protobuf reads.
Simplifies the signature and the state space of possible results returning from the read.
Diffs
-----
src/tests/protobuf_io_tests.cpp 979efac0f28c3d361f5c347f15933d89d9356bc9
third_party/libprocess/include/stout/protobuf.hpp d2b5daedb878fcf04bc38ba912ffc0ca9a930729
Diff: https://reviews.apache.org/r/8696/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Refactored protobuf read() to return the protobuf.
Posted by Ben Mahler <be...@gmail.com>.
> On Jan. 3, 2013, 8:36 p.m., Vinod Kone wrote:
> > third_party/libprocess/include/stout/protobuf.hpp, line 107
> > <https://reviews.apache.org/r/8696/diff/1/?file=241576#file241576line107>
> >
> > doesn't read right.
> >
> > how about:
> >
> > size byes. Hitting EOF early is a good indicator of corruption.
Fixed in previous review: https://reviews.apache.org/r/8695
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8696/#review15053
-----------------------------------------------------------
On Dec. 20, 2012, 5:29 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8696/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2012, 5:29 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This is a cleaner way to expose protobuf reads.
>
> Simplifies the signature and the state space of possible results returning from the read.
>
>
> Diffs
> -----
>
> src/tests/protobuf_io_tests.cpp 979efac0f28c3d361f5c347f15933d89d9356bc9
> third_party/libprocess/include/stout/protobuf.hpp d2b5daedb878fcf04bc38ba912ffc0ca9a930729
>
> Diff: https://reviews.apache.org/r/8696/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Refactored protobuf read() to return the protobuf.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8696/#review15053
-----------------------------------------------------------
Ship it!
ty
third_party/libprocess/include/stout/protobuf.hpp
<https://reviews.apache.org/r/8696/#comment32611>
doesn't read right.
how about:
size byes. Hitting EOF early is a good indicator of corruption.
- Vinod Kone
On Dec. 20, 2012, 5:29 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8696/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2012, 5:29 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This is a cleaner way to expose protobuf reads.
>
> Simplifies the signature and the state space of possible results returning from the read.
>
>
> Diffs
> -----
>
> src/tests/protobuf_io_tests.cpp 979efac0f28c3d361f5c347f15933d89d9356bc9
> third_party/libprocess/include/stout/protobuf.hpp d2b5daedb878fcf04bc38ba912ffc0ca9a930729
>
> Diff: https://reviews.apache.org/r/8696/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Refactored protobuf read() to return the protobuf.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8696/#review15877
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 16, 2013, 12:48 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8696/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2013, 12:48 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This is a cleaner way to expose protobuf reads.
>
> Simplifies the signature and the state space of possible results returning from the read.
>
>
> Diffs
> -----
>
> src/tests/protobuf_io_tests.cpp 979efac0f28c3d361f5c347f15933d89d9356bc9
> third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0
>
> Diff: https://reviews.apache.org/r/8696/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Refactored protobuf read() to return the protobuf.
Posted by Ben Mahler <be...@gmail.com>.
> On Feb. 5, 2013, 6:58 a.m., Vinod Kone wrote:
> > third_party/libprocess/include/stout/protobuf.hpp, line 159
> > <https://reviews.apache.org/r/8696/diff/2/?file=248649#file248649line159>
> >
> > found this bug, when I rebased slave recovery off the latest trunk.
> >
> > s/bool/T/
Thanks for finding this, I'll send out a review with the fix.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8696/#review16084
-----------------------------------------------------------
On Jan. 16, 2013, 12:48 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8696/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2013, 12:48 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This is a cleaner way to expose protobuf reads.
>
> Simplifies the signature and the state space of possible results returning from the read.
>
>
> Diffs
> -----
>
> src/tests/protobuf_io_tests.cpp 979efac0f28c3d361f5c347f15933d89d9356bc9
> third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0
>
> Diff: https://reviews.apache.org/r/8696/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Refactored protobuf read() to return the protobuf.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8696/#review16084
-----------------------------------------------------------
third_party/libprocess/include/stout/protobuf.hpp
<https://reviews.apache.org/r/8696/#comment34402>
found this bug, when I rebased slave recovery off the latest trunk.
s/bool/T/
- Vinod Kone
On Jan. 16, 2013, 12:48 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8696/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2013, 12:48 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This is a cleaner way to expose protobuf reads.
>
> Simplifies the signature and the state space of possible results returning from the read.
>
>
> Diffs
> -----
>
> src/tests/protobuf_io_tests.cpp 979efac0f28c3d361f5c347f15933d89d9356bc9
> third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0
>
> Diff: https://reviews.apache.org/r/8696/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Refactored protobuf read() to return the protobuf.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8696/
-----------------------------------------------------------
(Updated Jan. 16, 2013, 12:48 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased off trunk.
Description
-------
This is a cleaner way to expose protobuf reads.
Simplifies the signature and the state space of possible results returning from the read.
Diffs (updated)
-----
src/tests/protobuf_io_tests.cpp 979efac0f28c3d361f5c347f15933d89d9356bc9
third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0
Diff: https://reviews.apache.org/r/8696/diff/
Testing
-------
make check
Thanks,
Ben Mahler