You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/06/13 01:52:01 UTC

Re: Review Request 35406: RANGER-550 Hive plugin: Add audit logging support for metadata queries that have filtering support from hive

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35406/#review87788
-----------------------------------------------------------

Ship it!


Ship It!

- Madhan Neethiraj


On June 12, 2015, 11:11 p.m., Alok Lal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35406/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 11:11 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-550
>     https://issues.apache.org/jira/browse/RANGER-550
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Hive has added support that now let's Ranger log correct allowed/denied audit messages for show databases and show tables command in addition to filtering being done.
> - Removed code that was added to deal with Hive bug
> 
> 
> Diffs
> -----
> 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAccessRequest.java 1f7ae4d 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java 2675a67 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 1df1af4 
> 
> Diff: https://reviews.apache.org/r/35406/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.  Database level checking of audit message for right value being logged to following columns to ensure that they would let and admin figure out what user action was being attempted:
> - Action
> - access_type
> - request_data
> 
> 
> Thanks,
> 
> Alok Lal
> 
>