You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xalan.apache.org by mi...@apache.org on 2006/10/31 05:41:37 UTC

svn commit: r469368 - in /xalan/java/trunk/src/org/apache/xpath/objects: XBoolean.java XNodeSet.java XNodeSetForDOM.java XNumber.java XObject.java XRTreeFrag.java

Author: minchau
Date: Mon Oct 30 20:41:36 2006
New Revision: 469368

URL: http://svn.apache.org/viewvc?view=rev&rev=469368
Log:
Patch for XALANJ-2204

Modified:
    xalan/java/trunk/src/org/apache/xpath/objects/XBoolean.java
    xalan/java/trunk/src/org/apache/xpath/objects/XNodeSet.java
    xalan/java/trunk/src/org/apache/xpath/objects/XNodeSetForDOM.java
    xalan/java/trunk/src/org/apache/xpath/objects/XNumber.java
    xalan/java/trunk/src/org/apache/xpath/objects/XObject.java
    xalan/java/trunk/src/org/apache/xpath/objects/XRTreeFrag.java

Modified: xalan/java/trunk/src/org/apache/xpath/objects/XBoolean.java
URL: http://svn.apache.org/viewvc/xalan/java/trunk/src/org/apache/xpath/objects/XBoolean.java?view=diff&rev=469368&r1=469367&r2=469368
==============================================================================
--- xalan/java/trunk/src/org/apache/xpath/objects/XBoolean.java (original)
+++ xalan/java/trunk/src/org/apache/xpath/objects/XBoolean.java Mon Oct 30 20:41:36 2006
@@ -69,7 +69,7 @@
     super();
 
     m_val = b.booleanValue();
-    m_obj = b;
+    setObject(b);
   }
 
 
@@ -133,7 +133,7 @@
   public Object object()
   {
     if(null == m_obj)
-      m_obj = new Boolean(m_val);
+      setObject(new Boolean(m_val));
     return m_obj;
   }
 

Modified: xalan/java/trunk/src/org/apache/xpath/objects/XNodeSet.java
URL: http://svn.apache.org/viewvc/xalan/java/trunk/src/org/apache/xpath/objects/XNodeSet.java?view=diff&rev=469368&r1=469367&r2=469368
==============================================================================
--- xalan/java/trunk/src/org/apache/xpath/objects/XNodeSet.java (original)
+++ xalan/java/trunk/src/org/apache/xpath/objects/XNodeSet.java Mon Oct 30 20:41:36 2006
@@ -55,12 +55,17 @@
   	super();
   	if(val instanceof XNodeSet)
   	{
-	    setIter(((XNodeSet)val).m_iter);
-	    m_dtmMgr = ((XNodeSet)val).m_dtmMgr;
-	    m_last = ((XNodeSet)val).m_last;
-	    if(!((XNodeSet)val).hasCache())
-	    	((XNodeSet)val).setShouldCacheNodes(true);
-	    m_obj = ((XNodeSet)val).m_obj;
+        final XNodeSet nodeSet = (XNodeSet) val;
+	    setIter(nodeSet.m_iter);
+	    m_dtmMgr = nodeSet.m_dtmMgr;
+	    m_last = nodeSet.m_last;
+        // First make sure the DTMIterator val has a cache,
+        // so if it doesn't have one, make one.
+	    if(!nodeSet.hasCache())
+	        nodeSet.setShouldCacheNodes(true);
+        
+        // Get the cache from val and use it ourselves (we share it).
+	    setObject(nodeSet.getIteratorCache());
   	}
   	else
     	setIter(val);
@@ -79,7 +84,7 @@
     m_last = val.m_last;
     if(!val.hasCache())
     	val.setShouldCacheNodes(true);
-    m_obj = val.m_obj;
+    setObject(val.m_obj);
   }
 
 
@@ -428,7 +433,7 @@
     else
     {
       mnl = new NodeSetDTM(iter());
-      m_obj = mnl;
+      setObject(mnl);
       setCurrentPos(0);
     }
 

Modified: xalan/java/trunk/src/org/apache/xpath/objects/XNodeSetForDOM.java
URL: http://svn.apache.org/viewvc/xalan/java/trunk/src/org/apache/xpath/objects/XNodeSetForDOM.java?view=diff&rev=469368&r1=469367&r2=469368
==============================================================================
--- xalan/java/trunk/src/org/apache/xpath/objects/XNodeSetForDOM.java (original)
+++ xalan/java/trunk/src/org/apache/xpath/objects/XNodeSetForDOM.java Mon Oct 30 20:41:36 2006
@@ -42,7 +42,7 @@
     m_dtmMgr = dtmMgr;
     m_origObj = node;
     int dtmHandle = dtmMgr.getDTMHandleFromNode(node);
-    m_obj = new NodeSetDTM(dtmMgr);
+    setObject(new NodeSetDTM(dtmMgr));
     ((NodeSetDTM) m_obj).addNode(dtmHandle);
   }
   
@@ -69,7 +69,7 @@
     // m_obj=new org.apache.xpath.NodeSetDTM(nodeList, xctxt);
     org.apache.xpath.NodeSetDTM nsdtm=new org.apache.xpath.NodeSetDTM(nodeList, xctxt);
     m_last=nsdtm.getLength();
-    m_obj = nsdtm;   
+    setObject(nsdtm);   
   }
 
   public XNodeSetForDOM(NodeIterator nodeIter, XPathContext xctxt)
@@ -83,7 +83,7 @@
     // m_obj = new org.apache.xpath.NodeSetDTM(nodeIter, xctxt);
     org.apache.xpath.NodeSetDTM nsdtm=new org.apache.xpath.NodeSetDTM(nodeIter, xctxt);
     m_last=nsdtm.getLength();
-    m_obj = nsdtm;   
+    setObject(nsdtm);   
   }
   
   /**

Modified: xalan/java/trunk/src/org/apache/xpath/objects/XNumber.java
URL: http://svn.apache.org/viewvc/xalan/java/trunk/src/org/apache/xpath/objects/XNumber.java?view=diff&rev=469368&r1=469367&r2=469368
==============================================================================
--- xalan/java/trunk/src/org/apache/xpath/objects/XNumber.java (original)
+++ xalan/java/trunk/src/org/apache/xpath/objects/XNumber.java Mon Oct 30 20:41:36 2006
@@ -60,7 +60,7 @@
     super();
 
     m_val = num.doubleValue();
-    m_obj = num;
+    setObject(num);
   }
 
   /**
@@ -377,7 +377,7 @@
   public Object object()
   {
     if(null == m_obj)
-      m_obj = new Double(m_val);
+      setObject(new Double(m_val));
     return m_obj;
   }
 

Modified: xalan/java/trunk/src/org/apache/xpath/objects/XObject.java
URL: http://svn.apache.org/viewvc/xalan/java/trunk/src/org/apache/xpath/objects/XObject.java?view=diff&rev=469368&r1=469367&r2=469368
==============================================================================
--- xalan/java/trunk/src/org/apache/xpath/objects/XObject.java (original)
+++ xalan/java/trunk/src/org/apache/xpath/objects/XObject.java Mon Oct 30 20:41:36 2006
@@ -68,7 +68,11 @@
    */
   public XObject(Object obj)
   {
-    m_obj = obj;
+    setObject(obj);
+  }
+  
+  protected void setObject(Object obj) {
+      m_obj = obj;
   }
 
   /**
@@ -119,7 +123,7 @@
       allowDetachToRelease(true);
       detach();
 
-      m_obj = null;
+      setObject(null);
     }
   }
   

Modified: xalan/java/trunk/src/org/apache/xpath/objects/XRTreeFrag.java
URL: http://svn.apache.org/viewvc/xalan/java/trunk/src/org/apache/xpath/objects/XRTreeFrag.java?view=diff&rev=469368&r1=469367&r2=469368
==============================================================================
--- xalan/java/trunk/src/org/apache/xpath/objects/XRTreeFrag.java (original)
+++ xalan/java/trunk/src/org/apache/xpath/objects/XRTreeFrag.java Mon Oct 30 20:41:36 2006
@@ -118,7 +118,7 @@
   public void detach(){
     if(m_allowRelease){
     	m_DTMXRTreeFrag.destruct();
-      m_obj = null;
+      setObject(null);
     }
   }
   



---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-cvs-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-cvs-help@xml.apache.org