You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/16 20:13:19 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #5321: Remove storage scope validation on KVM live migration
GutoVeronezi opened a new pull request #5321:
URL: https://github.com/apache/cloudstack/pull/5321
### Description
In ACS, primary storages have two scopes, `ZONE` and `CLUSTER`. In KVM, when we are migrating a volume between any source storage to a non managed NFS storage, ACS validates if the destination storage is `CLUSTER` scoped and cancels the migration if it isn't. However, these scopes are just logical limitations created by ACS, they don't affect KVM.
This PR intends to remove this logical limitation created by ACS.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
I added unit tests and tested locally, in a test lab.
1. I created a VM;
2. I tried to migrate a volume to a `ZONE` scoped storage;
3. Before applying this patch, it threw an exception, after applying, it was migrated;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5321: Remove storage scope validation on KVM live migration
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5321:
URL: https://github.com/apache/cloudstack/pull/5321#issuecomment-902388793
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5321: Remove storage scope validation on KVM live migration
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5321:
URL: https://github.com/apache/cloudstack/pull/5321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5321: Remove storage scope validation on KVM live migration
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5321:
URL: https://github.com/apache/cloudstack/pull/5321#issuecomment-902370052
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5321: Remove storage scope validation on KVM live migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5321:
URL: https://github.com/apache/cloudstack/pull/5321#issuecomment-902370388
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5321: Remove storage scope validation on KVM live migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5321:
URL: https://github.com/apache/cloudstack/pull/5321#issuecomment-902389092
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5321: Remove storage scope validation on KVM live migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5321:
URL: https://github.com/apache/cloudstack/pull/5321#issuecomment-902653720
<b>Trillian test result (tid-1729)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32803 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5321-t1729-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5321: Remove storage scope validation on KVM live migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5321:
URL: https://github.com/apache/cloudstack/pull/5321#issuecomment-902381987
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org