You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/04/27 04:18:40 UTC
[GitHub] incubator-guacamole-server pull request #88: GUACAMOLE-278: Add support for ...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/88
GUACAMOLE-278: Add support for xterm's bright SGR colors (90-97 and 100-107).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-server bright-sgr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-server/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit 2a91e2ff2debebf55f3a50805006cf6e462e30ab
Author: Michael Jumper <mj...@apache.org>
Date: 2017-04-24T00:22:47Z
GUACAMOLE-278: Add support for xterm's bright SGR colors (90-97 and 100-107).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-server pull request #88: GUACAMOLE-278: Add support for ...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/88#discussion_r113616654
--- Diff: src/terminal/terminal_handlers.c ---
@@ -967,6 +967,18 @@ int guac_terminal_csi(guac_terminal* term, unsigned char c) {
term->current_attributes.background =
term->default_char.attributes.background;
+ /* Intense foreground */
+ else if (value >= 90 && value <= 97)
--- End diff --
:sob:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-server pull request #88: GUACAMOLE-278: Add support for ...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/88#discussion_r113616225
--- Diff: src/terminal/terminal_handlers.c ---
@@ -967,6 +967,18 @@ int guac_terminal_csi(guac_terminal* term, unsigned char c) {
term->current_attributes.background =
term->default_char.attributes.background;
+ /* Intense foreground */
+ else if (value >= 90 && value <= 97)
--- End diff --
You probably know what I'm going to say here :stuck_out_tongue: :memo:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-server pull request #88: GUACAMOLE-278: Add support for ...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/88#discussion_r113616296
--- Diff: src/terminal/terminal_handlers.c ---
@@ -967,6 +967,18 @@ int guac_terminal_csi(guac_terminal* term, unsigned char c) {
term->current_attributes.background =
term->default_char.attributes.background;
+ /* Intense foreground */
+ else if (value >= 90 && value <= 97)
--- End diff --
But yeah, some constants would be nice in the future...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-server pull request #88: GUACAMOLE-278: Add support for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-server/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---