[Impala-ASF-CR] Support centos:7 for test-with-docker.

["Joe McDonnell (Code Review)" <ge...@cloudera.org>]

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12139 )

Change subject: Support centos:7 for test-with-docker.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12139/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/12139/1/bin/bootstrap_system.sh@253
PS1, Line 253: redhat6 sudo service ntpd start || grep docker /proc/1/cgroup
Do we need "redhat7 notindocker sudo service ntpd start"?

Nit: Does it make sense to convert these existing lines to use "notindocker" rather than the "|| grep docker /proc/1/cgroup"?


http://gerrit.cloudera.org:8080/#/c/12139/1/docker/entrypoint.sh
File docker/entrypoint.sh:

http://gerrit.cloudera.org:8080/#/c/12139/1/docker/entrypoint.sh@151
PS1, Line 151: sudo /usr/sbin/sshd
Curious: The bootstrap has this:
sudo /usr/bin/ssh-keygen -A
Do we need this here?



-- 
To view, visit http://gerrit.cloudera.org:8080/12139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7577949b6eaaa2239bcf0fadf64e1490c2106b08
Gerrit-Change-Number: 12139
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 00:53:26 +0000
Gerrit-HasComments: Yes