[GitHub] [servicecomb-java-chassis] ZihangJiao commented on a change in pull request #1302: [SCB-1451] Printing the service information on the log

[GitBox <gi...@apache.org>]

ZihangJiao commented on a change in pull request #1302: [SCB-1451] Printing the service information on the log
URL: https://github.com/apache/servicecomb-java-chassis/pull/1302#discussion_r316549955
 
 

 ##########
 File path: core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
 ##########
 @@ -223,10 +228,22 @@ public synchronized void init() {
         }
         status = SCBStatus.FAILED;
         throw new IllegalStateException("ServiceComb init failed.", e);
+      } finally {
+        ServiceInfoPrinter();
       }
     }
   }
 
+  private void ServiceInfoPrinter() {
 
 Review comment:
   The name of the method have been changed to printServiceInfo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services