You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/05 03:43:19 UTC
[GitHub] [dubbo-go] aliiohs opened a new pull request #502: Feature/add comment for directory
aliiohs opened a new pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#discussion_r420604581
##########
File path: registry/directory/directory.go
##########
@@ -334,6 +338,7 @@ func (l *consumerConfigurationListener) addNotifyListener(listener registry.Noti
l.listeners = append(l.listeners, listener)
}
+// Process handle events and update Invokers
Review comment:
it should be : Process handles events from xxx and updates Invokers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#issuecomment-631542673
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=h1) Report
> Merging [#502](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8e9c2b2abb4c97643f9a6db6f285db571fd03bf8&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #502 +/- ##
===========================================
+ Coverage 66.40% 66.52% +0.11%
===========================================
Files 184 184
Lines 9723 9723
===========================================
+ Hits 6457 6468 +11
+ Misses 2626 2615 -11
Partials 640 640
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `81.21% <ø> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.24% <0.00%> (+0.94%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `81.27% <0.00%> (+4.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=footer). Last update [ea81831...d1e5463](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#issuecomment-623835361
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=h1) Report
> Merging [#502](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/8a3c02c9b7737a12712451b16a3cdc8ce46a5c7d&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 67.12% 66.83% -0.29%
==========================================
Files 174 174
Lines 9261 9261
==========================================
- Hits 6216 6190 -26
- Misses 2441 2461 +20
- Partials 604 610 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `76.64% <0.00%> (-3.60%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `72.50% <0.00%> (-5.00%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.71% <0.00%> (-4.57%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0.00%> (-3.39%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0.00%> (-2.44%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `72.46% <0.00%> (+10.14%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=footer). Last update [8a3c02c...fc6bdfa](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#issuecomment-631542673
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=h1) Report
> Merging [#502](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8e9c2b2abb4c97643f9a6db6f285db571fd03bf8&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #502 +/- ##
===========================================
+ Coverage 66.40% 66.77% +0.36%
===========================================
Files 184 174 -10
Lines 9723 9261 -462
===========================================
- Hits 6457 6184 -273
+ Misses 2626 2465 -161
+ Partials 640 612 -28
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `80.23% <ø> (-0.98%)` | :arrow_down: |
| [cluster/router/condition/router\_rule.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL3JvdXRlcl9ydWxlLmdv) | `77.77% <0.00%> (-6.84%)` | :arrow_down: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40.00% <0.00%> (-5.84%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `72.50% <0.00%> (-5.00%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0.00%> (-2.44%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `56.91% <0.00%> (-2.01%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.06% <0.00%> (-0.52%)` | :arrow_down: |
| [protocol/rest/rest\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X3Byb3RvY29sLmdv) | `75.34% <0.00%> (-0.34%)` | :arrow_down: |
| ... and [52 more](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=footer). Last update [ea81831...3afc4ba](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#issuecomment-623835361
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=h1) Report
> Merging [#502](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/8a3c02c9b7737a12712451b16a3cdc8ce46a5c7d&el=desc) will **decrease** coverage by `0.43%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 67.20% 66.77% -0.44%
==========================================
Files 174 174
Lines 9261 9261
==========================================
- Hits 6224 6184 -40
- Misses 2432 2465 +33
- Partials 605 612 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `80.23% <ø> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `72.50% <0.00%> (-5.00%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.71% <0.00%> (-4.57%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0.00%> (-3.39%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0.00%> (-2.44%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=footer). Last update [8a3c02c...f87a292](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#issuecomment-631542673
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=h1) Report
> Merging [#502](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8e9c2b2abb4c97643f9a6db6f285db571fd03bf8&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #502 +/- ##
===========================================
+ Coverage 66.40% 66.57% +0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
+ Hits 6457 6473 +16
+ Misses 2626 2608 -18
- Partials 640 642 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `81.21% <ø> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `60.21% <0.00%> (+2.68%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `81.27% <0.00%> (+4.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=footer). Last update [ea81831...d1e5463](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#issuecomment-631542673
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=h1) Report
> Merging [#502](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8e9c2b2abb4c97643f9a6db6f285db571fd03bf8&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #502 +/- ##
===========================================
+ Coverage 66.40% 66.50% +0.09%
===========================================
Files 184 184
Lines 9723 9723
===========================================
+ Hits 6457 6466 +9
+ Misses 2626 2616 -10
- Partials 640 641 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `81.21% <ø> (ø)` | |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `81.27% <0.00%> (+4.56%)` | :arrow_up: |
| [filter/filter\_impl/metrics\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL21ldHJpY3NfZmlsdGVyLmdv) | `100.00% <0.00%> (+13.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=footer). Last update [ea81831...71517ef](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#issuecomment-623835361
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=h1) Report
> Merging [#502](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/8a3c02c9b7737a12712451b16a3cdc8ce46a5c7d&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 67.12% 66.83% -0.29%
==========================================
Files 174 174
Lines 9261 9261
==========================================
- Hits 6216 6190 -26
- Misses 2441 2463 +22
- Partials 604 608 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `76.64% <0.00%> (-3.60%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `72.50% <0.00%> (-5.00%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.71% <0.00%> (-4.57%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0.00%> (-3.39%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0.00%> (-2.44%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.24% <0.00%> (+0.94%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=footer). Last update [8a3c02c...2264cda](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#issuecomment-623835361
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=h1) Report
> Merging [#502](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/8a3c02c9b7737a12712451b16a3cdc8ce46a5c7d&el=desc) will **decrease** coverage by `0.36%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 67.20% 66.83% -0.37%
==========================================
Files 174 174
Lines 9261 9261
==========================================
- Hits 6224 6190 -34
- Misses 2432 2461 +29
- Partials 605 610 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `76.64% <0.00%> (-3.60%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `72.50% <0.00%> (-5.00%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.71% <0.00%> (-4.57%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0.00%> (-3.39%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0.00%> (-2.44%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=footer). Last update [8a3c02c...f87a292](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
hxmhlt commented on a change in pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#discussion_r422660806
##########
File path: registry/directory/directory.go
##########
@@ -42,12 +42,12 @@ import (
"github.com/apache/dubbo-go/remoting"
)
-// Options ...
+// Options Option is configuration related struct of serviceTTL
type Options struct {
Review comment:
The comment must be a complete sentence.
##########
File path: registry/directory/directory.go
##########
@@ -42,12 +42,12 @@ import (
"github.com/apache/dubbo-go/remoting"
)
-// Options ...
+// Options Option is configuration related struct of serviceTTL
type Options struct {
Review comment:
No `Options Option is configuration related struct of serviceTTL` but `Options is configuration related struct of serviceTTL`
##########
File path: registry/directory/directory.go
##########
@@ -42,12 +42,12 @@ import (
"github.com/apache/dubbo-go/remoting"
)
-// Options ...
+// Options Option is configuration related struct of serviceTTL
type Options struct {
serviceTTL time.Duration
}
-// Option ...
+// Option function of handling Options
type Option func(*Options)
Review comment:
Option function of handling Options => Option will define a function of handling Options.
##########
File path: registry/directory/directory.go
##########
@@ -66,7 +66,7 @@ type registryDirectory struct {
forbidden atomic.Bool
}
-// NewRegistryDirectory ...
+// NewRegistryDirectory Create a new RegistryDirectory
func NewRegistryDirectory(url *common.URL, registry registry.Registry, opts ...Option) (*registryDirectory, error) {
Review comment:
NewRegistryDirectory Create a new RegistryDirectory => NewRegistryDirectory will create a new RegistryDirectory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#issuecomment-631542673
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=h1) Report
> Merging [#502](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8e9c2b2abb4c97643f9a6db6f285db571fd03bf8&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #502 +/- ##
===========================================
+ Coverage 66.40% 66.77% +0.36%
===========================================
Files 184 174 -10
Lines 9723 9261 -462
===========================================
- Hits 6457 6184 -273
+ Misses 2626 2465 -161
+ Partials 640 612 -28
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `80.23% <ø> (-0.98%)` | :arrow_down: |
| [cluster/router/condition/router\_rule.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL3JvdXRlcl9ydWxlLmdv) | `77.77% <0.00%> (-6.84%)` | :arrow_down: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40.00% <0.00%> (-5.84%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `72.50% <0.00%> (-5.00%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0.00%> (-2.44%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `56.91% <0.00%> (-2.01%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.06% <0.00%> (-0.52%)` | :arrow_down: |
| [protocol/rest/rest\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X3Byb3RvY29sLmdv) | `75.34% <0.00%> (-0.34%)` | :arrow_down: |
| ... and [52 more](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=footer). Last update [ea81831...71517ef](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx merged pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
zouyx merged pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#issuecomment-631542673
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=h1) Report
> Merging [#502](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8e9c2b2abb4c97643f9a6db6f285db571fd03bf8&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #502 +/- ##
===========================================
+ Coverage 66.40% 66.57% +0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
+ Hits 6457 6473 +16
+ Misses 2626 2608 -18
- Partials 640 642 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `81.21% <ø> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `60.21% <0.00%> (+2.68%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/502/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `81.27% <0.00%> (+4.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=footer). Last update [ea81831...71517ef](https://codecov.io/gh/apache/dubbo-go/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#discussion_r421900420
##########
File path: registry/directory/directory.go
##########
@@ -42,12 +42,12 @@ import (
"github.com/apache/dubbo-go/remoting"
)
-// Options ...
+// Options Option is configuration related struct of serviceTTL
type Options struct {
Review comment:
what abount change to `Option`?
##########
File path: registry/directory/directory.go
##########
@@ -42,12 +42,12 @@ import (
"github.com/apache/dubbo-go/remoting"
)
-// Options ...
+// Options Option is configuration related struct of serviceTTL
type Options struct {
serviceTTL time.Duration
}
-// Option ...
+// Option function of handling Options
type Option func(*Options)
Review comment:
what abount change to `OptionHandler` ?
##########
File path: registry/directory/directory.go
##########
@@ -90,18 +90,19 @@ func NewRegistryDirectory(url *common.URL, registry registry.Registry, opts ...O
return dir, nil
}
-//subscribe from registry
+// Subscribe subscribe from registry
Review comment:
```suggestion
// Subscribe from registry
```
##########
File path: registry/directory/directory.go
##########
@@ -256,7 +257,8 @@ func (dir *registryDirectory) List(invocation protocol.Invocation) []protocol.In
return routerChain.Route(invokers, dir.cacheOriginUrl, invocation)
}
-func (dir *registryDirectory) IsAvailable() bool {
+// IsAvailable whether the directory is available
+func (dir *registryDirectory) IsAvailableAvailable() bool {
Review comment:
why `IsAvailableAvailable`.........
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] flycash commented on pull request #502: Feature/add comment for directory
Posted by GitBox <gi...@apache.org>.
flycash commented on pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#issuecomment-629780084
Please resolve conflict
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org