[GitHub] cloudstack pull request #1666: CLOUDSTACK-9480: Egress Firewall: Incorrect u...

[jayapalu <gi...@git.apache.org>]

Github user jayapalu commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1666#discussion_r77116561
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
    @@ -145,40 +145,41 @@ def add_rule(self, cidr):
                 logging.debug("Current ACL IP direction is ==> %s", self.direction)
                 if self.direction == 'egress':
                     self.fw.append(["filter", "", " -A FW_OUTBOUND -j FW_EGRESS_RULES"])
    +                fwr = " -I FW_EGRESS_RULES"
    +
    +                #In case we have a default rule (accept all or drop all), we have to evaluate the action again.
    +                if self.rule['cidr'] == ['0.0.0.0/0']:
    --- End diff --
    
    Here the default rule when egress policy is true is identified using the cidr '0.0.0.0/0'. What if we configure a egress rule  (after the network is up ) with cidr '0.0.0.0/0' (ex: cidr 0.0.0.0/0, tcp, 22 egress policy on network:true)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---