You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Duncan Grant <no...@github.com> on 2017/08/24 14:20:44 UTC
[jclouds/jclouds-labs] Cleanup extraneous (#409)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/409
-- Commit Summary --
* Cleanup extraneous resources
-- File Changes --
M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/AzureComputeService.java (27)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/409.patch
https://github.com/jclouds/jclouds-labs/pull/409.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409
Re: [jclouds/jclouds-labs] Cleanup extraneous (#409)
Posted by Andrea Turli <no...@github.com>.
hi @duncangrant thanks for that.
Could you please clarify the problem it is trying to solve? Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#issuecomment-324652819
Re: [jclouds/jclouds-labs] Cleanup extraneous (#409)
Posted by Duncan Grant <no...@github.com>.
I've run the AzureComputeServiceLiveTest s but no others. Are there any others I should run?
Yes it would be nice if it was on master and 2.0.x thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#issuecomment-324674570
Re: [jclouds/jclouds-labs] Cleanup extraneous (#409)
Posted by Andrea Turli <no...@github.com>.
Closed #409.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#event-1221021740
Re: [jclouds/jclouds-labs] Cleanup extraneous (#409)
Posted by Duncan Grant <no...@github.com>.
I've created a jira for this https://issues.apache.org/jira/browse/JCLOUDS-1329.
Sorry for doing that in the wrong order but I thought I'd already created one.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#issuecomment-324652633
Re: [jclouds/jclouds-labs] Cleanup extraneous (#409)
Posted by Duncan Grant <no...@github.com>.
@andreaturli I've added a comment (which I had expected to be picked up from the commit but obviously not). Do you want me to expend on that?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#issuecomment-324654523
Re: [jclouds/jclouds-labs] Cleanup extraneous (#409)
Posted by Andrea Turli <no...@github.com>.
lgtm, have you live tested?
I'd imagine you need it in master and 2.0.x branch, yes?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#issuecomment-324673899
Re: [jclouds/jclouds-labs] Cleanup extraneous (#409)
Posted by Andrea Turli <no...@github.com>.
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/3a63007f) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6d00302c)
Thanks @duncangrant
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#issuecomment-324846192
Re: [jclouds/jclouds-labs] Cleanup extraneous (#409)
Posted by Andrea Turli <no...@github.com>.
merging
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#issuecomment-324841031