You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Apache9 (via GitHub)" <gi...@apache.org> on 2023/03/16 07:58:16 UTC
[GitHub] [hbase] Apache9 commented on a diff in pull request #5100: HBASE-27712 Remove unused params in region metrics
Apache9 commented on code in PR #5100:
URL: https://github.com/apache/hbase/pull/5100#discussion_r1138253165
##########
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java:
##########
@@ -73,15 +73,14 @@ public interface MetricsRegionSource extends Comparable<MetricsRegionSource> {
void updateDelete();
/**
- * Update time of gets
- * @param mills time for this get operation.
+ * Update related counts of gets
*/
- void updateGet(long mills);
+ void updateGet();
/**
- * Update time used of resultScanner.next().
+ * Update related counts of resultScanner.next().
*/
- void updateScanTime(long mills);
+ void updateScanCount();
Review Comment:
Why not call it updateScan? We do not have count suffix in other method names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org