You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/30 00:46:03 UTC

[GitHub] [incubator-superset] nytai commented on a change in pull request #11111: style(listview): dynamic card size and grid spacing

nytai commented on a change in pull request #11111:
URL: https://github.com/apache/incubator-superset/pull/11111#discussion_r497183094



##########
File path: superset/utils/screenshots.py
##########
@@ -203,4 +203,4 @@ class DashboardScreenshot(BaseScreenshot):
     thumbnail_type: str = "dashboard"
     element: str = "grid-container"
     window_size: WindowSize = (1600, int(1600 * 0.75))
-    thumb_size: WindowSize = (400, int(400 * 0.75))
+    thumb_size: WindowSize = (800, int(800 * 0.75))

Review comment:
       Because cards can now be larger, we need to bump resolution so we don't end up with pixelated images. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org