You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by radarwave <gi...@git.apache.org> on 2016/01/07 07:19:42 UTC
[GitHub] incubator-hawq pull request: HAWQ-271 Remove netperf-2.4.3
GitHub user radarwave opened a pull request:
https://github.com/apache/incubator-hawq/pull/251
HAWQ-271 Remove netperf-2.4.3
1. Remove netperf tarball and Makefile.
2. Removed some debug output introduced by last merge.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radarwave/incubator-hawq netperf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/251.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #251
----
commit 6eb8b786dad3b0518bbc0483155ad8bc1bc988de
Author: rlei <rl...@pivotal.io>
Date: 2016-01-07T04:57:34Z
HAWQ-271. Remove netperf-2.4.3.tar.gz
commit 0a9f657d925c82c0b84da1c1f7d375aaa67a2fdc
Author: rlei <rl...@pivotal.io>
Date: 2016-01-07T05:14:21Z
HAWQ-271. Remove some debug info come from merge
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-271 Remove netperf-2.4.3
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/251#issuecomment-177047128
Already merged, close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-271 Remove netperf-2.4.3
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave closed the pull request at:
https://github.com/apache/incubator-hawq/pull/251
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-271 Remove netperf-2.4.3
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/251#issuecomment-169590961
The fix looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-271 Remove netperf-2.4.3
Posted by xinzweb <gi...@git.apache.org>.
Github user xinzweb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/251#issuecomment-169775756
@hsyuan helped me work out a workaround on OSX.
If you are using OSX, this is a quick workaround we tried to get it working again:
brew install postgresql
sudo easy_install pip
sudo pip --retries=50 --timeout=300 install pg8000 simplejson unittest2 pycrypto pygresql pyyaml lockfile paramiko psi
sudo pip --retries=50 --timeout=300 install http://darcs.idyll.org/~t/projects/figleaf-0.6.1.tar.gz && \
sudo pip --retries=50 --timeout=300 install http://sourceforge.net/projects/pychecker/files/pychecker/0.8.19/pychecker-0.8.19.tar.gz/download && \
Also, update the **greenplum_path.sh** to remove the **$GPHOME/ext/python/bin** so that default python can be used instead of the one come with hawq.
@radarwave since we no-longer depends on the python came with HAWQ, shall we just remote the **$GPHOME/ext/python**?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-271 Remove netperf-2.4.3
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/251#discussion_r49045335
--- Diff: tools/bin/gppylib/commands/base.py ---
@@ -697,17 +697,10 @@ def __str__(self):
def run(self,validateAfter=False):
faultPoint = os.getenv('GP_COMMAND_FAULT_POINT')
- print "### DEBUG: ENV[GP_COMMAND_FAULT_POINT] = %s" % (faultPoint if faultPoint else "None")
- print "### DEBUG: self.name = %s" % ("SomeName" if self.name else "None")
if not faultPoint or (self.name and not self.name.startswith(faultPoint)):
- print "### DEBUG: EXECUTE name = %s" % ("SomeName" if self.name else "None")
- print "### DEBUG: EXECUTE cmdStr = %s" % ("SomeCmdStr" if self.cmdStr else "None")
- print "### DEBUG: EXECUTE context = %s" % ("SomeExecContext" if self.exec_context else "None")
- print "### DEBUG: EXECUTE remoteHost = %s" % ("SomeRemoteHost" if self.remoteHost else "None")
self.exec_context.execute(self)
else:
# simulate error
- print "### DEBUG: CommandResult"
self.results = CommandResult(1,'Fault Injection','Fault Injection' ,False,True)
print self.results
--- End diff --
This also needs to be removed:
print self.results
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-271 Remove netperf-2.4.3
Posted by cwelton <gi...@git.apache.org>.
Github user cwelton commented on the pull request:
https://github.com/apache/incubator-hawq/pull/251#issuecomment-176997697
All tests passing, two +1s. What is preventing this PR from being resolved?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-271 Remove netperf-2.4.3
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the pull request:
https://github.com/apache/incubator-hawq/pull/251#issuecomment-169607174
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---