You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "shanedell (via GitHub)" <gi...@apache.org> on 2024/12/05 20:10:31 UTC
[PR] Add README.md to VSIX when built [daffodil-vscode]
shanedell opened a new pull request, #1141:
URL: https://github.com/apache/daffodil-vscode/pull/1141
Add README.md to VSIX when built
Closes #1136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] README.md updates [daffodil-vscode]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #1141:
URL: https://github.com/apache/daffodil-vscode/pull/1141#discussion_r1872024973
##########
webpack/ext-package.webpack.config.js:
##########
@@ -101,7 +101,7 @@ module.exports = /** @type WebpackConfig */ {
plugins: [
new CopyPlugin({
patterns: [
- // { from: 'build/package/.vscodeignore', to: pkg_dir },
+ { from: 'README.md', to: pkg_dir },
Review Comment:
Should this be ```to: `${pkg_dir}` ``` like the others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] README.md updates [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on code in PR #1141:
URL: https://github.com/apache/daffodil-vscode/pull/1141#discussion_r1872027984
##########
webpack/ext-package.webpack.config.js:
##########
@@ -101,7 +101,7 @@ module.exports = /** @type WebpackConfig */ {
plugins: [
new CopyPlugin({
patterns: [
- // { from: 'build/package/.vscodeignore', to: pkg_dir },
+ { from: 'README.md', to: pkg_dir },
Review Comment:
Yup that was a typo, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] README.md updates [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell merged PR #1141:
URL: https://github.com/apache/daffodil-vscode/pull/1141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org