You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openwhisk.apache.org by gi...@git.apache.org on 2017/05/25 22:12:20 UTC
[GitHub] ddragosd commented on a change in pull request #2282: Distributed tracing support #2192
ddragosd commented on a change in pull request #2282: Distributed tracing support #2192
URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r118597128
##########
File path: core/controller/src/main/scala/whisk/core/controller/Controller.scala
##########
@@ -171,8 +173,8 @@ object Controller {
def main(args: Array[String]): Unit = {
implicit val actorSystem = ActorSystem("controller-actor-system")
- implicit val logger = new AkkaLogging(akka.event.Logging.getLogger(actorSystem, this))
-
+ implicit val logger = new ZipkinLogging(new AkkaLogging(akka.event.Logging.getLogger(actorSystem, this)))
Review comment:
@rabbah are you suggesting to build the `ZipkinLogging` as a separate artifact ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services