You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/10/13 17:29:24 UTC
[kudu-CR](branch-1.17.x) [arm64] implement with native NEON instructions
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20576
Change subject: [arm64] implement with native NEON instructions
......................................................................
[arm64] implement with native NEON instructions
This patch removes the dependence on sse2neon by rewriting SSE2 and AVX code
with native NEON instructions.
Change-Id: Id46816439d2741d1d095df4e53d6199ad7a9f6db
Reviewed-on: http://gerrit.cloudera.org:8080/20374
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 1351c19a94a09fc80b8e87c02d233d38706d7c23)
---
M build-support/lint.sh
M src/kudu/common/columnar_serialization.cc
M src/kudu/common/zp7.cc
M src/kudu/util/block_bloom_filter.cc
M src/kudu/util/char_util.cc
M src/kudu/util/group_varint-inl.h
D src/kudu/util/sse2neon.h
7 files changed, 110 insertions(+), 9,103 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/20576/1
--
To view, visit http://gerrit.cloudera.org:8080/20576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id46816439d2741d1d095df4e53d6199ad7a9f6db
Gerrit-Change-Number: 20576
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
[kudu-CR](branch-1.17.x) [arm64] implement with native NEON instructions
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20576 )
Change subject: [arm64] implement with native NEON instructions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id46816439d2741d1d095df4e53d6199ad7a9f6db
Gerrit-Change-Number: 20576
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 15 Oct 2023 16:33:59 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [arm64] implement with native NEON instructions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20576 )
Change subject: [arm64] implement with native NEON instructions
......................................................................
[arm64] implement with native NEON instructions
This patch removes the dependence on sse2neon by rewriting SSE2 and AVX code
with native NEON instructions.
Change-Id: Id46816439d2741d1d095df4e53d6199ad7a9f6db
Reviewed-on: http://gerrit.cloudera.org:8080/20374
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 1351c19a94a09fc80b8e87c02d233d38706d7c23)
Reviewed-on: http://gerrit.cloudera.org:8080/20576
Reviewed-by: <sp...@amazon.com>
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M build-support/lint.sh
M src/kudu/common/columnar_serialization.cc
M src/kudu/common/zp7.cc
M src/kudu/util/block_bloom_filter.cc
M src/kudu/util/char_util.cc
M src/kudu/util/group_varint-inl.h
D src/kudu/util/sse2neon.h
7 files changed, 110 insertions(+), 9,103 deletions(-)
Approvals:
spop@amazon.com: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Id46816439d2741d1d095df4e53d6199ad7a9f6db
Gerrit-Change-Number: 20576
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [arm64] implement with native NEON instructions
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
spop@amazon.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20576 )
Change subject: [arm64] implement with native NEON instructions
......................................................................
Patch Set 1: Code-Review+1
Looks good to me. Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/20576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id46816439d2741d1d095df4e53d6199ad7a9f6db
Gerrit-Change-Number: 20576
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 13 Oct 2023 17:45:41 +0000
Gerrit-HasComments: No