[GitHub] [spark] ssimeonov commented on issue #27834: revert [SPARK-24640][SQL] Return `NULL` from `size(NULL)` by default

[GitBox <gi...@apache.org>]

ssimeonov commented on issue #27834: revert [SPARK-24640][SQL] Return `NULL` from `size(NULL)` by default
URL: https://github.com/apache/spark/pull/27834#issuecomment-595895765
 
 
   Thanks @MaxGekk. Yes, after discovering this, we had to comb from our entire codebase to refactor `size(column)` into `column.size`, adding our own implicit. 
   
   Taking a step back, a `-1` return from a function reeks of non-SQL thinking by whoever implemented this in Hive originally. As Spark grows, its audience is expanding rapidly. We need to move away from random engineer decisions made many years ago in a different product towards what makes sense for the future (much larger) audience of Spark users.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org