You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/06 13:56:29 UTC

[GitHub] [superset] michael-s-molina commented on pull request #20606: feat(dashboard): Transition to Explore with React Router

michael-s-molina commented on PR #20606:
URL: https://github.com/apache/superset/pull/20606#issuecomment-1176254293

   The difference in loading time is better than we expected! Some first-pass comments:
   
   I think `DASHBOARD_EDIT_CHART_IN_TAB` or some version of it is more descriptive than `DASHBOARD_TO_EXPLORE_SPA`. Especially because in the future it will be a single application and SPA references won't make any sense (native filters? 😆)
   
   When opening in the same tab, we can pass the `form_data` using React Router state and avoid the extra GET in Explore. We should still execute the POST to support Explore refreshes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org