You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Andrew Sherman (Code Review)" <ge...@cloudera.org> on 2023/02/17 01:42:09 UTC

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19509


Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.
......................................................................

IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

Traditionally table metadata is loaded by the catalog and sent as thrift
to the Impala daemons. With Iceberg tables, some metadata, for example
the org.apache.iceberg.Table, is loaded in the Coordinator at the same
time as the thrift description is being deserialized. If the loading of
the org.apache.iceberg.Table fails, perhaps because of missing Iceberg
metadata, then the loading of the table fails. This can cause an
infinite loop as StmtMetadataLoader.loadTables() waits hopefully for
the catalog to send a new version of the table.

Prevent this situation by substituting a IncompleteTable if a
TableLoadingException occurs.

TESTING

Add a new test originally developed for IMPALA-11330 which tests
failures after deleting Iceberg metadata.

Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
---
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/query_test/test_iceberg.py
2 files changed, 48 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/19509/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19509

to look at the new patch set (#6).

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................

IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Traditionally table metadata is loaded by the catalog and sent as thrift
to the Impala daemons. With Iceberg tables, some metadata, for example
the org.apache.iceberg.Table, is loaded in the Coordinator at the same
time as the Thrift description is being deserialized. If the loading of
the org.apache.iceberg.Table fails, perhaps because of missing Iceberg
metadata, then the loading of the table fails. This can cause an
infinite loop as StmtMetadataLoader.loadTables() waits hopefully for
the catalog to send a new version of the table.

Change some Iceberg table loading methods to throw
IcebergTableLoadingException when a failure occurs. Prevent the hang by
substituting in an IncompleteTable if an IcebergTableLoadingException
occurs.

TESTING

Add a new test, originally developed for IMPALA-11330, which tests
failures after deleting Iceberg metadata.

Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
---
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHiveCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
9 files changed, 70 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/19509/6
-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9182/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Mar 2023 16:31:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 10: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Mar 2023 21:42:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19509

to look at the new patch set (#4).

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................

IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Traditionally table metadata is loaded by the catalog and sent as thrift
to the Impala daemons. With Iceberg tables, some metadata, for example
the org.apache.iceberg.Table, is loaded in the Coordinator at the same
time as the thrift description is being deserialized. If the loading of
the org.apache.iceberg.Table fails, perhaps because of missing Iceberg
metadata, then the loading of the table fails. This can cause an
infinite loop as StmtMetadataLoader.loadTables() waits hopefully for
the catalog to send a new version of the table.

Change some Iceberg table loading methods to throw
IcebergTableLoadingException when a failure occurs. Prevent the hang by
substituting in an IncompleteTable if an IcebergTableLoadingException
occurs.

TESTING

Add a new test, originally developed for IMPALA-11330, which tests
failures after deleting Iceberg metadata.

Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
---
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHiveCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
9 files changed, 71 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/19509/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py@145
PS4, Line 145:   def test_drop_corrupt_table(self, unique_database):
> The good news is that test_drop_incomplete_table runs...
I'm a bit rusty with this part of the code but I'm wondering what the outcome of this failing test is. I mean is it still visible from Impala as a valid table?
"Test DROP TABLE when the underlying directory is deleted. In that case table
    loading fails, but we should be still able to drop the table from Impala."
I guess if we end up dropping the table from Impala's perspective (from the file system is already dropped so I guess we have to make sure that the catalog/HMS part is also dropped) then we are fine. We might want to swallow that exception, though.



-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Mar 2023 11:44:38 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................

IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Traditionally table metadata is loaded by the catalog and sent as thrift
to the Impala daemons. With Iceberg tables, some metadata, for example
the org.apache.iceberg.Table, is loaded in the Coordinator at the same
time as the thrift description is being deserialized. If the loading of
the org.apache.iceberg.Table fails, perhaps because of missing Iceberg
metadata, then the loading of the table fails. This can cause an
infinite loop as StmtMetadataLoader.loadTables() waits hopefully for
the catalog to send a new version of the table.

Change some Iceberg table loading methods to throw
IcebergTableLoadingException when a failure occurs. Prevent the hang by
substituting in an IncompleteTable if an IcebergTableLoadingException
occurs.

TESTING

Add a new test, originally developed for IMPALA-11330, which tests
failures after deleting Iceberg metadata.

Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
---
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHiveCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
8 files changed, 70 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/19509/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19509/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19509/2//COMMIT_MSG@15
PS2, Line 15: StmtMetadataLoader.loadTables() waits hopefully
> I am no expert on StmtTableCache.loadTables(). Having an infinite loop does
Cancel the query, alert the user that's something is wrong with that particular tables metadata, so it can be investigated.

My problem is not with the passiveness of the loop, what I don't like is the Coordinator responsiveness depends on another process' state. I think it's the Coordinators responsibility to make sure it does not get stuck in any case.


http://gerrit.cloudera.org:8080/#/c/19509/2/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:

http://gerrit.cloudera.org:8080/#/c/19509/2/fe/src/main/java/org/apache/impala/catalog/Table.java@549
PS2, Line 549:     newTable.validate();
> Yes you’re right, that could happen. I suppose that mismatched columns is a
I don't mind narrowing down the scope for iceberg specific case, and yes I agree, throwing from .validate() is much more serious, probably should be handled differently



-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 08:39:37 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................

IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Traditionally table metadata is loaded by the catalog and sent as thrift
to the Impala daemons. With Iceberg tables, some metadata, for example
the org.apache.iceberg.Table, is loaded in the Coordinator at the same
time as the thrift description is being deserialized. If the loading of
the org.apache.iceberg.Table fails, perhaps because of missing Iceberg
metadata, then the loading of the table fails. This can cause an
infinite loop as StmtMetadataLoader.loadTables() waits hopefully for
the catalog to send a new version of the table.

Change some Iceberg table loading methods to throw
IcebergTableLoadingException when a failure occurs. Prevent the hang by
substituting in an IncompleteTable if an IcebergTableLoadingException
occurs.

The test test_drop_incomplete_table had previously been disabled because
of IMPALA-11509. To re-enable this required a second change. The way
that DROP TABLE is executed on an iceberg table depends on which
Iceberg catalog is being used. If this Iceberg catalog is not a Hive
catalog then the execution happens in two parts, first the Iceberg
table is dropped, then the table is dropped in HMS. If this case, if
the drop fails in Iceberg, we should still continue on to perform the
drop in HMS.

TESTING

- Add a new test, originally developed for IMPALA-11330, which tests
  failures after deleting Iceberg metadata.
- Re-enable test_drop_incomplete_table().

Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Reviewed-on: http://gerrit.cloudera.org:8080/19509
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHiveCatalog.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
10 files changed, 95 insertions(+), 34 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 11
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 4:

(2 comments)

Thanks for taking care of this, Andrew!

http://gerrit.cloudera.org:8080/#/c/19509/4/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:

http://gerrit.cloudera.org:8080/#/c/19509/4/fe/src/main/java/org/apache/impala/catalog/Table.java@544
PS4, Line 544:           e);
nit: putting this into new line seems a bit odd.


http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py@145
PS4, Line 145:   def test_drop_corrupt_table(self, unique_database):
About testing this: I remember when I ran into this issue, I had to turn off a test until we have a fix. Would be great if we could turn it on again. It was 'test_drop_incomplete_table', here:
https://gerrit.cloudera.org/#/c/18837/10/tests/query_test/test_iceberg.py
This test sporadically got into infinite loop if I remember right, so might need few runs to reproduce the issue.



-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Mar 2023 11:22:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 5:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/12540/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Mar 2023 16:55:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19509

to look at the new patch set (#9).

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................

IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Traditionally table metadata is loaded by the catalog and sent as thrift
to the Impala daemons. With Iceberg tables, some metadata, for example
the org.apache.iceberg.Table, is loaded in the Coordinator at the same
time as the thrift description is being deserialized. If the loading of
the org.apache.iceberg.Table fails, perhaps because of missing Iceberg
metadata, then the loading of the table fails. This can cause an
infinite loop as StmtMetadataLoader.loadTables() waits hopefully for
the catalog to send a new version of the table.

Change some Iceberg table loading methods to throw
IcebergTableLoadingException when a failure occurs. Prevent the hang by
substituting in an IncompleteTable if an IcebergTableLoadingException
occurs.

The test test_drop_incomplete_table had previously been disabled because
of IMPALA-11509. To re-enable this required a second change. The way
that DROP TABLE is executed on an iceberg table depends on which
Iceberg catalog is being used. If this Iceberg catalog is not a Hive
catalog then the execution happens in two parts, first the Iceberg
table is dropped, then the table is dropped in HMS. If this case, if
the drop fails in Iceberg, we should still continue on to perform the
drop in HMS.

TESTING

- Add a new test, originally developed for IMPALA-11330, which tests
  failures after deleting Iceberg metadata.
- Re-enable test_drop_incomplete_table().

Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
---
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHiveCatalog.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
10 files changed, 95 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/19509/9
-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 5:

recheck


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Mar 2023 18:11:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12639/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Mar 2023 19:17:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12578/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 02:33:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.
......................................................................


Patch Set 2:

(2 comments)

Thanks for the review. 
I have answers to the questions, these seem like judgement calls.
I do welcome more feedback.

http://gerrit.cloudera.org:8080/#/c/19509/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19509/2//COMMIT_MSG@15
PS2, Line 15: StmtMetadataLoader.loadTables() waits hopefully
> Maybe we could consider implementing a maximum number for retries when we r
I am no expert on StmtTableCache.loadTables(). Having an infinite loop does seem scary but it is not passive, in the sense that it is not just waiting for updates, instead it does keep issuing load requests to the catalogd. 
If one were to change the logic then what would we do? We would probably end up just calling StmtTableCache.loadTables() again.


http://gerrit.cloudera.org:8080/#/c/19509/2/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:

http://gerrit.cloudera.org:8080/#/c/19509/2/fe/src/main/java/org/apache/impala/catalog/Table.java@549
PS2, Line 549:     newTable.validate();
> Wouldn't we get stuck the same way if newTable.validate() would throw a Tab
Yes you’re right, that could happen. I suppose that mismatched columns is actually a much more serious issue.
I certainly could expand the scope of my new try…catch block but if anything I would want to reduce it. I did consider changing the catch to being for IcebergTableLoadingException, and making IcebergUtil.loadTable throw a IcebergTableLoadingException.



-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 21:51:37 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19509

to look at the new patch set (#7).

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................

IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Traditionally table metadata is loaded by the catalog and sent as thrift
to the Impala daemons. With Iceberg tables, some metadata, for example
the org.apache.iceberg.Table, is loaded in the Coordinator at the same
time as the Thrift description is being deserialized. If the loading of
the org.apache.iceberg.Table fails, perhaps because of missing Iceberg
metadata, then the loading of the table fails. This can cause an
infinite loop as StmtMetadataLoader.loadTables() waits hopefully for
the catalog to send a new version of the table.

Change some Iceberg table loading methods to throw
IcebergTableLoadingException when a failure occurs. Prevent the hang by
substituting in an IncompleteTable if an IcebergTableLoadingException
occurs.

TESTING

Add a new test, originally developed for IMPALA-11330, which tests
failures after deleting Iceberg metadata.

Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
---
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHiveCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
9 files changed, 71 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/19509/7
-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 7: Code-Review+1

LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 16:04:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.
......................................................................


Patch Set 2:

(2 comments)

Thanks for fixing it, added few small questions

http://gerrit.cloudera.org:8080/#/c/19509/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19509/2//COMMIT_MSG@15
PS2, Line 15: StmtMetadataLoader.loadTables() waits hopefully
Maybe we could consider implementing a maximum number for retries when we rely on the catalogd being in a sane state, so at least he query would not hang.


http://gerrit.cloudera.org:8080/#/c/19509/2/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:

http://gerrit.cloudera.org:8080/#/c/19509/2/fe/src/main/java/org/apache/impala/catalog/Table.java@549
PS2, Line 549:     newTable.validate();
Wouldn't we get stuck the same way if newTable.validate() would throw a TableLoadingException?



-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 08:58:03 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12637/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 8
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Mar 2023 17:26:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 10: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Mar 2023 16:31:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 4:

(2 comments)

Thanks for the review

http://gerrit.cloudera.org:8080/#/c/19509/4/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:

http://gerrit.cloudera.org:8080/#/c/19509/4/fe/src/main/java/org/apache/impala/catalog/Table.java@544
PS4, Line 544:           e);
> nit: putting this into new line seems a bit odd.
That's what clang-format seems to want :-) 
But I agree and have changed it.


http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py@145
PS4, Line 145:   def test_drop_corrupt_table(self, unique_database):
> About testing this: I remember when I ran into this issue, I had to turn of
The good news is that test_drop_incomplete_table runs...
(I did not stress test)
The bads new is that it consistently fails with Query aborted:TableNotFoundException: Table 'test_drop_incomplete_table_8548cb55.synchronized_iceberg_tbl' does not exist in Iceberg catalog.
Maybe we need to just never throw the TableNotFoundException in IcebergCatalogOpExecutor.dropTable()



-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Mar 2023 01:45:58 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19509/1/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:

http://gerrit.cloudera.org:8080/#/c/19509/1/fe/src/main/java/org/apache/impala/catalog/Table.java@542
PS1, Line 542:       LOG.warn(String.format("The table %s in database %s could not be loaded from thrift.",
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/19509/1/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/19509/1/tests/query_test/test_iceberg.py@176
PS1, Line 176: o
flake8: W504 line break after binary operator



-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Feb 2023 01:43:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 2:

(2 comments)

Narrowed the scope of the catch, some other minor edits

http://gerrit.cloudera.org:8080/#/c/19509/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19509/2//COMMIT_MSG@15
PS2, Line 15: StmtMetadataLoader.loadTables() waits hopefully
> Cancel the query, alert the user that's something is wrong with that partic
I've created IMPALA-11936 to cover this


http://gerrit.cloudera.org:8080/#/c/19509/2/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:

http://gerrit.cloudera.org:8080/#/c/19509/2/fe/src/main/java/org/apache/impala/catalog/Table.java@549
PS2, Line 549:     newTable.validate();
> I don't mind narrowing down the scope for iceberg specific case, and yes I 
Thanks, I've done this, see PS 3.



-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Feb 2023 00:16:35 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12423/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Feb 2023 00:33:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 9: Code-Review+2

Thanks for the change, Andrew!


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Mar 2023 13:14:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19509

to look at the new patch set (#2).

Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.
......................................................................

IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

Traditionally table metadata is loaded by the catalog and sent as thrift
to the Impala daemons. With Iceberg tables, some metadata, for example
the org.apache.iceberg.Table, is loaded in the Coordinator at the same
time as the thrift description is being deserialized. If the loading of
the org.apache.iceberg.Table fails, perhaps because of missing Iceberg
metadata, then the loading of the table fails. This can cause an
infinite loop as StmtMetadataLoader.loadTables() waits hopefully for
the catalog to send a new version of the table.

Prevent this situation by substituting a IncompleteTable if a
TableLoadingException occurs.

TESTING

Add a new test originally developed for IMPALA-11330 which tests
failures after deleting Iceberg metadata.

Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
---
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/query_test/test_iceberg.py
2 files changed, 47 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/19509/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12391/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Feb 2023 02:02:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12392/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Feb 2023 02:36:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................

IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Traditionally table metadata is loaded by the catalog and sent as thrift
to the Impala daemons. With Iceberg tables, some metadata, for example
the org.apache.iceberg.Table, is loaded in the Coordinator at the same
time as the thrift description is being deserialized. If the loading of
the org.apache.iceberg.Table fails, perhaps because of missing Iceberg
metadata, then the loading of the table fails. This can cause an
infinite loop as StmtMetadataLoader.loadTables() waits hopefully for
the catalog to send a new version of the table.

Change some Iceberg table loading methods to throw
IcebergTableLoadingException when a failure occurs. Prevent the hang by
substituting in an IncompleteTable if an IcebergTableLoadingException
occurs.

TESTING

Add a new test, originally developed for IMPALA-11330, which tests
failures after deleting Iceberg metadata.

Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
---
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHiveCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
9 files changed, 70 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/19509/5
-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 9:

PS 9 is a rebase to fix merge conflicts caused by own over-eager fixing of comments elsewhere.


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Mar 2023 18:59:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19509

to look at the new patch set (#8).

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................

IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Traditionally table metadata is loaded by the catalog and sent as thrift
to the Impala daemons. With Iceberg tables, some metadata, for example
the org.apache.iceberg.Table, is loaded in the Coordinator at the same
time as the thrift description is being deserialized. If the loading of
the org.apache.iceberg.Table fails, perhaps because of missing Iceberg
metadata, then the loading of the table fails. This can cause an
infinite loop as StmtMetadataLoader.loadTables() waits hopefully for
the catalog to send a new version of the table.

Change some Iceberg table loading methods to throw
IcebergTableLoadingException when a failure occurs. Prevent the hang by
substituting in an IncompleteTable if an IcebergTableLoadingException
occurs.

The test test_drop_incomplete_table had previously been disabled because
of IMPALA-11509. To re-enable this required a second change. The way
that DROP TABLE is executed on an iceberg table depends on which
Iceberg catalog is being used. If this Iceberg catalog is not a Hive
catalog then the execution happens in two parts, first the Iceberg
table is dropped, then the table is dropped in HMS. If this case, if
the drop fails in Iceberg, we should still continue on to perform the
drop in HMS.

TESTING

- Add a new test, originally developed for IMPALA-11330, which tests
  failures after deleting Iceberg metadata.
- Re-enable test_drop_incomplete_table().

Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
---
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHiveCatalog.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
10 files changed, 95 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/19509/8
-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 8
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 4:

(1 comment)

Thanks for the reviews

http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py@145
PS4, Line 145:   def test_drop_corrupt_table(self, unique_database):
> I'm a bit rusty with this part of the code but I'm wondering what the outco
Thanks for the prompt, I went ahead and made a fix. 
See the commit message for details.



-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Mar 2023 17:17:46 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )

Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12425/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421
Gerrit-Change-Number: 19509
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Feb 2023 18:38:57 +0000
Gerrit-HasComments: No