You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/30 04:08:27 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #2391: fix(github): change pr title type to long text
warren830 opened a new pull request, #2391:
URL: https://github.com/apache/incubator-devlake/pull/2391
# Summary
change github.pr.title from varchar(255) to longtext
### Does this close any open issues?
closes #2363
### Screenshots
<img width="892" alt="image" src="https://user-images.githubusercontent.com/39366025/176590644-c5f90b9d-ef7d-4d85-b5c6-de2d5c66b0ea.png">
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #2391: fix(github): change pr title type to long text
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #2391:
URL: https://github.com/apache/incubator-devlake/pull/2391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #2391: fix(github): change pr title type to long text
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #2391:
URL: https://github.com/apache/incubator-devlake/pull/2391#discussion_r910608943
##########
plugins/github/impl/impl.go:
##########
@@ -55,24 +55,24 @@ func (plugin Github) SubTaskMetas() []core.SubTaskMeta {
tasks.ExtractApiIssuesMeta,
tasks.CollectApiPullRequestsMeta,
tasks.ExtractApiPullRequestsMeta,
- tasks.CollectApiCommentsMeta,
- tasks.ExtractApiCommentsMeta,
- tasks.CollectApiEventsMeta,
- tasks.ExtractApiEventsMeta,
- tasks.CollectApiPullRequestCommitsMeta,
- tasks.ExtractApiPullRequestCommitsMeta,
- tasks.CollectApiPullRequestReviewsMeta,
- tasks.ExtractApiPullRequestReviewersMeta,
- tasks.CollectApiCommitsMeta,
- tasks.ExtractApiCommitsMeta,
- tasks.CollectApiCommitStatsMeta,
- tasks.ExtractApiCommitStatsMeta,
- tasks.EnrichPullRequestIssuesMeta,
+ //tasks.CollectApiCommentsMeta,
Review Comment:
Emmm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on pull request #2391: fix(github): change pr title type to long text
Posted by GitBox <gi...@apache.org>.
likyh commented on PR #2391:
URL: https://github.com/apache/incubator-devlake/pull/2391#issuecomment-1170738558
Maybe you can target to add some e2e tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2391: fix(github): change pr title type to long text
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2391:
URL: https://github.com/apache/incubator-devlake/pull/2391#discussion_r910660771
##########
plugins/github/impl/impl.go:
##########
@@ -55,24 +55,24 @@ func (plugin Github) SubTaskMetas() []core.SubTaskMeta {
tasks.ExtractApiIssuesMeta,
tasks.CollectApiPullRequestsMeta,
tasks.ExtractApiPullRequestsMeta,
- tasks.CollectApiCommentsMeta,
- tasks.ExtractApiCommentsMeta,
- tasks.CollectApiEventsMeta,
- tasks.ExtractApiEventsMeta,
- tasks.CollectApiPullRequestCommitsMeta,
- tasks.ExtractApiPullRequestCommitsMeta,
- tasks.CollectApiPullRequestReviewsMeta,
- tasks.ExtractApiPullRequestReviewersMeta,
- tasks.CollectApiCommitsMeta,
- tasks.ExtractApiCommitsMeta,
- tasks.CollectApiCommitStatsMeta,
- tasks.ExtractApiCommitStatsMeta,
- tasks.EnrichPullRequestIssuesMeta,
+ //tasks.CollectApiCommentsMeta,
Review Comment:
my bad...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org