You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "taepper (via GitHub)" <gi...@apache.org> on 2026/07/22 12:09:08 UTC
[PR] GH-50601: [C++] refactor TranslateTo for clearer semantics [arrow]
taepper opened a new pull request, #50602:
URL: https://github.com/apache/arrow/pull/50602
### Rationale for this change
Follow-up to #50247
`GenericNullLikePartition::TranslateTo` translates a partition result from a source range to a target range. This includes pointer arithmetic and does not allow bounds checking for the source and target range, as only the range starts are given. Ideally, we want to pass the entire source and target range to the function, which will allow us to both validate sizes, guarantee that the correct source range is passed, and the resulting `GenericNullLikePartition` will point into the target range.
### What changes are included in this PR?
Additional refactor for `GenericNullLikePartition::TranslateTo`, that now allows more `DCHECK`s. Each caller already had a `std::span` object for both source and target, which is now passed in directly.
### Are these changes tested?
Re-ran existing test-suite.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50601: [C++] Refactor TranslateTo for clearer semantics [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #50602:
URL: https://github.com/apache/arrow/pull/50602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50601: [C++] refactor TranslateTo for clearer semantics [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50602:
URL: https://github.com/apache/arrow/pull/50602#issuecomment-5045591699
:warning: GitHub issue #50601 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50601: [C++] Refactor TranslateTo for clearer semantics [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50602:
URL: https://github.com/apache/arrow/pull/50602#issuecomment-5067121808
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0973268900da96c5825dd1bb6245dafc901d1ecc.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/89422135224) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org