[CForms] Change proposal in Custom bindings

[Bart Molenkamp <b....@bizzdesign.nl>]

Hi all,

A few weeks ago I made a request for a small change in
CustomJXPathBinding. It can be found here [1]. I already implemented the
change, made a patch, and placed it in bugzilla [2]. But noone was gave
me some response to this change (maybe due to vacations?) So I was
wondering; are there people interested in this change, or do I need to
maintain this change in the source tree of my project?

Bart.

[1] http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=109231695032545&w=2
[2] http://issues.apache.org/bugzilla/show_bug.cgi?id=30693

Re: [CForms] Change proposal in Custom bindings

[Marc Portier <mp...@outerthought.org>]

I had a quick scan through your problem and patches (and sorry for not 
doing that earlier)


AFAICS you would get the same effect by just ommitting the xpath from 
the binding and adding it as a nested config

ie not
   <fb:custom id="x" path="something"
              builderclass="mypack.CustomValueWrapBinding"
              factorymethod="createBinding" />

but rather
   <fb:custom id="config"
              builderclass="mypack.CustomValueWrapBinding"
              factorymethod="createBinding" >
       <fb:config propspath="some" />
   </fb:custom>

that way the path="." will be assumed on the wrapper and the 
parent-context will be passed down so your custom binding can narrow 
down with the local config 'propspath' (potentially checking for null's 
first)

see http://cocoon.apache.org/2.1/userdocs/forms/binding.html#fb%3Acustom


if you need more control then this, I suggest skipping the 
custom-binding alltogether and go straight for the own builder and 
binding + declaring the builder in the xconf file. (you're not that far off)

see 
http://cvs.apache.org/viewcvs.cgi/cocoon/trunk/src/blocks/forms/conf/forms-binding.xconf?rev=30945&root=Apache-SVN&view=auto


above seems to indicate that what you need can be done already, pls 
comment if that is not the case

regards,
-marc=


Bart Molenkamp wrote:
> Hi all,
> 
> A few weeks ago I made a request for a small change in
> CustomJXPathBinding. It can be found here [1]. I already implemented the
> change, made a patch, and placed it in bugzilla [2]. But noone was gave
> me some response to this change (maybe due to vacations?) So I was
> wondering; are there people interested in this change, or do I need to
> maintain this change in the source tree of my project?
> 
> Bart.
> 
> [1] http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=109231695032545&w=2
> [2] http://issues.apache.org/bugzilla/show_bug.cgi?id=30693
> 

-- 
Marc Portier                            http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
Read my weblog at                http://blogs.cocoondev.org/mpo/
mpo@outerthought.org                              mpo@apache.org