You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2022/09/12 16:13:30 UTC

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18968


Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................

IMPALA-11573:  Certain methods used by the replanning feature can be improved

This patch improves certain methods used by the replan feature
(IMPALA-10992) so that they can be called by the FENG compiler
component in Hive. Specifically, the declaration of these methods
becomes public static.

Testing:
1. Run unit tests;
2. Run "core" tests.

Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
1 file changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/18968/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18968 )

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11336/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Sep 2022 16:34:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18968 )

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8584/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Sep 2022 12:25:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18968 )

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Sep 2022 12:24:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18968 )

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................

IMPALA-11573:  Certain methods used by the replanning feature can be improved

This patch improves certain methods used by the replan feature
(IMPALA-10992) so that they can be called by the external frontend
component in Hive. Specifically, the declaration of these methods
becomes public static, and the initialization of a static data
member checks whether the dependent object exists.

Testing:
1. Run unit tests;
2. Run "core" tests.

Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Reviewed-on: http://gerrit.cloudera.org:8080/18968
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
1 file changed, 10 insertions(+), 9 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Quanlong Huang: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18968 )

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................


Patch Set 5: Verified+1

> Patch Set 5: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8584/

The failure is https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6332 which is tracked in IMPALA-11508.

Merging this.


-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Sep 2022 02:39:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18968 )

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Sep 2022 01:35:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18968 )

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................


Patch Set 5: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8584/


-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Sep 2022 17:33:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18968 )

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................

IMPALA-11573:  Certain methods used by the replanning feature can be improved

This patch improves certain methods used by the replan feature
(IMPALA-10992) so that they can be called by the external frontend
component in Hive. Specifically, the declaration of these methods
becomes public static, and the initialization of a static data
member checks whether the dependent object exists.

Testing:
1. Run unit tests;
2. Run "core" tests.

Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
1 file changed, 10 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/18968/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18968 )

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Sep 2022 12:25:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has removed a vote on this change.

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18968 )

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11371/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 16:07:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18968 )

Change subject: IMPALA-11573:  Certain methods used by the replanning feature can be improved
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Sep 2022 01:30:10 +0000
Gerrit-HasComments: No