[GitHub] [sling-scriptingbundle-maven-plugin] raducotescu commented on a change in pull request #6: SLING-10718 update to Parent 44

[GitBox <gi...@apache.org>]

raducotescu commented on a change in pull request #6:
URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/6#discussion_r685952023



##########
File path: src/test/resources/spotbugs-exclude.xml
##########
@@ -25,4 +25,11 @@
         <!-- false positive - https://github.com/spotbugs/spotbugs/issues/259 -->
         <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
     </Match>
+    <!-- the following two rules are just too strict in the context of this Maven plugin -->

Review comment:
       What code caused these failures?

##########
File path: pom.xml
##########
@@ -49,6 +49,7 @@
         <maven.version>3.6.0</maven.version>
         <site.jira.version.id>12344664,12347157,12348422,12350010</site.jira.version.id>

Review comment:
       Can you also please add the new release here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org