[GitHub] [tvm] driazati commented on a diff in pull request #12644: [ci] Add CSI-NN2 build to Jenkins.

[GitBox <gi...@apache.org>]

driazati commented on code in PR #12644:
URL: https://github.com/apache/tvm/pull/12644#discussion_r958721330


##########
ci/jenkins/Build.groovy.j2:
##########
@@ -259,6 +259,27 @@ stage('Build') {
       Utils.markStageSkippedForConditional('BUILD: RISC-V')
     }
   },
+  'BUILD: CSINN2': {
+    if (!skip_ci && is_docs_only_build != 1) {
+      node('CPU-SMALL') {
+        ws({{ m.per_exec_ws('tvm/build-csinn2') }}) {
+          docker_init(ci_riscv)
+          init_git()
+          sh (
+            script: "${docker_run} ${ci_riscv} ./tests/scripts/task_config_build_csinn2.sh build-csinn2-x86",
+            label: 'Create CSINN2 x86 cmake config',
+            script: "${docker_run} ${ci_riscv} ./tests/scripts/task_config_build_c906.sh build-csinn2-c906",
+            label: 'Create CSINN2 c906 cmake config',
+          )
+          make(ci_riscv, 'build-csinn2-x86', '-j2')
+          make(ci_riscv, 'build-csinn2-c906', 'tvm_rpc -j2')
+          {{ m.upload_artifacts(tag='riscv-csinn2', filenames=tvm_lib, folders=microtvm_template_projects) }}

Review Comment:
   are these used anywhere after the build step? if not you can skip the upload



##########
tests/scripts/task_config_build_c906.sh:
##########
@@ -0,0 +1,30 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+set -u

Review Comment:
   ```suggestion
   set -euxo pipefail
   ```



##########
ci/jenkins/Build.groovy.j2:
##########
@@ -259,6 +259,27 @@ stage('Build') {
       Utils.markStageSkippedForConditional('BUILD: RISC-V')
     }
   },
+  'BUILD: CSINN2': {
+    if (!skip_ci && is_docs_only_build != 1) {
+      node('CPU-SMALL') {
+        ws({{ m.per_exec_ws('tvm/build-csinn2') }}) {
+          docker_init(ci_riscv)
+          init_git()
+          sh (
+            script: "${docker_run} ${ci_riscv} ./tests/scripts/task_config_build_csinn2.sh build-csinn2-x86",
+            label: 'Create CSINN2 x86 cmake config',
+            script: "${docker_run} ${ci_riscv} ./tests/scripts/task_config_build_c906.sh build-csinn2-c906",
+            label: 'Create CSINN2 c906 cmake config',
+          )

Review Comment:
   `sh` can only handle 1 `script`/`label` combo at a time



##########
tests/scripts/task_config_build_csinn2.sh:
##########
@@ -0,0 +1,31 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+set -u

Review Comment:
   ```suggestion
   set -euxo pipefail
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org