You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/01/06 07:14:57 UTC

Review Request 65004: ATLAS-2346: fix V1 REST API to include AttributeDefinition.dataTypeName field in type details

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65004/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-2346
    https://issues.apache.org/jira/browse/ATLAS-2346


Repository: atlas


Description
-------

fixed V2=>V1 conversion of type attributes to correctly populate all fields


Diffs
-----

  intg/src/main/java/org/apache/atlas/v1/model/typedef/AttributeDefinition.java 53a008a8 
  repository/src/main/java/org/apache/atlas/repository/converters/TypeConverterUtil.java 33f092e4 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java f1d90313 


Diff: https://reviews.apache.org/r/65004/diff/1/


Testing
-------

Verified that V1 REST API returns correct values for dataTypeName field


Thanks,

Madhan Neethiraj


Re: Review Request 65004: ATLAS-2346: fix V1 REST API to include AttributeDefinition.dataTypeName field in type details

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65004/#review194930
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On Jan. 6, 2018, 7:14 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65004/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2018, 7:14 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2346
>     https://issues.apache.org/jira/browse/ATLAS-2346
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> fixed V2=>V1 conversion of type attributes to correctly populate all fields
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/v1/model/typedef/AttributeDefinition.java 53a008a8 
>   repository/src/main/java/org/apache/atlas/repository/converters/TypeConverterUtil.java 33f092e4 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java f1d90313 
> 
> 
> Diff: https://reviews.apache.org/r/65004/diff/1/
> 
> 
> Testing
> -------
> 
> Verified that V1 REST API returns correct values for dataTypeName field
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>