You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Jaroslav Tulach <ja...@oracle.com> on 2017/09/07 15:33:58 UTC

Re: Checking the headers process

On středa 6. září 2017 10:39:03 CEST Bertrand Delacretaz wrote:
> Hi,
> 
> On Wed, Sep 6, 2017 at 10:27 AM, Jaroslav Tulach
> 
> <ja...@oracle.com> wrote:
> > ...3. verify all files (except well known exceptions like manifest.mf,
> > *.form as I argued in other email) have the Apache license....
> 
> Note that
> https://urldefense.proofpoint.com/v2/url?u=https-3A__creadur.apache.org_rat
> _&d=DwIBaQ&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=tnLz5-vaI8x9g_xBB
> lFGf_ldS0-TN1M3i9fMP1FPWgk&m=jE_4oPC-6gaq8eLsIo3NQShvxWFtCHYuqc3z521KqkE&s=A
> D30hOlS-i9up2yBAY7V_iLF7xAZmXx6KkRgJ-n24-s&e=  is the standard Apache tool
> for this.
> 
> It does allow for exclusions in its configuration file - best is to
> make that check part of the release build.

Thanks for the pointer Bernard.
I've integrated rat-maven-plugin into the build:
https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans-html4j.git;a=blobdiff;f=pom.xml;h=e9e1d2a38e4d98d1b5a14b9743e066c55d02f49f;hp=0bbcdce26f38805b16e6dcf53f62f01c03ccacb9;hb=0f2bc8fb39482d6915c6b98c22d40ffaa553e34f;hpb=7c56cda29114f6dc9b09b4d42db4a8b0d2398e6a

All files in the html4j repository are clean from Apache perspective now, I 
assume.
-jt

PS: I had to exclude *.sigtest files but as they are automatically generated, I 
labeled them as having "no degree of creativity".


Re: Checking the headers process

Posted by Jaroslav Tulach <ja...@oracle.com>.
On čtvrtek 7. září 2017 11:27:56 CEST Craig Russell wrote:
> Hi Jarda,
> 
> Good job. Integrating RAT into the build/CI process is exactly what we
> (incubator) like to see.

Thanks Craig. I've updated the status with references to your words here:
https://cwiki.apache.org/confluence/display/NETBEANS/NetBeans+Transition
+Process

-jt

> 
> Adding files that have no IP to the RAT exclude list is the right thing to
> do. Probably manifest files will have the same treatment.
> 
> Craig
> 
> > On Sep 7, 2017, at 8:33 AM, Jaroslav Tulach <ja...@oracle.com>
> > wrote:> 
> > On středa 6. září 2017 10:39:03 CEST Bertrand Delacretaz wrote:
> >> Hi,
> >> 
> >> On Wed, Sep 6, 2017 at 10:27 AM, Jaroslav Tulach
> >> 
> >> <ja...@oracle.com> wrote:
> >>> ...3. verify all files (except well known exceptions like manifest.mf,
> >>> *.form as I argued in other email) have the Apache license....
> >> 
> >> Note that
> >> https://urldefense.proofpoint.com/v2/url?u=https-3A__creadur.apache.org_r
> >> at
> >> _&d=DwIBaQ&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=tnLz5-vaI8x9g_
> >> xBB
> >> lFGf_ldS0-TN1M3i9fMP1FPWgk&m=jE_4oPC-6gaq8eLsIo3NQShvxWFtCHYuqc3z521KqkE
> >> &s=A D30hOlS-i9up2yBAY7V_iLF7xAZmXx6KkRgJ-n24-s&e=  is the standard
> >> Apache tool for this.
> >> 
> >> It does allow for exclusions in its configuration file - best is to
> >> make that check part of the release build.
> > 
> > Thanks for the pointer Bernard.
> > I've integrated rat-maven-plugin into the build:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__git-2Dwip-2Dus.apache
> > .org_repos_asf-3Fp-3Dincubator-2Dnetbeans-2Dhtml4j.git-3Ba-3Dblobdiff-3Bf-
> > 3Dpom.xml-3Bh-3De9e1d2a38e4d98d1b5a14b9743e066c55d02f49f-3Bhp-3D0bbcdce26f
> > 38805b16e6dcf53f62f01c03ccacb9-3Bhb-3D0f2bc8fb39482d6915c6b98c22d40ffaa553
> > e34f-3Bhpb-3D7c56cda29114f6dc9b09b4d42db4a8b0d2398e6a&d=DwIFaQ&c=RoP1YumCX
> > CgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=tnLz5-vaI8x9g_xBBlFGf_ldS0-TN1M3i9fMP
> > 1FPWgk&m=PCY10wWPFgolxYqufMHFVuxnWLTCb_nZ48Vqw78SzFs&s=fUZ0iytjzNtJrgbJKZF
> > fvRgZIwPhGX9Wwl26rYY3U3Y&e=
> > 
> > All files in the html4j repository are clean from Apache perspective now,
> > I
> > assume.
> > -jt
> > 
> > PS: I had to exclude *.sigtest files but as they are automatically
> > generated, I labeled them as having "no degree of creativity".
> 
> Craig L Russell
> Secretary, Apache Software Foundation
> clr@apache.org
> https://urldefense.proofpoint.com/v2/url?u=http-3A__db.apache.org_jdo&d=DwI
> FaQ&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=tnLz5-vaI8x9g_xBBlFGf_ld
> S0-TN1M3i9fMP1FPWgk&m=PCY10wWPFgolxYqufMHFVuxnWLTCb_nZ48Vqw78SzFs&s=LQomln91
> qoAIeJ5Rm2GsdjbEhUlTQ_1JhIrjnr8ildY&e=



Re: Checking the headers process

Posted by Craig Russell <ap...@gmail.com>.
Hi Jarda,

Good job. Integrating RAT into the build/CI process is exactly what we (incubator) like to see. 

Adding files that have no IP to the RAT exclude list is the right thing to do. Probably manifest files will have the same treatment.

Craig

> On Sep 7, 2017, at 8:33 AM, Jaroslav Tulach <ja...@oracle.com> wrote:
> 
> On středa 6. září 2017 10:39:03 CEST Bertrand Delacretaz wrote:
>> Hi,
>> 
>> On Wed, Sep 6, 2017 at 10:27 AM, Jaroslav Tulach
>> 
>> <ja...@oracle.com> wrote:
>>> ...3. verify all files (except well known exceptions like manifest.mf,
>>> *.form as I argued in other email) have the Apache license....
>> 
>> Note that
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__creadur.apache.org_rat
>> _&d=DwIBaQ&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=tnLz5-vaI8x9g_xBB
>> lFGf_ldS0-TN1M3i9fMP1FPWgk&m=jE_4oPC-6gaq8eLsIo3NQShvxWFtCHYuqc3z521KqkE&s=A
>> D30hOlS-i9up2yBAY7V_iLF7xAZmXx6KkRgJ-n24-s&e=  is the standard Apache tool
>> for this.
>> 
>> It does allow for exclusions in its configuration file - best is to
>> make that check part of the release build.
> 
> Thanks for the pointer Bernard.
> I've integrated rat-maven-plugin into the build:
> https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans-html4j.git;a=blobdiff;f=pom.xml;h=e9e1d2a38e4d98d1b5a14b9743e066c55d02f49f;hp=0bbcdce26f38805b16e6dcf53f62f01c03ccacb9;hb=0f2bc8fb39482d6915c6b98c22d40ffaa553e34f;hpb=7c56cda29114f6dc9b09b4d42db4a8b0d2398e6a
> 
> All files in the html4j repository are clean from Apache perspective now, I 
> assume.
> -jt
> 
> PS: I had to exclude *.sigtest files but as they are automatically generated, I 
> labeled them as having "no degree of creativity".
> 

Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org http://db.apache.org/jdo