You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/29 08:18:27 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #6003: Checkstyle plugin checks test codes

wu-sheng commented on a change in pull request #6003:
URL: https://github.com/apache/skywalking/pull/6003#discussion_r549612092



##########
File path: .github/workflows/plugins-jdk14-test.0.yaml
##########
@@ -53,6 +53,8 @@ jobs:
       - uses: actions/setup-java@v1
         with:
           java-version: 8
+      - name: Add checkstyle-plugin
+        run: sed -i '/<\/sourceDirectories>/i <sourceDirectory>scenarios\/jdk14-with-gson-scenario<\/sourceDirectory>' test/plugin/pom.xml

Review comment:
       @vcjmhg Could you change this yaml as a matrix based? In case we forget we hard coded `jdk14-with-gson-scenario` here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org