You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ant.apache.org by Stefan Bodewig <bo...@apache.org> on 2005/10/19 21:16:55 UTC

Tar and resource collections

Hi all,

I think this one has earned an extra mail since it has some subtle
effects beyond "hey, I can tar up a path now".

<tar> supports resources now, any resources.

All protected method signatures in <tar> remained unchanged, I just
added a few new ones.  Classes extending <tar> shouldn't notice,
they'll reject non-file resources, but any file-system resource
collection should magically be supported by them as well.  Not that I
was aware of any subclass.

<tarfileset> is a stand-alone data-type now and can read from a source
archive (just like <zipfileset> did).

<zipresource> and <tarresource> know their Unix permissions (read from
the archive) and in <tarresource>'s case their Unix owner and group
information as well.

If you add <zipresource>s (like from a <zipfileset src="...">) or
<tarresources> (ditto) to a <tar>, the original permissions and owners
get retained (unless overridden by the attributes on *fileset).

This lead me to the commented out changes in Ant's build.xml:

    <tar longfile="gnu"
      destfile="${dist.base.binaries}/${dist.name}-bin.tar">
      <zipfileset src="${dist.base.binaries}/${dist.name}-bin.zip"/>
    </tar>

would allow us to read the permissions from the zip file instead of
duplicating the patterns.

Just, it is slow, really really slow.  Replacing both tar tasks made
"ant distribution" go from 2:45 to 6:39 on my 2GHz Pentium M WinXP
(yes, my work machine) notebook.

The reason for this is that with the <zipfileset> approach, the zip
archive gets opened and read once for scanning and then once per
resource that is added to the tar archive.  I don't see any easy way
around that, though.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org

Re: Tar and resource collections

Posted by Stefan Bodewig <bo...@apache.org>.

On Thu, 20 Oct 2005, Stefan Bodewig <bo...@apache.org> wrote:
> On Thu, 20 Oct 2005, Antoine Levy-Lambert <an...@gmx.de> wrote:
> 
>> now, I have  built and tested the current HEAD under Windows 2000,
>> cygwin, JDK 1.5 and I get a lot of errors in the testcases.
> 
> Passed for me, otherwise I wouldn't have committed it.  But I now
> see them fail in Gump as well.

Found it.  ArchiveFileSet has (had ;-) two setSrc() methods, one
taking a File and the other one taking a Resource argument.  Since
Resource has a String-arg constructors, both are potential attribute
setters to IntrospectionHelper.

On my machine IntrospectionHelper picks the File version, on your's
and on vmgump it is the Resource one.  in the later case, it is not a
FileResource and we get the exception.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org