You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by lvfangmin <gi...@git.apache.org> on 2018/08/30 16:31:34 UTC
[GitHub] zookeeper pull request #612: [ZOOKEEPER-3131] Remove watcher when session cl...
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/612
[ZOOKEEPER-3131] Remove watcher when session closed in NettyServerCnxn
Currently, it doesn't remove itself from ZK server when the cnxn is closed, which
will leak watchers, close it to make it align with NIO implementation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lvfangmin/zookeeper ZOOKEEPER-3131
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/612.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #612
----
commit 57756483957272588f8309f569781ff2550709a2
Author: Fangmin Lyu <al...@...>
Date: 2018-08-30T16:30:21Z
remove watch when session closed
----
---
[GitHub] zookeeper pull request #612: [ZOOKEEPER-3131] Remove watcher when session cl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/612
---
[GitHub] zookeeper issue #612: [ZOOKEEPER-3131] Remove watcher when session closed in...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/612
Is there any easy way to trigger the build? It's a bit painful to doing trigger this by adding empty commit.
---
[GitHub] zookeeper issue #612: [ZOOKEEPER-3131] Remove watcher when session closed in...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/612
Thanks @hanm @anmolnar, I like the "Rebuild" button, it's more convenient than check out the branch (maybe you're working on other branch and need to stash), do amend, and force push.
---
[GitHub] zookeeper issue #612: [ZOOKEEPER-3131] Remove watcher when session closed in...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/612
Close and reopen the pull request could also trigger a build, which might be more convenient than amending the commit.
For committers or those who have admin access to apache JIRA, just find the job associated with the PR, and click the "Rebuild" button.
---
[GitHub] zookeeper issue #612: [ZOOKEEPER-3131] Remove watcher when session closed in...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/612
I just triggered a build through "Rebuild", it's passing. So I am committing this patch.
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2130/
I am not sure why the result is not integrated in Jenkins check on github. I think this issue was reported before.
---
[GitHub] zookeeper issue #612: [ZOOKEEPER-3131] Remove watcher when session closed in...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/612
I usually amend the latest commit and do a force push.
---