You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/22 23:33:25 UTC

[GitHub] [incubator-hudi] satishkotha commented on issue #1540: [HUDI-819] Fix a bug with MergeOnReadLazyInsertIterable.

satishkotha commented on issue #1540:
URL: https://github.com/apache/incubator-hudi/pull/1540#issuecomment-618092361


   > +1 on the change itself.. For completeness let's also bring MergeHandle under the same factory implementation?
   
   I tried to fit in MergeHandle. But it doesn't seem to fit the pattern because constructor args requires recordItr at construction time. Other handles don't deal with recordItr directly. LazyInsertIterable deals with recordItr for these handles.  
   
   We need to make major changes to move recordItr from MergeHandle into UpdateHandler to fit it into the pattern. If you agree this is the right approach, I can implement it.
   
   What do you think? Let me know if you have other suggestions. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org